Opened 10 years ago

Closed 4 years ago

#120 closed bug (fixed)

View message - "Reply" button should be at bottom of message, not in action menu

Reported by: lemon-head Owned by: globetrotter_tt
Priority: major Milestone: 1.6
Component: BW Mail Keywords: easy, reply button, read message, message
Cc:

Description (last modified by lemon-head)

The "Reply" button on the "Read message" page should be on the bottom of a message (and maybe one more above it), not in the action menu.

It is logically related to the message, so people expect it along with the message box.


And please, the action menu (as well as other buttons) should NOT be created using javascript!!!

Change History (29)

comment:1 Changed 10 years ago by lemon-head

  • Component changed from BV Forum to BW Mail

comment:2 Changed 10 years ago by lemon-head

  • Component changed from BW Mail to BW Layout

comment:3 Changed 10 years ago by void

  • Cc rjr84@… added

please see my posting in the forum, the action menu was empty, since I didn't allow javascript. It would be nice if you check for javascript support and supply the user with a javascript free version if it's not supported.\

cheers,

void

comment:4 Changed 10 years ago by anonymous

hmpf, please remove the cc in my posting above. isn't bcc possible?

cheers,

comment:5 Changed 10 years ago by lemon-head

  • Cc rjr84@… removed
  • Description modified (diff)

cc email address removed.
bcc not possible afaik.

comment:6 Changed 9 years ago by globetrotter_tt

  • follow_up set to none
  • freq_reported set to 1
  • Owner set to globetrotter_tt
  • show_on_bw set to 0
  • Status changed from new to assigned

comment:7 Changed 9 years ago by globetrotter_tt

  • follow_up changed from none to test

comment:8 Changed 9 years ago by feuerdaemon

Tested on test.bw with IE 6.0.2900 and FF 2.0.0.13 on win XP:
Works fine for me.
Detail: You have also a "reply-button" in the "sent messages"-tab. That should be named "resend" instead of "reply".
Issue: It makes no sense to have a reply button for your drafts.

comment:9 Changed 9 years ago by globetrotter_tt

You are right. It doesn't make sense. I haven't noticed it before.

As Andreas (lemon-head) is working on a rox based message application #474, it might be better to close this ticket anyway as we won't use the old bw/mymessages.php afterwards.

comment:10 Changed 9 years ago by feuerdaemon

  • Milestone set to Bugs - not sheduled
  • Resolution set to invalid
  • Status changed from assigned to closed
  • Type changed from improve feature to bug

comment:11 Changed 9 years ago by philipp

  • Milestone changed from Bugs - not sheduled to unassigned

Milestone Bugs - not sheduled deleted

comment:12 Changed 5 years ago by TimLoal

  • Milestone changed from unassigned to Legacy Resolved

comment:13 Changed 4 years ago by shevek

  • Component changed from BW Layout to BW Mail
  • Milestone changed from Legacy Resolved to 1.6
  • Resolution invalid deleted
  • Status changed from closed to reopened

People still ask for a second reply button at the top of the message (as too many people obviously don't remove spurious text from the message).

Commit: https://gitorious.org/bewelcome/rox/commit/8bcdeac150c4906560d699d284453134207e4a06

comment:14 Changed 4 years ago by shevek

  • Status changed from reopened to local_testing

comment:15 Changed 4 years ago by shevek

Check if it is easy to move all button to the top as well.

comment:16 Changed 4 years ago by midsch

Works in Chromium and Firefox (bwbuntu, locally).

I found a small aesthetic problem in Chromium: The top "reply" button isn't under the user-picture (like in Firefox), it's right from it.

comment:17 Changed 4 years ago by shevek

Which version of Chromium? Chrome on Windows shows the button as expected on the left.

comment:18 Changed 4 years ago by midsch

-> Chromium Version 24.0.1312.56 Ubuntu 12.04 (24.0.1312.56-0ubuntu0.12.04.1)

But in the meantime I found this only happens if you choose font-size "small" or "very small" and 100% zoom in your browser settings. Font-size "normal" OR 90% zoom solves the problem. So probably no issue.

comment:19 Changed 4 years ago by shevek

That the button moved due to font size was my bad. So fixed this and added all buttons to the top: https://gitorious.org/bewelcome/rox/commit/9b78f71bff79c32602ee0aec4d69737a9dac3bc6

Did reduce the space consumed by header and footer of the message at the same time.

comment:20 Changed 4 years ago by crumbking

Looks a bit strange. As the message header is part of the message. Let's move this above the messageheader div.

comment:21 Changed 4 years ago by shevek

Agreed: https://gitorious.org/bewelcome/rox/commit/eaa540f81fa40e17bafa2afb209422e56f86ba73

Any idea why there is a bigger bottom margin around the buttons?

comment:22 Changed 4 years ago by crumbking

My guess: we apply float to an inline element.

Question: Should we disable the sidebar in /messages? Seems to be for me unused space. (a bit off topic)

comment:23 Changed 4 years ago by shevek

Could you check your guess?

Looks like an awful waste of space to me as well. But I would change that now. Maybe some weird admin interface using it that no one is aware of at the moment.

comment:24 Changed 4 years ago by shevek

The reason for the additional margin at the bottom is that <p> has margin-bottom: 0.8em set.

Setting this to margin: 0 in case of <p class="floatbox"> fixes the display.

Commit: https://gitorious.org/bewelcome/rox/commit/27f37137d88eaa7ba604f73d97ce8a43b29307d6

comment:25 Changed 4 years ago by shevek

On reply the list of languages was only shown if you had more than one. Fixed with: https://gitorious.org/bewelcome/rox/commit/7be6e724ea30333b5c3fd14d1e4f9cec38e744a2

comment:26 Changed 4 years ago by shevek

Several texts in the mailboxes aren't translatable. Fixed some: https://gitorious.org/bewelcome/rox/commit/6d6265471d17a6dbb085c347c854d8ce34b52296

comment:27 Changed 4 years ago by crumbking

  • Status changed from local_testing to to_alpha

tested locally.

comment:28 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

comment:29 Changed 4 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

Works on alpha.

Note: See TracTickets for help on using tickets.