Opened 9 years ago

Closed 6 years ago

#1226 closed bug (wontfix)

error in php error logs map.php

Reported by: jeanyves Owned by: micha
Priority: major Milestone: unassigned
Component: BW Trips Keywords: trip map
Cc: micha, lupochen, micha@…, midsch

Description

They are many errors in php error logs created because of map.php

one of them says : [30-Jun-2009 !19:52:03] PHP Notice: Undefined offset: 1 in /home/bwrox/www.bewelcome.org/build/trip/templates/map.php on line 155

it probably happen because of the line 145 in the same file which set

   

$point = rand(1,count($locations));

problem is that if the count value is 0, it returns 1 and $point is used on line 155 for an access to

$location[1]

may be the thing to investigate is why location is empty, or simply to change for

$point = rand(0,count($locations));

I don't know what to do. I think this error is quite major because it must result in the javascript failing and nobody can see it

@Micha could you see about it ?

Change History (5)

comment:1 Changed 9 years ago by micha

  • Cc micha lupochen micha@… added; micha lupochen removed
  • Component changed from unknown to BW Trips
  • follow_up changed from none to review code
  • Owner set to micha

comment:2 Changed 9 years ago by micha

  • follow_up changed from review code to test

tried to fix that in r8913. Could you check that again in the error logs for test.bw.org?

comment:3 Changed 7 years ago by globetrotter_tt

  • follow_up changed from test to none

comment:4 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:5 Changed 6 years ago by midsch

  • Cc midsch added
  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from new to closed

Outdated.

Note: See TracTickets for help on using tickets.