Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#1326 closed bug (fixed)

Faq with faq.Active!='Active' should not be displayed on Faq pages

Reported by: jeanyves Owned by: shevek
Priority: minor Milestone: 1.4
Component: BW General Keywords: Faq
Cc: sitatara, mahouni

Description

This is a small thing forgotten with the rox move.

Purpose is to able to prepare an Faq without yet displaying it (to give time to fix the text) and also to disable an Faq if it got obsolete

Change History (19)

comment:1 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:2 Changed 6 years ago by crumbking

  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from new to closed

wontfix -> welen

comment:3 Changed 6 years ago by jeanyves

Just one track notification I feel like to answer (sorry I cant follow all discussions, to much things to do in real life)

I am not sure it is good to wait for welen here.

It is an easy fix. I can't do it my self since I never succeed to setup a proper git (for test or produtcion)

The point is that several things have changed in BW (for example no more signup delay since there is no more accepting process). An now some Faq are completely meaningless and may be confusing.

1st solution: solve this ticket and set the old fashionned one to inactive, they will not provide anymore false information to member

2nd solution: fix all translated faq

3rd solution : wait for welen. I understand welen is more realistic than Drupal move, but neverless, it will take a few month so I strongly suggess to fix this small bug (solution 1) !

Last edited 6 years ago by jeanyves (previous) (diff)

comment:4 Changed 6 years ago by crumbking

Well if it's easy to fix could you provide me a pointer to the relevant file?

http://gitorious.org/bewelcome/rox/trees/master

And I do not understand how should that work? Currently if there is wrong information in the FAQ it should be rewritten in the English version and than updated in the relevant translation. That's how I understand the workflow.

comment:5 Changed 6 years ago by planetcruiser

currently we don't change the faqs much, so i would also simply leave this for welen

comment:6 Changed 6 years ago by jeanyves

@Crumking : this should be build/about/about.model.php

line 67

try to replace

        $faqs = $this->bulkLookup(
            "
SELECT *
FROM faq
            ",
            array('IdCategory', false)
        );

with

        $faqs = $this->bulkLookup(
            "
SELECT *
FROM faq where faq.Active='Active' 
            ",
            array('IdCategory', false)
        );

@PlanetCruiser?, the current point is that several faq are old fashioned and should be disable (like the one about Signup delay, or http://www.bewelcome.org/about/faq#question7 or http://www.bewelcome.org/about/faq/5#question14 which is the old way to give someone right to translate your profile, i don't think this can work )

comment:7 Changed 6 years ago by crumbking

Hi JY,

checked your code locally but how do I change the FAQ status now?

comment:8 Changed 6 years ago by sitatara

@crumbking: On http://www.bewelcome.org/bw/faq.php the FAQs can be edited, and that includes setting their status to "not active".

Btw, @planetcruiser I am currently rewriting the FAQs, so this is a relevant issue right now.

From my point of view it's really problematic that this doesn't work because it means that old FAQs which have been deleted are still shown on the website, or rather just their word code. I suggest to implement a delete function for FAQs in welen but fix the current problem in Rox, so that we can at least hide FAQs which are outdated or where the text has been deleted.

For an example see: http://www.bewelcome.org/about/faq/6#question0 (there are several others like this on the current FAQ pages).

comment:9 Changed 6 years ago by sitatara

  • Cc sitatara added

comment:10 Changed 6 years ago by planetcruiser

  • Resolution wontfix deleted
  • Status changed from closed to reopened

ok, cool! reopen i'd say :)

comment:11 Changed 6 years ago by shevek

  • Owner changed from jeanyves to shevek
  • Status changed from reopened to assigned

comment:12 Changed 6 years ago by planetcruiser

hehe, looks like we have quite the well attuned team there in heidelberg. very efficient! :)

comment:13 Changed 6 years ago by shevek

  • Milestone changed from unassigned to 1.4

comment:14 Changed 6 years ago by shevek

  • Cc mahouni added

comment:15 Changed 6 years ago by jsfan

Deployed on alpha.

comment:16 Changed 6 years ago by shevek

  • Status changed from assigned to testing

comment:17 Changed 6 years ago by shevek

Removed. Wrong ticket.

Last edited 6 years ago by shevek (previous) (diff)

comment:18 Changed 6 years ago by sitatara

  • Resolution set to fixed
  • Status changed from testing to closed

Tested: I set a few FAQs on "not active" and they aren't displayed on alpha any more.

comment:19 Changed 6 years ago by planetcruiser

tested ok (locally), a faq entry set to "Not active" on /bw/faq.php will not show up on /faq any more.

/bw/faq.php should redirect to /faq for non-admins btw. new ticket?

Note: See TracTickets for help on using tickets.