Opened 8 years ago

Closed 4 years ago

#1332 closed bug (fixed)

Negative comments are editable

Reported by: sitarane Owned by: sitatara
Priority: major Milestone: 2.0
Component: BW Profile Keywords: negative comment, edit, negative
Cc:

Description

Positive and Neutral comments are editable which is fine. Negative too which is not.

Make negative comments uneditable.

Change History (13)

comment:1 Changed 5 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:2 Changed 5 years ago by guaka

  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from new to closed

huh, why should negs not be editable? has there been a discussion about this on the forum?

anyway, this would probably be for welen

comment:3 Changed 5 years ago by planetcruiser

not sure if there was a discussion. my position: everything should be editable, as long as notifications are sent once something was edited. if we actually have the sort of bullying that some coders think we can prevent with not allowing editing, we can look into it again.

comment:4 Changed 5 years ago by sitatara

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Type changed from improve feature to bug

That is actually a policy of the Safety Team to avoid the possibility of putting people under pressure to change their negative comments. See: http://www.bewelcome.org/about/faq/5#question9. Therefore, I reopen this ticket and would like to ask to fix this bug with priority.

Last edited 5 years ago by sitatara (previous) (diff)

comment:5 Changed 5 years ago by sitatara

  • Milestone changed from unassigned to 2.0
  • Owner changed from fake51 to sitatara
  • Status changed from reopened to assigned

Negative comments no longer editable: https://gitorious.org/bewelcome/rox/commit/6ac16ed2cd86ee0fbfed25c0ce976d807bc28160

Please test locally.

comment:6 Changed 5 years ago by sitatara

  • Status changed from assigned to to_alpha

comment:7 Changed 5 years ago by sitatara

After filling out the new word codes on alpha I realized that the page looks rather ugly... Therefore, I adapted the layout: https://gitorious.org/bewelcome/rox/commit/7bffeb23687d7d55213b184d706b6152434b9824

comment:8 Changed 5 years ago by shevek

Deployed to alpha.

comment:9 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:10 Changed 4 years ago by sitatara

If you'd like to test that you can leave test comments on the profile sitataratest. I will delete all test comments on that profile after this test phase.

Last edited 4 years ago by sitatara (previous) (diff)

comment:11 Changed 4 years ago by beatnickgr

We have a wiki article to improve the comment system, that includes the option of removing the flags (good/neutral/bad). http://www.bewelcome.org/wiki/s3679-New_reference_system

This ticket is not relevant until we decide if we want flags in the first place.

comment:12 Changed 4 years ago by sitatara

The ticket is highly relevant since this is a bug. It is even more relevant as long as no other decision is made regarding changes to the comment system in general (I'd like to bring that up again once the new decision making process works but not before). Removing the quality labels is an option that was very controversial, so it is by no means clear that this will be the path we are taking in the future.

Anyway, the Safety Team needs a way to easily become aware of problematic experiences and comments. In the current comment system the label negative is the marker for this. Before it is replaced by another marker, bugs concerning the current system have to be taken care of.

comment:13 Changed 4 years ago by Tsjoek

  • Resolution set to fixed
  • Status changed from testing to closed

fixed.
I can still edit a neutral/positive comment, but get a friendly message that I can't when trying to do so with a negative one.

Note: See TracTickets for help on using tickets.