Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#1340 closed improve feature (invalid)

Extending access to sqlvolunteers for members of a given group

Reported by: jeanyves Owned by:
Priority: major Milestone: Legacy Resolved
Component: BW Admin Keywords: adminquery
Cc:

Description

I quicly added a solution to allow all the members in a given group to access the queries in "queries for volunteers"

for example all membersof the group "bevolunteer" in test can access "http://test.bewelcome.org/bw/admin/adminquery.php?action=execute&IdQuery=20" other can (exept admin)

The reason for this is to try to give visibility for the query allowing to see recent members who have not yet receive message from any wone to allow a welcomers group

Change History (6)

comment:1 Changed 9 years ago by fake51

sqlforvolunteers is not a good solution to our problems - queries should not be stored in the database as it hides business logic and furthermore maintainability is very poor. Not to mention that it's impossible to sync changes between live and test without doing full data dumps, which is not exactly a smart solution.

In short: we need to move away from the sqlforvolunteers and sqlforgroupsmembers solution. These are very short term solutions that will only hurt us in the long run

comment:2 Changed 9 years ago by jeanyves

I have a different opinion.

Queries stored in the database are a very good solution for efficient maintenance and a very reliable way to query the database for volunteer/admin or maintenance purpose.

Of course there is a limit, you cannot build a long term feature on it,they have a lot of limits, they cannot do complex task, they cannot produce beautiful layout. When a real feature is available as a candidate, just disable the query.

comment:3 Changed 9 years ago by fake51

It's possible to do what's needed already, so please do disable this.

A note on maintainability: there is NO maintainability when almost everyone in the dev team are completely oblivious to what is going on the mentioned tables, have no idea which queries are put in there or not, and one person decides as he thinks best which queries are fine to run on production. There is no version control, no code review. This is NOT maintainability and it is NOT reliability.

comment:4 Changed 9 years ago by jeanyves

:-)

comment:5 Changed 9 years ago by jeanyves

  • Keywords adminquery added
  • Resolution set to invalid
  • Status changed from new to closed

After some talk:

I disable the feature as a group feature. It could be a bad solution to provide such easy to setup tool as tool for groups and it could delay the making of the real needed features.

sqlforvolunteers stays as an option mainly used for recurrent request to Db admin, but sqlforgroupmembers

comment:6 Changed 6 years ago by TimLoal

  • Component changed from unknown to BW Admin
  • Milestone changed from unassigned to Legacy Resolved
Note: See TracTickets for help on using tickets.