Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#1343 closed bug (fixed)

Seach members - logged in - no results for some towns

Reported by: crumbking Owned by: fake51
Priority: major Milestone: Legacy Resolved
Component: BW Search Keywords:
Cc:

Description

Try to search:

  • Magdeburg
  • Elster, Germany
  • Halle or Halle (Saale) or Halle/Saale?

no results even if you find in these places members via browse countries.

Also the map search does not work while you are over these places via map.

Change History (22)

comment:1 Changed 9 years ago by fake51

  • Owner set to fake51

Magdeburg and Halle should now be searchable. I cannot find Elster or Saale in the database, which also means they're not searchable. Are they browsable? Seems strange to me ..

comment:2 Changed 9 years ago by fake51

  • follow_up changed from none to release

comment:3 Changed 9 years ago by crumbking

Halle is called Halle/Saale? as there are 2 towns called Halle in Germany. Probably wrong on geonames then...

http://www.bewelcome.org/places/DE/Saxony-Anhalthttp://www.bewelcome.org/places/DE/Saxony-Anhalt

There is one member in Elster.

I just checked Saxony-Anhalt. I hope we won't have some simillar cases in the rest of the world.

comment:5 Changed 9 years ago by fake51

I was wrong, we do have Elster in the database ... somehow Google doesn't send coordinates through for it. I'll see if I can improve the search to fix these things. If you could check geonames for Halle that would be great.

comment:6 Changed 9 years ago by crumbking

I registered on geonames. but somehow I have no edit rights. I send a mail to the guys...

Another strange behavior.

I wanna search for hosts around Leipzig. Therefore I type Leipzig and click SEARCH. Than I zoom out the map to see Halle(Saale) which is 40 km away. I click on "search using map boundaries"

Result: It searchs again and results are just the members of Leipzig (24). This is wrong as it should show members of Leipzig and Halle (Saale) because both are visible on the map.

(Assuming that the search somehow "remember" my first seach "Leipzig")
 I deleted the name "Leipzig from the search field and pressed the button "seach using map boundaries" again.

Same result: members of Leipzig (24) which is wrong.

comment:7 Changed 9 years ago by fake51

You don't get editing rights when registering on geonames, unfortunately - you have to 'earn' that, typically by making a suggestion to fix something and telling them you could do it. Strange policy ...

You're right about the Halle/Saale? problem and map search ... if you use the map to look straight for the place, you can find the members by using map search, but if you search for a city, then using map search afterwards, it remembers the first search and uses that.

I'll refactor the search, as currently it has too many bugs, still.

comment:8 Changed 9 years ago by fake51

I've updated the search on all installs now, please test it on live - should be able to find elster, etc (perhaps not anything in Saale, as I'm not sure we have that in the DB).

Also, the search by map should work ok again now.

comment:9 Changed 9 years ago by crumbking

"search by map boundaries" works great now.

Also I was able to find the above towns.

Only problem left: regions and countries are not working now.

I tried Germany, France, Spain, Saxony-Anhalt, Bavaria - never ending loading sign.

I got userlevel 2 rights on geonames and added Halle (Saale) as "Alternate Name"

Do we use these altenate names in our database? Or better do we use these alternate names in the member search?

comment:10 Changed 9 years ago by fake51

We use alternate names both in the database and in the search.

I'll see about fixing the country/region search (I doubt that regions ever worked, the search was made to function on cities - search would have defaulted to country).

Personal note: use accuracy-level to check for region level (=2), find region from name if possible, then use getchildren to find all cities and go from there.

comment:11 Changed 9 years ago by fake51

Searching on country level should work again now - region level doesn't work for now though, I think. Not really tested, but it was never implemented.

comment:12 Changed 9 years ago by crumbking

Okay while logged in I could find anything left for basic search.

While not logged in: The comment search does not work. No search at all or a loading sign. Tested with France, Berlin, Paris.

Region level is not that important yet, so no worries.

(maybe I should add that I tested just the "basic search" - means I did not tested the advanced search yet)

Maybe if you wanna try something funny: Search Berlin  (185 members). Than click advance search and type word in profile: student. Result after click on "Search Button"  66 members. BUT if you don't click on the button and hit the "enter" key on your keyboard it ignores the location field and search just for "student" I guess.

Another one: check the list while searching word in profile: student. You get the same members 2, 3 or 4 times in the result list.

But the last 2 bugs are special cases. I would say lets get the comment stuff working and we could close the ticket.

About the advance search we can open a new ticket as I have a couple of ideas for improvments and I probably find another ton of small bugs ;)

comment:13 Changed 9 years ago by crumbking

Okay while logged in I could  not find anything left for basic search.

comment:14 Changed 9 years ago by fake51

Comment search should work now while not logged in. I'll have a look at the 'advanced search' thing you picked up on, I have an idea of what it is.

comment:15 Changed 9 years ago by fake51

The first of the two advanced search bugs you mention should be fixed now

comment:16 Changed 9 years ago by crumbking

Comments search while not logged in works now.

Also the enter problem in advanced search seems to be fixed.

comment:17 Changed 9 years ago by crumbking

only bug left:

"Another one: check the list while searching word in profile: student. You get the same members 2, 3 or 4 times in the result list."

comment:18 Changed 9 years ago by fake51

Oughts to be fixed now with r9703

comment:19 Changed 9 years ago by crumbking

seems to be okay.

I close the ticket now. (new issues into new tickets)

Thanks peter, great work!

comment:20 Changed 9 years ago by crumbking

  • Resolution set to fixed
  • Status changed from new to closed

comment:21 Changed 9 years ago by crumbking

  • follow_up changed from release to none

comment:22 Changed 6 years ago by TimLoal

  • Milestone changed from Future to Legacy Resolved
Note: See TracTickets for help on using tickets.