Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#1408 closed improve feature (fixed)

Comment editing should be changed

Reported by: globetrotter_tt Owned by: planetcruiser
Priority: major Milestone: 0.9
Component: BW Profile Keywords: comment, editing
Cc:

Description

from feedback:

Could the "Edit Comment" please feature be changed so that it allows members to actually edit (or delete) text that they've previously written (e.g. to correct mistakes)? As it stands, the entry box seems to function to only *add* text to previously written comments. If the feature can't be changed, then it should at least be made clearer that, when members press the "edit comment" button, the old comment will stay as it was, and the empty box is only for new text.

Change History (9)

comment:1 Changed 6 years ago by planetcruiser

  • Milestone changed from unassigned to 0.9
  • Owner set to planetcruiser
  • Status changed from new to accepted

this is getting on my nerves since a while, and now with moral support of http://www.bewelcome.org/forums/s2619-Edit_comments i think it's time to change this. ;) i already wrote the code and will commit after a bit of more testing

comment:2 follow-up: Changed 6 years ago by planetcruiser

fixed via:

bonus fixes and improvements:

this can be deployed on alpha and tested. note that comment "where did you meet" text and "comment body" text are now written to the database in different formatting (stripped <font> and <hr> tags), so be careful when testing

the translation for CommentsCommenterDescription (remove "BEWARE" part) and the faq (http://www.bewelcome.org/about/faq/5#question6) need to be changed accordingly. volunteers?

comment:3 Changed 6 years ago by planetcruiser

deployed to alpha for testing.

globi: now you can fix your double comment on http://alpha.bewelcome.org/members/planetcruiser/comments :)

comment:4 Changed 6 years ago by mahouni

Great!!! I tested it locally and on alpha (have to write some more comments anyway which I haven't took the time so far..) .

It seems to work without problems. The only thing that I missed was an update of the "What's happening" on the member startpage/dashboard. But maybe that's something for a later task in a separate ticket.

comment:5 Changed 6 years ago by globetrotter_tt

@mahouni: I can see 2 notifications about your comment (wrote/update) on the "What's happening" section of my startpage on alpha and production.

I have also tested it and could not find any issues so far.

Last edited 6 years ago by globetrotter_tt (previous) (diff)

comment:6 Changed 6 years ago by mahouni

perfect! It seems that the message on "whats happening" doesn't work locally because of the missing mail system. There was an exception raised when the swift mailer failed.

comment:7 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from accepted to closed

so i guess we can fix this.

comment:8 in reply to: ↑ 2 ; follow-up: Changed 6 years ago by planetcruiser

Replying to planetcruiser:

the translation for CommentsCommenterDescription (remove "BEWARE" part) and the faq (http://www.bewelcome.org/about/faq/5#question6) need to be changed accordingly. volunteers?

how do we make sure this happens? this should be done shortly after this is deployed to www.

comment:9 in reply to: ↑ 8 Changed 6 years ago by globetrotter_tt

Replying to planetcruiser:

Replying to planetcruiser:

the translation for CommentsCommenterDescription (remove "BEWARE" part) and the faq (http://www.bewelcome.org/about/faq/5#question6) need to be changed accordingly. volunteers?

how do we make sure this happens? this should be done shortly after this is deployed to www.

You can always post translation requests to the translation group of BeWelcome: http://www.bewelcome.org/groups/60/forum/s2330-Translation_Anouncements

I will take care of it when 0.9 is released

Note: See TracTickets for help on using tickets.