Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#1425 closed bug (fixed)

Comment Page, Placeholder in Field 'How did you meet' not resolved

Reported by: neo82 Owned by: crumbking
Priority: minor Milestone: 1.1
Component: BW Profile Keywords:
Cc:

Description

When adding a comment e.g. on http://www.bewelcome.org/members/neo82/comments/add the Placeholder in Text 'How did you meet %s' is replaced by an empty string and not by username. In english this might be ok but e.g. in german translation the username is in the sentence so it looks there is a gramatical error 'Wie hast du kennen gelernt?' instead it's the placeholder which is not resolved. This might be an issue with other languages too.

Direct link to the sentence: http://www.bewelcome.org/bw/admin/adminwords.php?idword=17579

Change History (11)

comment:1 Changed 6 years ago by TimLoal

  • Resolution set to fixed
  • Status changed from new to closed

Resolving due to age and lack of interest, in recent years.

Please create a new ticket and link to this historical ticket, if you discover bW.org has continuing issues with this issue.

bW Housekeeping

LnP

comment:2 Changed 6 years ago by TimLoal

  • Milestone changed from unassigned to Legacy Resolved

comment:3 Changed 6 years ago by crumbking

  • Milestone changed from Legacy Resolved to 1.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

I have fixed this locally. Could I add it to the milestone. It's just a small fix :-)

comment:4 Changed 6 years ago by crumbking

  • Owner set to crumbking
  • Status changed from reopened to accepted

comment:5 Changed 6 years ago by jsfan

Sounds like a one liner...

Can you maybe post that patch here before pushing it?

comment:6 Changed 6 years ago by crumbking

Now the username can be used in translations.

-------------- build/members/templates/addcomment.column_col3.php --------------
index c45d08c..6fd525f 100644
@@ -100,7 +100,7 @@
     <input name="IdMember" value="<?=$member->id?>" type="hidden" />
         <table valign="center" >
           <tr>
-            <td colspan=2><h3><?=$words->get("CommentQuality",$member->username)?></h3><br /><?=$words->get("RuleForNeverMetComment")?></td>
+            <td colspan=2><h3><?=$words->get("CommentQuality" , $Username)?></h3><br /><?=$words->get("RuleForNeverMetComment")?></td>
           </tr>
           <tr>
             <td>
@@ -120,12 +120,12 @@
                 </selected>
             </td>
             <td>
-                <p class="grey"><?=$words->get("CommentQualityDescription", $member->username, $member->username, $member->username)?></p>
+                <p class="grey"><?=$words->get("CommentQualityDescription", $Username, $Username, $Username)?></p>
             </td>
           </tr>
         <tr>
         <td colspan=2>
-            <h3><?=$words->get("CommentLength")?></h3>
+            <h3><?=$words->get("CommentLength", $Username)?></h3>
         </td>
         </tr>
         <tr>
@@ -144,22 +144,22 @@
         </table>
         </td>
         <td>
-        <p class="grey"><?php echo $words->get("CommentLengthDescription", $member->username, $member->username, $member->username) ?></p>
+        <p class="grey"><?php echo $words->get("CommentLengthDescription", $Username, $Username, $Username) ?></p>
         </td>
     </tr>
     <tr>
-        <td colspan="2"><h3><label for="TextWhere"><?php echo $words->get("CommentsWhere") ?></label></h3></td>
+        <td colspan="2"><h3><label for="TextWhere"><?php echo $words->get("CommentsWhere", $Username) ?></label></h3></td>
     </tr>
     <tr>
         <td><textarea name="TextWhere" id="TextWhere" cols="40" rows="3"><?php echo $textWhereWashed; ?></textarea></td>
-        <td><p class="grey"><?php echo $words->get("CommentsWhereDescription", $member->username) ?></p></td>
+        <td><p class="grey"><?php echo $words->get("CommentsWhereDescription", $Username) ?></p></td>
     </tr>
     <tr>
         <td colspan="2"><h3><label for="Commenter"><?php echo $words->get("CommentsCommenter") ?></label></h3></td>
     </tr>
     <tr>
         <td><textarea name="TextFree" id="TextFree" cols="40" rows="8"><?php echo $textFreeWashed; ?></textarea></td>
-        <td style="vertical-align=top"><p class="grey"><?php echo $words->get("CommentsCommenterDescription", $member->username) ?></p></td>
+        <td style="vertical-align=top"><p class="grey"><?php echo $words->get("CommentsCommenterDescription", $Username) ?></p></td>
     </tr>

comment:7 Changed 6 years ago by jsfan

Looks good. Probably doesn't need any extensive testing. Just push it. :)

Last edited 6 years ago by jsfan (previous) (diff)

comment:8 Changed 6 years ago by jsfan

I presume the template file you dropped along with this is definitely not in use any more...

comment:9 Changed 6 years ago by crumbking

comment:10 Changed 6 years ago by jsfan

  • Resolution set to fixed
  • Status changed from accepted to closed

Next time please put a file removal like that on a separate ticket and don't add it to an unrelated commit.

Tested fix for problem described here and looks fine to me. Closing.

comment:11 Changed 6 years ago by crumbking

Well I did not added the removal to this ticket. Anyway you are right. Better we have seperate tickets.

Note: See TracTickets for help on using tickets.