Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1434 closed bug (fixed)

age members shown - privacy issue

Reported by: crumbking Owned by: jeanyves
Priority: major Milestone: 0.5.4 - bugfixing
Component: BW Profile Keywords: age, privacy
Cc: planetcruiser

Description (last modified by crumbking)

When you go to “Find members” and search in whatsoever location, when the list of members is displayed, there are several with hidden years. The same with profile’s visitors.

An example, my friend *:

Visited: 3 days ago Hidden years old - Member Barcelona

When you click on that profile to have a look the age is shown: Barcelona (Catalonia) Spain Age: 31 Member since: 1 week ago Last login: less than 1 week ago

It happens with all the members with hidden age.

I don’t know if it’s how it should be, but seems strange to me.

Change History (12)

comment:1 Changed 7 years ago by jeanyves

Since in BW we pretend to do the best to protect people privacy this is an urgent bug to deal with.

The problem is a translation problem. This is not really a privacy issue (hidden age are kept hidden). I am going to look and see how I can fix it in Alpha

comment:2 Changed 7 years ago by jeanyves

  • Component changed from BW Profile to BW Search
  • follow_up changed from none to test on alpha
  • Owner set to jeanyves
  • Priority changed from blocker to major
  • Status changed from new to assigned
  • version set to alpha

I did a fix on Alpha

It display Age : Hidden (the word AgeHidden) if the member has hidden his age. I also checked that using the age range advanced search it is still not possible to find people who are hidding their age

Please check if it is solved

If so, the fix in the template build/searchmember/templates/ajax.php can be (manually I am not sure version are exactly the same) moved on production

comment:3 Changed 7 years ago by globetrotter_tt

  • Milestone changed from unassigned to 0.5.3 - bugfixing

comment:4 Changed 7 years ago by jeanyves

  • Keywords age added
  • Resolution set to fixed
  • Status changed from assigned to closed

The fix is easy to do in members.entity.php the function get_age (line 400 aproximatively)

is to be changed

Before :

    public function get_age() {
if ($this->HidBirthDate!=='No') {
 $age='hidden' ;
} else {
        $age = $this->get_crypted("age", "");
}
        return $age;
    }

After

    public function get_age() {
        
        if ($this->HideBirthDate=='Yes') {
            return('hidden' );
        }
        $layoutbits = new MOD_layoutbits;    
        return ($layoutbits->fage_value($this->BirthDate));
    }

comment:5 Changed 7 years ago by globetrotter_tt

  • Cc planetcruiser added
  • Component changed from BW Search to BW Profile
  • follow_up changed from test on alpha to move to alpha
  • Keywords privacy added
  • Milestone changed from 0.5.3 - bugfixing to 0.5.4 - bugfixing
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • version changed from alpha to production

This is not fixed on production yet, nor your patch was in the git repository. I commited your patch now: http://gitorious.org/bewelcome/rox/commit/0cadbdc68d2e11e99fcb74c9ace20215729c9cf2 but it still needs to be moved by meinhard

comment:6 Changed 7 years ago by globetrotter_tt

  • follow_up changed from move to alpha to test on alpha

comment:7 Changed 7 years ago by crumbking

I guess this still does not work. Now you can see the (hidden) ages on the profile page and the search member page

http://alpha.bewelcome.org/members/spectre compare to: http://www.bewelcome.org/members/spectre

comment:8 Changed 7 years ago by globetrotter_tt

For me this looks good on alpha. What exactly does not work?

BTW: the checkbox "hidden" behind the birthdate is misleading, as people will assume that it will hide their birthdate, but not their age.

comment:9 Changed 7 years ago by crumbking

The behavior on alpha seems to look ok.

But why is there a diffrence between alpha an live?

http://www.bewelcome.org/members/spectre (hidden)

Means if we move the code to live spectre's age will be shown on the profile page. Is that what he choosed or just what we coded?

comment:10 Changed 7 years ago by globetrotter_tt

Spectre has set his age to NOT hidden. On bewelcome.org all you can see that all profiles have the age hidden. That's the bug. On alpha.bewelcome.org it's fixed now.

comment:11 Changed 7 years ago by globetrotter_tt

  • follow_up changed from test on alpha to move to alpha
  • Resolution set to fixed
  • Status changed from reopened to closed

comment:12 Changed 7 years ago by crumbking

  • Description modified (diff)

I modified the description of the ticket to hide the username of a member as requested by mail. As he found this ticket by googling his username.

Note: See TracTickets for help on using tickets.