Opened 7 years ago

Closed 7 years ago

#1512 closed improve feature (fixed)

Show bigger picture in the profile

Reported by: globetrotter_tt Owned by: globetrotter_tt
Priority: major Milestone: 0.5.4 - bugfixing
Component: BW Profile Keywords: picture, avatar
Cc: lupochen

Description (last modified by planetcruiser)

Many people asked for a bigger profile picture:

http://www.bewelcome.org/forums/s1550-Bigger_pictures

So, let's do it.

Related ticket:

Change History (16)

comment:1 Changed 7 years ago by globetrotter_tt

  • Owner set to globetrotter_tt
  • Status changed from new to accepted

comment:2 follow-up: Changed 7 years ago by globetrotter_tt

I have done some changes:

  • changed the size of the profile picture from 100x100px to 150x150px
  • added a "fancyzooom effect" when clicking on the picture you will see the picture in 600x600px

see https://gitorious.org/bewelcome/rox/commit/e42f3ad4f55ca716fa0be1ab64fd6f6cef8e5438

Further ideas:

  • add a crop tool, that people can choose the image clipping they want.

Things to consider.

  • old profile picures are still saved in 100x100px. So all users need to upload a new picture again.

comment:3 Changed 7 years ago by globetrotter_tt

  • Milestone changed from unassigned to 0.5.4 - bugfixing

comment:4 in reply to: ↑ 2 Changed 7 years ago by planetcruiser

Replying to globetrotter_tt:

old profile picures are still saved in 100x100px. So all users need to upload a new picture again.

wrong! :-P the original pictures are saved as deer:/home/bwrox/www.bewelcome.org/data/user/avatars/*_original - so we just need to find a way to render them in the desired size, a) on the fly (image cache like) or b) all at once via script

comment:5 Changed 7 years ago by coroa

ups, of course i would not have needed to bother the whole mailing list, but instead dumped my message here. Well, actually it's a bit of fun to ping interested people twice:

In a topic branch of mine there is the commit https://gitorious.org/~coroa/bewelcome/coroas-rox/commit/c1de55b043e073d7504b811acb9f76a7cdf4dc4a which allows to add new avatar sizes and generates missing thumbnails on demand.

the size 500 in showAvatar and makeAvatar should be changed to whatever is needed. /members/avatar/henri/?500 then returns the new size.

perhaps we should also add a new layoutbits function to properly access the avatar? as in PIC_500 or largeUserPic_user{Id,name}.

comment:6 Changed 7 years ago by globetrotter_tt

  • follow_up changed from none to test on alpha

comment:7 follow-up: Changed 7 years ago by crumbking

Seems to work on alpha. I checked also with javascript off. Seems to jump back to the startpage if you click the profile picture. Maybe we could avoid this?

Problem: All profile pics are looking ugly, as the are saved as 100x100. Maybe we switch in a first step to a new upload to safe bigger pics and after a while we change the size of the profile layout if we have lots of larger pics in the database?

comment:8 in reply to: ↑ 7 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

i just committed and deployed a fix on alpha.

Replying to crumbking:

Seems to work on alpha. I checked also with javascript off. Seems to jump back to the startpage if you click the profile picture. Maybe we could avoid this?

solved. link will now lead directly to image file.

Problem: All profile pics are looking ugly, as the are saved as 100x100. Maybe we switch in a first step to a new upload to safe bigger pics and after a while we change the size of the profile layout if we have lots of larger pics in the database?

solved. all profile pics will be rendered to the correct size from the originally uploaded image.

closing

comment:9 follow-up: Changed 7 years ago by globetrotter_tt

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:11 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from reopened to closed

now :)

comment:12 follow-up: Changed 7 years ago by micha

  • Resolution fixed deleted
  • Status changed from closed to reopened

Unfortunately the new implementation is in two ways problematic:

1) The link on the picture goes to http://www.bewelcome.org/#medium_box. A user with JS deactivated will end up on the homepage - NOT GOOD.

2) The modal window only works on http://www.bewelcome.org/members/USERNAME, but not on http://www.bewelcome.org/people/USERNAME (which is also a valid link).

Proposed solution for 1): Change the link to the current page-url + hashtag

Proposed solution for 2): Add the needed JS-files also on /people/USERNAME. In main.js add a line at the right spot:

	|| req.indexOf('people') != -1

comment:13 in reply to: ↑ 12 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to micha:

Unfortunately the new implementation is in two ways problematic:

1) The link on the picture goes to http://www.bewelcome.org/#medium_box. A user with JS deactivated will end up on the homepage - NOT GOOD.

did you test it with js off? it works fine with the /members/ url. :-P note this commit: https://gitorious.org/bewelcome/rox/commit/2b6341a592d46fc7c314263fc2c5bae024da9fce

as far as i understand fancyzoom (not my choice) is a little bit dumb and needs the link to be "#<something>_box".

2) The modal window only works on http://www.bewelcome.org/members/USERNAME, but not on http://www.bewelcome.org/people/USERNAME (which is also a valid link).

oops. fixed via https://gitorious.org/bewelcome/rox/commit/4634187f23c94c8c2cf6389c7969de89c3334717

also see #1560

Proposed solution for 1): Change the link to the current page-url + hashtag

this would break fancyzoom, see above. but actually for non-js users the image link leads to the image file with 500px width

Proposed solution for 2): Add the needed JS-files also on /people/USERNAME. In main.js add a line at the right spot:

	|| req.indexOf('people') != -1

done. closing..

comment:14 Changed 7 years ago by planetcruiser

also deployed as quick fix to alpha and www

comment:15 Changed 7 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

hi together,

while the bigger profile pic works we should avoid that the zoom will be larger than the pic uploaded.

See this user

http://www.bewelcome.org/members/Das_Klo

Click the profile pic and you see zoom looks very bad.

comment:16 Changed 7 years ago by planetcruiser

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reopened to closed

yes, good point. but i don't see this as a reason to reopen this ticket, because the main feature of this ticket has been implemented. i opened another ticket for this issue: #1563

Note: See TracTickets for help on using tickets.