Opened 7 years ago

Closed 7 years ago

#1539 closed bug (fixed)

eMail notification on comment receival not sent

Reported by: coroa Owned by: planetcruiser
Priority: major Milestone: 0.5.5 - bugfixing
Component: BW Profile Keywords:
Cc: bikepunk

Description

At least two members didn't receive any eMail notification when someone commented on them.

refer also to http://www.bewelcome.org/forums/s1734-e_mail_notification_when_someone_leave_a_comment_on_my_profile

Attachments (1)

members.model.php (61.6 KB) - added by micha 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by micha

  • Owner set to micha
  • Status changed from new to accepted

Changed 7 years ago by micha

comment:2 Changed 7 years ago by micha

I just created a fix (see attachment). Could someone test and confirm?

comment:3 Changed 7 years ago by globetrotter_tt

  • Milestone changed from 0.5.3 - bugfixing to 0.5.4 - bugfixing

comment:4 Changed 7 years ago by globetrotter_tt

you patch adds quite a lot more than only adding the comment notification. Is this the latest version of members.model.php we had on test.bw before?

comment:5 Changed 7 years ago by globetrotter_tt

  • Milestone changed from 0.5.4 - bugfixing to 0.5.5 - bugfixing

comment:6 Changed 7 years ago by planetcruiser

micha, any news here? shall we take over?

comment:7 Changed 7 years ago by planetcruiser

  • Owner changed from micha to planetcruiser

will look at micha's changes and commit them

comment:9 Changed 7 years ago by planetcruiser

things that are not so clean with this solution:

  • messages appear in the commenter's Sent Mail folder - they shouldn't, because they are system messages - i'm not sure how this is handled in other cases
  • the notification message is sent in the language of the commenter, not the comment receiver - that's probably worth a bug ticket ;)

comment:10 Changed 7 years ago by planetcruiser

  • follow_up changed from none to test on alpha

comment:11 Changed 7 years ago by planetcruiser

  • Cc bikepunk added

tested on alpha by bikepunk. he left me a comment and i received this email:

Subject: You have received a mail from bikepunk

Hello planetcruiser,

You have received the following message from member bikepunk:

Hi planetcruiser,

You just got a comment from bikepunk. If you would like to read the new comment,
click the following link:
http://alpha.bewelcome.org/members/planetcruiser/comments

Have a great time!
Your BeWelcome team

What do you want to do next?

Reply to the message
Visit the profile of bikepunk
Check your BeWelcome inBox

Have a nice day!
Beste Grüße von den freiwilligen Helfern!

this looks a bit buggy, because the wrapping message is a system message, and the included commenting member's message is written as a system message as well.

i will either:

  1. change the text of the notification to sound like a message from the member ("Hi, I just left you a comment") or
  2. see if it's easy to generate dedicated system message for "new comment" instead of hijacking the "new mail" notification.
Last edited 7 years ago by planetcruiser (previous) (diff)

comment:12 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

all issues are solved now:

  • messages are sent as system email and not member-to-member
  • emails are sent in the language set by the receiver in their preferences
Note: See TracTickets for help on using tickets.