Opened 7 years ago

Closed 7 years ago

#1577 closed improve feature (fixed)

Add 'counter-comments' to the comments page

Reported by: micha Owned by: planetcruiser
Priority: minor Milestone: 0.5.6 - bugfixing
Component: BW Profile Keywords: comments, counter
Cc: globetrotter_tt, meinhard

Description

Integrate a member's written comments into the CommentsPage? that lists all the comments he received. This should look similar to the way, CS shows their comments.

I add an image to show what I'm aiming for.

Attachments (1)

screenshot-42.png (93.2 KB) - added by micha 7 years ago.
Comments in conversation view

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by micha

Comments in conversation view

comment:1 follow-up: Changed 7 years ago by micha

  • Status changed from new to accepted

commited my changes in 636cd63. Hopefully will be released with the new milestone.

comment:2 in reply to: ↑ 1 Changed 7 years ago by planetcruiser

Replying to micha:

commited my changes in 636cd63. Hopefully will be released with the new milestone.

let's put it this way, the milestone won't be released before this ticket is closed. :)

i deployed 636cd63 to alpha, but somehow it's lacking css. my comments to others have no special border and appear in the same way as comments for me. forgot to commit a file?

comment:3 Changed 7 years ago by micha

A browser reload does the job... ;)

comment:4 follow-ups: Changed 7 years ago by planetcruiser

looks really cool. :)

but i think the grey comments need a "from <member> to <other_member>" at the top to make clear that it's a "counter comment"

comment:5 Changed 7 years ago by globetrotter_tt

  • follow_up changed from none to test on alpha

comment:6 in reply to: ↑ 4 Changed 7 years ago by planetcruiser

  • follow_up changed from test on alpha to review code

Replying to planetcruiser:

but i think the grey comments need a "from <member> to <other_member>" at the top to make clear that it's a "counter comment"

micha, what about this? do you think you can add this as well?

i still need to do code review.. will do that tomorrow hopefully.

comment:7 in reply to: ↑ 4 ; follow-up: Changed 7 years ago by micha

Replying to planetcruiser:

but i think the grey comments need a "from <member> to <other_member>" at the top to make clear that it's a "counter comment"

Would you add this line on top and leave the rest of the comment as is? Or would you just replace the part "from <member>" with "from <member> to <other_member>" ? The latter looks better here and keeps consistency of the UI.

After an answer I'll commit the appropriate changes. I also found minor bugs that I'll fix right away.

comment:8 in reply to: ↑ 7 Changed 7 years ago by planetcruiser

Replying to micha:

Would you add this line on top and leave the rest of the comment as is? Or would you just replace the part "from <member>" with "from <member> to <other_member>" ? The latter looks better here and keeps consistency of the UI.

sorry, i wasn't very clear, i also meant the latter one.

After an answer I'll commit the appropriate changes. I also found minor bugs that I'll fix right away.

cool! :)

comment:9 Changed 7 years ago by micha

ok, done. see latest commit 85395d5 which also deals with this ticket: http://trac.bewelcome.org/ticket/1579

comment:10 Changed 7 years ago by crumbking

an error show up before the "add comment" button

( ! ) Notice: Undefined offset: 0 in /home/www/alpha.bewelcome.org-85395d5/build/members/templates/comments.column_col3.php on line 4
Call Stack
#	Time	Memory	Function	Location
1	0.0002	71152	{main}( )	../index.php:0
2	0.0002	71272	main( )	../index.php:78
3	0.0021	325416	RoxLauncher->launch( )	../index.php:63
4	0.0191	714584	RoxLauncher->chooseAndRunApplication( )	../roxlauncher.php:22
5	0.0242	1242652	RoxFrontRouter->route( )	../roxlauncher.php:68
6	0.0325	1598836	RoxFrontRouter->route_normal( )	../roxfrontrouter.class.php:34
7	0.0361	1893880	RoxFrontRouter->runControllerMethod( )	../roxfrontrouter.class.php:224
8	0.0990	4396956	RoxFrontRouter->renderPage( )	../roxfrontrouter.class.php:351
9	0.1001	4441540	PageWithHTML->render( )	../roxfrontrouter.class.php:392
10	0.1001	4441540	PageWithHTML->printHTML( )	../html.page.php:18
11	0.1013	4448588	PageWithRoxLayout->body( )	../html.page.php:169
12	0.1014	4453848	require( '/home/www/alpha.bewelcome.org-85395d5/templates/shared/roxpage/body.php' )	../roxlayout.page.php:123
13	0.1357	5109180	MemberPage->columnsArea( )	../body.php:21
14	0.1531	5507996	CommentsPage->column_col3( )	../member.page.php:151
15	0.1531	5507996	VisualComponent->__call( )	../visualcomponent.php:0
16	0.1624	6187296	include( '/home/www/alpha.bewelcome.org-85395d5/build/members/templates/comments.column_col3.php' )	../visualcomponent.php:47

comment:11 Changed 7 years ago by micha

  • follow_up changed from review code to test

Just fixed in c9ff12c. Please deploy and test again.

comment:12 Changed 7 years ago by globetrotter_tt

some minor ranting ;-): The counter comment is located closer to the next comment than to the comment that it belongs to. Maybe we can increase the bottom margin a bit? Or put a light border around both comments?

comment:13 Changed 7 years ago by micha

I'd rather schedule a few css improvements and collect them alltogether in one commit. There's quite a lot layout and CSS stuff that could need an overhaul.

comment:14 follow-up: Changed 7 years ago by planetcruiser

micha:

on http://alpha.bewelcome.org/members/planetcruiser/comments i see:

"from planetcruiser To - 2011-12-18 09:12:06"

two things:

  1. the "To" should be in lower-case to match the "from", right?
  2. the username of the comment recipient is not shown. is it the same for you?

comment:15 Changed 7 years ago by planetcruiser

  • Owner changed from micha to planetcruiser

taking over

comment:16 Changed 7 years ago by planetcruiser

translation "To" -> "to" fixed for all languages. the word is also used in ./build/lastcomments/templates/lastcomments.php - no idea what that is. i hope a lower-case "to" doesn't hurt there ;)

comment:17 Changed 7 years ago by planetcruiser

oh, cool: http://www.bewelcome.org/lastcomments - why is this not linked anywhere? :)

comment:18 in reply to: ↑ 14 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.