Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1579 closed improve feature (fixed)

Make "Report spam" link in comments less important

Reported by: planetcruiser Owned by: planetcruiser
Priority: minor Milestone: 0.5.6 - bugfixing
Component: BW Profile Keywords:
Cc:

Description

suggested by rob on dev list:

I like the changes and I know this isn't strictly where I should be posting this, but the suggestion on the multiple report links made sense to me, I'd suggest using the "button" class used elsewhere on the page for a simple "!" like:

<p class="float_right"><span class="button"><a href="forums/reporttomod/####" title="Report a problem with this comment">!</a></span></p>

Seems to me to neaten the page up somewhat.

Change History (16)

comment:1 Changed 7 years ago by planetcruiser

i am also all for visually reducing the importance of this link. i'd say 99% or more of our messages are not spam, so there is no reason for this link being so dominant. i think a small grey button in the lower right corner of the comment box with a "!" or flag symbol (like youtube) is sufficient.

comment:2 Changed 7 years ago by planetcruiser

comment by micha:

Hey thanks for the suggestions! I'd go for an exclamation mark symbol rather than the button class. Is that ok with you guys?

comment:3 Changed 7 years ago by planetcruiser

i think an ! is pretty difficult to click, right? or are you talking about an image with an ! and some colour around it? generally: less images = faster website. unless we use image sprites. but i don't think we do. so i'd vote for button (or new icon) css class

comment:4 Changed 7 years ago by micha

Indeed I meant a new graphic icon. Found one here: /htdocs/images/icons/error.png . I'll go for this one.

comment:5 Changed 7 years ago by micha

commited in 85395d5

comment:6 Changed 7 years ago by micha

  • follow_up changed from none to test

comment:7 Changed 7 years ago by planetcruiser

deployed to alpha

comment:8 Changed 7 years ago by crumbking

  • follow_up changed from test to none
  • Resolution set to fixed
  • Status changed from new to closed

tested on alpha. looks great! so fixed!

comment:9 Changed 7 years ago by crumbking

  • Milestone changed from unassigned to 0.5.6 - bugfixing

comment:10 Changed 7 years ago by planetcruiser

  • Resolution fixed deleted
  • Status changed from closed to reopened

nice, but i see a few small issues with this implementation:

  1. "Last updated .." should remain left aligned, the new position looks a bit messy
  2. having "Edit" as button and "Report" as icon is confusing or at least it looks odd to me. i suggest either to use buttons for both or icons for both - how about http://alpha.bewelcome.org/images/icons/comment_edit.png for edit comment? :)
  3. http://alpha.bewelcome.org/images/icons/error.png is commonly used for, well error messages on websites and not for flagging so i think it's a bit misleading and i wouldn't click on it. how about http://alpha.bewelcome.org/images/icons/thumb_down.png ? it might encourage us also to later actually make this function flag a comment, and not bring the user to a feedback form

comment:11 Changed 7 years ago by planetcruiser

taking over

comment:12 Changed 7 years ago by planetcruiser

  • Owner changed from micha to planetcruiser
  • Status changed from reopened to accepted

comment:13 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

"fixed" via https://gitorious.org/bewelcome/rox/commit/0ac95484e0db0111cf1933b00c70bbf8c37fe648

removed "report comment" link entirely, because reporting does not work properly (comments are flagged before user sends feedback form, so there is no way of cancelling) and because we don't have a comment spam problem anyway.

imho we can think about a better solution if we actually have massive comment spam.

comment:14 follow-up: Changed 7 years ago by micha

I really don't think that this is the way to go.

The "Report comment"-option wasn't only about Spamming. I had an issue with a comment that I created with a test user on the live site. Shouldn't happen, but to make it go away I had to contact the admins about the comment. I don't see a point in removing functionality out of a feeling, it's not needed.

Anyway, I like the rest of the comment layout now. So go for it and we open a new ticket to discuss a better "report comment"-option for the next milestone..

comment:15 in reply to: ↑ 14 Changed 7 years ago by planetcruiser

Replying to micha:

The "Report comment"-option wasn't only about Spamming. I had an issue with a comment that I created with a test user on the live site. Shouldn't happen, but to make it go away I had to contact the admins about the comment. I don't see a point in removing functionality out of a feeling, it's not needed.

i know it was a bold move. :) but i think no functionality is better than broken functionality (related to the unix philosophy "write programs that do one thing and do it well"). bw has a lot of clutter that reduces the site's usability. i'd say until we find someone that fixes the "report comment" function, we should not display the button/link. anyway, see below..

as for dev tests, is it not sufficient to send an email with the comment page url to the dev list?

Anyway, I like the rest of the comment layout now. So go for it and we open a new ticket to discuss a better "report comment"-option for the next milestone..

ok, roger that. new ticket is #1587

comment:16 Changed 7 years ago by planetcruiser

button reintroduced as part of #1587 - the report link is a flag now, as common on other websites

Note: See TracTickets for help on using tickets.