Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1580 closed bug (fixed)

Family and close friends page shows weird numbers

Reported by: planetcruiser Owned by: planetcruiser
Priority: blocker Milestone: 0.7
Component: BW Profile Keywords:
Cc:

Description (last modified by crumbking)

Issue:

Solution:

  • Show relation text or nothing

Change History (10)

comment:1 Changed 7 years ago by globetrotter_tt

If you go back to the profile and look in the "Family and close friends" box, you can see that there is some text written from Anathema. I believe the same text should also be shown on http://www.bewelcome.org/members/Sasa/relations/

comment:2 Changed 7 years ago by crumbking

  • Description modified (diff)

comment:3 follow-up: Changed 7 years ago by crumbking

I looked into this:

Seems like really buggy. As far as I understand the relation comments are ready for translation. But do we really want this? Because if someone adds a translated relation comment about me I would like to confirm this. This seems not possible yet. Relevant files:

http://gitorious.org/bewelcome/rox/blobs/master/build/members/templates/profile.subcolumn_right.php#line135

http://gitorious.org/bewelcome/rox/blobs/master/build/members/pages/addrelation.page.php#line61

In the add/update form the same digit numbers are shown instead of the comment

http://gitorious.org/bewelcome/rox/blobs/master/build/members/pages/relations.page.php#line32

digit numbers are shown instead of the comment

http://gitorious.org/bewelcome/rox/blobs/master/build/members/templates/editprofile_form.php#line549

Remove relationship links to the old "bw/ ..." and if you click it you end up on an old broken layout.

comment:4 in reply to: ↑ 3 Changed 7 years ago by planetcruiser

Replying to crumbking:

Seems like really buggy. As far as I understand the relation comments are ready for translation. But do we really want this?

no, not really. let's forget about relation translation for now and make it work for english.

In the add/update form the same digit numbers are shown instead of the comment

ugh, that's bad. however if you use the "Family and close friends" tab on http://www.bewelcome.org/editmyprofile, the comments are shown fine.

i suggest to pull the comment text on /members/<username>/relations/ the same way as on /editmyprofile

http://gitorious.org/bewelcome/rox/blobs/master/build/members/templates/editprofile_form.php#line549

Remove relationship links to the old "bw/ ..." and if you click it you end up on an old broken layout.

this should go into a separate ticket. could you write this?

do you think you could fix this ticket here as part of 0.7, let's say in the next 2 weeks? if so, please assign it to 0.7.

comment:5 Changed 7 years ago by planetcruiser

  • Milestone changed from unassigned to 0.7
  • Priority changed from major to blocker

i think this is really important as more and more people add each other as special relation.

crumbking, if you won't be able to finish this until the end of the week, i can give you a hand.

comment:6 Changed 7 years ago by crumbking

Currently I can't help here as I'm busy with other things. So go for it.

I open the separate ticket for the old layout ...

comment:7 Changed 7 years ago by planetcruiser

  • Owner set to planetcruiser
  • Status changed from new to accepted

comment:10 Changed 7 years ago by crumbking

Tested a couple of profiles. Fixed

Note: See TracTickets for help on using tickets.