Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1593 closed bug (fixed)

Profile page does not render on IE7 and IE8

Reported by: planetcruiser Owned by: planetcruiser
Priority: blocker Milestone: 0.5.7 - bugfixing
Component: unknown Keywords:
Cc:

Description

Issue:

  • Some JS error causes pages to stop rendering after the profile picture is shown
  • In IE7 the browser even redirects to a "Internet Explorer cannot display the webpage" error page

Solution:

  • Fix JS so it runs in all browsers or has a better fall-back

Priority:

  • Really f*ing high, because most of the world can't see the profile pages!

Change History (4)

comment:1 Changed 7 years ago by planetcruiser

  • Owner set to planetcruiser
  • Status changed from new to accepted

comment:2 in reply to: ↑ description ; follow-up: Changed 7 years ago by globetrotter_tt

Replying to planetcruiser:

  • Really f*ing high, because most of the world can't see the profile pages!

Most of the world is still using IE? But you are right, profiles are not shown, probably my fault because of using the fancyzoom script.

What do we learn from it? Do more cross browser testing!

comment:3 in reply to: ↑ 2 Changed 7 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

Replying to globetrotter_tt:

Replying to planetcruiser:

  • Really f*ing high, because most of the world can't see the profile pages!

Most of the world is still using IE?

yes, unfortunately: http://en.wikipedia.org/wiki/Usage_share_of_web_browsers

But you are right, profiles are not shown, probably my fault because of using the fancyzoom script.

fancyzoom is not *that* bad. but we should try to use lightview everywhere.

What do we learn from it? Do more cross browser testing!

well, i tested with all browsers: chromium, firefox and opera. :-P

anyway, this patch switches off fancyzoom for ie, because at least ie6 and ie8 don't like fancyzoom (haven't tested ie7 and ie9): https://gitorious.org/bewelcome/rox/commit/5f68ac95a8badc059e51e739ef2abe674f66f28e

actually also our lightview zoom in the gallery doesn't run on ie8 either, so we should consider replacing it. i will write a ticket for this in a minute

comment:4 Changed 7 years ago by planetcruiser

new ticket for fixing zoom effects is #1596

Note: See TracTickets for help on using tickets.