Opened 6 years ago

Last modified 4 years ago

#1598 needs_work bug

Username check at signup too late

Reported by: planetcruiser Owned by: matt
Priority: major Milestone: unassigned
Component: BW General Keywords: easy, javascript
Cc:

Description

Issue:

  • At signup (/signup) you type in any username and get a green check symbol as soon as it is long enough - you assume the name is available
  • You finish the sign-up process until the last step and if the username is taken, you will be notified - this is disappointing

Solutions:

  1. AJAX check of username availability when leaving username field
  2. Check for username after completing step 1

Priority:

  • Not too low, because a perfect sign-up procedure gives the user a good first impression about BW

Attachments (1)

38.png (95.0 KB) - added by planetcruiser 5 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 5 years ago by TimLoal

  • Component changed from unknown to BW General

comment:2 Changed 5 years ago by crumbking

As you describe it I can't reproduce it. Try henri locally. The symbol will change to yellow. Means that it's correctly checked for the double username.

We could add the error strings to the alt text of the symbol because in case of the username check it could be a wrong character or a taken/double username.

comment:3 Changed 5 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:4 Changed 5 years ago by shevek

  • Milestone set to unassigned

Seems that someone fixed that in the mean time. None of the usernames I tried worked. Even works for 'AskToLeave?' members.

I suggest to close this ticket.

comment:5 Changed 5 years ago by planetcruiser

i just checked. you can still get past the first screen with a username that is already taken (chromium 22, ubuntu), so the bug is still there. annoying.

you can even get past the first screen when entering no password or email.

reproduce:

  1. go to http://www.bewelcome.org/signup
  2. enter your bw username (which is already taken)
  3. press tab 4 times to get to "Next step" button (leave all other fields blank)
  4. you get a green check mark at Username field, yellow warnings at password fields and email (see screenshot)
  5. press "Next step"
  6. you get to http://www.bewelcome.org/signup/2

expected result:

  • error message about username taken, missing password and email
  • at very least the green check mark at username should be yellow, not green

Changed 5 years ago by planetcruiser

comment:6 Changed 5 years ago by planetcruiser

  • Keywords easy javascript added

i just noticed, the icon turns yellow in firefox, so this is a javascript issue in chrome.

msie8 also has this issue. the icon is green there.

comment:7 Changed 5 years ago by shevek

I tried with Chrome on Windows now and could reproduce but not always. Fickle ghost.

But all in all this is fails as designed. Error messages are shown on signup/4.

comment:8 Changed 5 years ago by planetcruiser

yep, bad design, my point. ;) needs fixing, because it's really annoying. imagine the disappointment when you picked your favourite username "matthias" and then are being told in the end "err, actually, not available, we lied, start again!"

comment:9 Changed 5 years ago by matt

  • Milestone changed from unassigned to 1.7
  • Owner set to matt
  • Status changed from new to accepted

comment:10 Changed 5 years ago by matt

I'll do this one, I think now is a time where this is quite important as our membership is growing so fast

comment:11 Changed 5 years ago by matt

someone please test
https://gitorious.org/~mattoz/bewelcome/mattozs-rox/commits/signup_fix
Commit cc6269bb67f00de160a28e7ee8c3d1a8661c0d34

comment:12 Changed 5 years ago by matt

  • Status changed from accepted to local_testing

comment:13 Changed 5 years ago by shevek

Added suggested changes by matt to signup.ctrl.php. Obviously Chrome likes 0 and 1 more than false and true...

comment:14 Changed 5 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:15 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:16 Changed 5 years ago by shevek

  • Status changed from testing to needs_work

comment:17 Changed 5 years ago by shevek

  • Status changed from needs_work to to_alpha

comment:18 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha. Please test.

comment:19 Changed 4 years ago by crumbking

Okay so we just test if the icon turns to yellow while typing a used username in signup/1 in chrome ???

I can't reproduce the issue. In all browsers on FF20/chromium, chrome on www.bewelcome.org the icons change correctly to yellow.

comment:20 Changed 4 years ago by shevek

  • Status changed from testing to needs_work

I could reproduce the issue two days ago. I tried planetcruiser and I got a green checkmark. So fix doesn't seem to change anything.

Last edited 4 years ago by shevek (previous) (diff)

comment:21 Changed 4 years ago by shevek

  • Milestone changed from 1.7 to unassigned

Reverted the commit and undo the changes as fix didn't work: https://gitorious.org/bewelcome/rox/commit/75c9f58de8d499776855faffb46eaa5a369bdba2

Removed from milestone.

Note: See TracTickets for help on using tickets.