Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1599 closed bug (fixed)

Irritating message underneath blog comments

Reported by: planetcruiser Owned by: crumbking
Priority: minor Milestone: 0.9
Component: BW Blogs Keywords:
Cc:

Description

Issue:

  • If you are not logged in you see "Please sign up if you want to make use of this feature." underneath the blog comments
  • This is confusing

Solution:

  • Change to "Please log in to add a comment."

Clues:

  • If this string is only used at blog comments, it can be simply changed in the translation, if it is used elsewhere, a new string needs to be added via translation tool and in the code for displaying blogs

Attachments (1)

15.png (29.7 KB) - added by crumbking 6 years ago.
It will look like this in the end …

Download all attachments as: .zip

Change History (19)

comment:2 Changed 6 years ago by crumbking

When there is no comment above that string is a link with "Would you like to comment?" With a link to the signup. It's this one: http://www.bewelcome.org/bw/admin/adminwords.php?idword=34307

comment:3 Changed 6 years ago by crumbking

  • Milestone changed from unassigned to 1.0
  • Owner set to crumbking
  • Status changed from new to assigned

comment:4 Changed 6 years ago by crumbking

I believe its done.

I added some stuff locally to

http://www.bewelcome.org/bw/admin/adminwords.php?code=PleaseRegister&idword=39173

So the translation will be

Please %ssignup%s or %slog in%s to add a comment.

No sure there is a better way. But did not wanna split up the translation.

Last edited 6 years ago by crumbking (previous) (diff)

Changed 6 years ago by crumbking

It will look like this in the end ...

comment:5 Changed 6 years ago by planetcruiser

  • Milestone changed from 1.0 to 0.9

crumbking: not really that important ("minor" priority), but since you already worked on, commit now

i think it needs no mentioning of "sign up" here, because i doubt that anyone will sign up just to add a blog comment, right? and they will see a sign up link when trying to log in anyway. less is more :)

please check if string 39173 is used in other places as well. if yes, we need to create a new translation for this blog comment notice

comment:6 Changed 6 years ago by crumbking

http://gitorious.org/bewelcome/rox/commit/cdcefc509b8f9bf9bf85079a83272a165a46e896

The string is used in gallery/groups/trips using build/shouts Also in blogs using build/blogs/

I have no idea why the blog app is using separate code. Next logical step would be to remove the comments code in build/blogs and use the shouts app all over the place.

But I guess that would be another ticket.

About signup link: Well I see it a bit different. I's "one click more" to signup. So just leave it now.

For testing add: Please %ssignup%s or %slog in%s to add a comment.

to http://alpha.bewelcome.org/bw/admin/adminwords.php?code=PleaseRegister&idword=39173

and check all blogs/groups/gallery/trips logged in and logged out.

comment:7 Changed 6 years ago by globetrotter_tt

I agree with planetcruiser here: "less is more" i think a link to the login page is enough.

From the login page is a link to the signup anyway.

comment:8 Changed 6 years ago by admin

http://gitorious.org/bewelcome/rox/commit/edb2e541ed700528d1a537320ce821d8316effd4

Removed the signup link.

For testing add: Please %slog in%s to add a comment.

to http://alpha.bewelcome.org/bw/admin/adminwords.php?code=PleaseRegister&idword=39173

and check all blogs/groups/gallery/trips logged in and logged out.

comment:9 follow-up: Changed 6 years ago by crumbking

Maybe we change the PleaseRegister? code after the release as we would otherwise see: "Please x log in x to add a comment" on the live site.

comment:10 in reply to: ↑ 9 Changed 6 years ago by globetrotter_tt

Replying to crumbking:

Maybe we change the PleaseRegister? code after the release as we would otherwise see: "Please x log in x to add a comment" on the live site.

Yes, it would be better.

comment:11 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed: I changed the English version on alpha for testing. Seems to work in all apps: blogs/groups/gallery.

Only a message to the translation team left here... I will do that after the release.

comment:12 Changed 6 years ago by planetcruiser

  • Resolution fixed deleted
  • Status changed from closed to reopened

hm, i don't see a "log in" link at the bottom of http://alpha.bewelcome.org/blog/jsfan/1212 - just the text "Please log in to add a comment." without link. is this intended? i'm confused.

as mentioned in the ticket text, i suggest to create a new word code for this translation, something like "LogInToComment". this way translations are consistent and we can properly test this on alpha

comment:13 follow-up: Changed 6 years ago by crumbking

I tested this on alpha with changing the English translation.(adding the link with %s) I removed this test as otherwise the "x log in x" will be visible on bw.org. It works and not new translation word is needed as we could keep the old translations. Less work for the translation team.

comment:14 in reply to: ↑ 13 ; follow-up: Changed 6 years ago by planetcruiser

Replying to crumbking:

I tested this on alpha with changing the English translation.(adding the link with %s) I removed this test as otherwise the "x log in x" will be visible on bw.org. It works and not new translation word is needed as we could keep the old translations. Less work for the translation team.

hm, i don't see how this is less work for the translation team. doesn't the wording change from "Please sign up if you want to make use of this feature." to "Please [log in] to add a comment." in all languages? i strongly recommend a new word code to keep translations consistent. i can do it later, after i fixed #1432

comment:15 in reply to: ↑ 14 Changed 6 years ago by crumbking

Replying to planetcruiser:

Replying to crumbking:

I tested this on alpha with changing the English translation.(adding the link with %s) I removed this test as otherwise the "x log in x" will be visible on bw.org. It works and not new translation word is needed as we could keep the old translations. Less work for the translation team.

hm, i don't see how this is less work for the translation team. doesn't the wording change from "Please sign up if you want to make use of this feature." to "Please [log in] to add a comment." in all languages? i strongly recommend a new word code to keep translations consistent. i can do it later, after i fixed #1432

Well, my point was that I would like to keep the old translations (means old wording) other than English etc. Using an new word code will mean quite a long time till we see new translations in other than the "main languages". Anyway checked the translations and it seems like we do not have that many.. So my point does not count anymore ;-) Feel free to change.

Note: See TracTickets for help on using tickets.