Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#1633 closed unknown (fixed)

clean up main.js

Reported by: planetcruiser Owned by: planetcruiser
Priority: minor Milestone: 0.7
Component: unknown Keywords:
Cc:

Description

issues:

  • contains unused js includes
  • mapping needs to be DRYer

Change History (5)

comment:1 Changed 7 years ago by planetcruiser

  • Owner set to planetcruiser
  • Status changed from new to accepted

comment:3 Changed 7 years ago by planetcruiser

another fix via:

a full-text search for ".js" reveals that some pages (especially trip related) bypass main.js and load javascript files. *sigh*

but that's for later, or never.. ;)

comment:4 follow-up: Changed 6 years ago by crumbking

Checking the pages with firebug it seems like we are loading all js files on all pages now. Thought we filter just the relevant files we actually need for the actual page?

Guess this is relevant, too? http://gitorious.org/bewelcome/rox/merge_requests/8

Should we reopen or create a new ticket?

comment:5 in reply to: ↑ 4 Changed 6 years ago by planetcruiser

Replying to crumbking:

Checking the pages with firebug it seems like we are loading all js files on all pages now. Thought we filter just the relevant files we actually need for the actual page?

i can not reproduce this on firefox 13, firebug 1.10. for example http://www.bewelcome.org/signup loads registerrox.js, but http://www.bewelcome.org/ does not. could you give a concrete example of what js file should not be loaded where?

Guess this is relevant, too? http://gitorious.org/bewelcome/rox/merge_requests/8

well, if you are testing locally, with rox in a sub folder of your doc root it would be relevant.

Should we reopen or create a new ticket?

for the second part there is a ticket: http://trac.bewelcome.org/ticket/1673

for reopening this ticket here i am waiting for a reproducible scenario

Note: See TracTickets for help on using tickets.