Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1636 closed task (fixed)

OSM: migrate signup

Reported by: planetcruiser Owned by: planetcruiser
Priority: major Milestone: 1.2
Component: BW Geo Keywords:
Cc:

Change History (33)

comment:1 Changed 7 years ago by planetcruiser

  • Description modified (diff)

comment:2 Changed 7 years ago by planetcruiser

  • Description modified (diff)

comment:3 Changed 7 years ago by planetcruiser

  • Owner set to toub
  • Status changed from new to assigned

comment:4 Changed 6 years ago by toub

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 6 years ago by toub

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 6 years ago by toub

  • Owner changed from toub to planetcruiser
  • Status changed from reopened to assigned

Fixed. To be tested and review.

Commited to: https://gitorious.org/~toub/bewelcome/osm-rox Live demo here: http://rox.mishk.org/

comment:8 Changed 6 years ago by globetrotter_tt

  • Milestone changed from unassigned to 0.9 - OSM

comment:9 Changed 6 years ago by planetcruiser

  • Milestone changed from 0.9 to unassigned

toub is travelling until end of september, let's reschedule this once he is back

comment:10 Changed 6 years ago by planetcruiser

  • Milestone changed from unassigned to 1.0

1.0 is the new osm release

comment:11 Changed 6 years ago by toub

Fixed, merged with develop branch, then pushed to a new temporary branch named "osm": https://gitorious.org/bewelcome/rox/commits/osm

Ready for tests and review.

NOTE: this search is very slow, we should open a new bug to improve performances

comment:12 Changed 6 years ago by midsch

I've tried it on http://rox.mishk.org/signup/3 and was able to find all places that came to my mind via search/map. Only the link behind "We found even more results. Show them all?" doesn't work. Maybe a problem of the test setup? Also step 4 of signup http://rox.mishk.org/signup/4 fails. (Another usability problem for later: Some people will try to scroll and zoom to their place to set the marker, but this doesn't work.)

comment:13 Changed 6 years ago by toub

Yes, I am still not able to translate the words (cause I don't know how to do) but I agree that this is just a problem with my local install (I have posted a message on the forums).

About signup/4 crash, the problem appears if you try to use an existing email address. Let's open a new bug about that?

So, I suppose that there is nothing wrong about OSM here (let's confirm with your local install or alpha later).

comment:14 Changed 6 years ago by midsch

I've re-checked step 1-4 with another fakeadress and this time it worked. OSM was fine anyway, so nothing to complain about in this ticket;)

(On the life system I was able to create another account with the emailadress i use for my real account. I think this shouldn't be possible, I ask the dev-list if this is intended otherwise I open another ticket.)

comment:15 Changed 6 years ago by crumbking

I got a after finishing the process at:

signup/4

Sorry :(

BeWelcome has just suffered an error of some magnitude (i.e. we cannot show you the page you were looking for and something went wrong as we looked for it), which is why you are looking at this error message. We apologise for the inconvenience many times, and humbly request that you send the address of this page to us through the feedback (and hopefully that is not the page that brings up this error ...).

Probably not ticket related as step 3 (map) works.

comment:16 Changed 6 years ago by toub

@crumbking yes, not related ticket, same behavious in previous version (probably a problem with local install, e.g. sending the mail).

comment:17 Changed 6 years ago by sitarane

Created user "justesting", using justesting@…. Went fine, including location.

However, I cannot login to check, as the mailinator address doesn't get the confirmation mail. Do we filter out mailinator addresses?

comment:18 Changed 6 years ago by mahouni

seems to work. (I did not finished the signup process and went only until step 4.)

comment:19 Changed 6 years ago by toub

Looks ok (also stopped at step 4)

comment:20 Changed 6 years ago by midsch

Same here, fine on alpha with Chromium Version 20.0.1132.47 Ubuntu 12.04 (144678)

comment:21 Changed 6 years ago by shevek

Actually sign up is as broken as set location. If you search for 'Lodz' it shows a list of matches and tells you that there are even more results and if you'd like to see them all.

Clicking that link doesn't work at all. So it is not really possible to signup in a small village named Lodz in the Greater Poland Voivodeship. :-)

comment:22 follow-up: Changed 6 years ago by crumbking

@shevek: I would say this problem goes somewhere else. (cities not found ticket)

comment:23 in reply to: ↑ 22 Changed 6 years ago by shevek

@shevek: I would say this problem goes somewhere else. (cities not found ticket)

I'd say that is part of the signup process to be able to set your location if it doesn't show up on the first page. If that is broken cause something else is broken that's fine. But for me signup is only migrated if it is working completely.

PS: And I'm not the first one to mention the problem either. Midsch did so 6 weeks ago already. But hopefully the problems fixed with http://trac.bewelcome.org/ticket/1643.

comment:24 Changed 6 years ago by toub

@shevek: I agree that this is a bug, but the bug already exists in current version, so maybe we should create a new ticket for that?

comment:25 Changed 6 years ago by shevek

@toub: As I already said that's 1643

To signup process: The overlay icons on the maps are to large and the map doesn't show the current location but always Zurich over here.

comment:26 Changed 6 years ago by toub

" To signup process: The overlay icons on the maps are to large and the map doesn't show the current location but always Zurich over here. "

Yes that's not fantastic, you have to click on one result to display it on the map.

comment:27 Changed 6 years ago by shevek

I'd expected that the map is set with the current location and if I select another the map is centered to that location.

Probably this doesn't happen as set location is used during signup as well, where there isn't a preset location available.

comment:28 Changed 6 years ago by globetrotter_tt

If i click on more than one result, they are all marked bold with a checkmark. I think only the last clicked location should be marked as it is not a multiple choice.

comment:29 Changed 6 years ago by planetcruiser

  • Status changed from assigned to accepted

i will look into this now

comment:30 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

highlighting problem fixed via:

text decoding issues in map bubble and after saving fixed via:

@shevek: this is sign-up, so there is no "current location", right? i don't know why, but the sign-up map defaults to "Zürich" before entering a location. might be worth a ticket like "world zoom as default map view".

i think jsfan fixed the "Show them all" link thing a while ago. it's working now.

ticket done? ticket done! :) reopen if there are remaining issues

comment:31 Changed 6 years ago by planetcruiser

changing default map zoom on zuerich to whole world via https://gitorious.org/bewelcome/rox/commit/a896b0337ab6419d865f68c228b3a8a6c991b24f

comment:32 Changed 6 years ago by planetcruiser

a few more fixes:

comment:33 Changed 6 years ago by planetcruiser

#1642 is done with the latest fix as well

Note: See TracTickets for help on using tickets.