Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1639 closed task (fixed)

OSM: migrate blog post/trip creation

Reported by: planetcruiser Owned by: planetcruiser
Priority: major Milestone: 1.2
Component: BW Geo Keywords:
Cc:

Description

http://www.bewelcome.org/blog/create needs to be migrated to OpenStreetMap

related ticket:

Change History (26)

comment:1 Changed 7 years ago by planetcruiser

  • Owner set to toub
  • Status changed from new to assigned

comment:2 Changed 6 years ago by toub

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 6 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

I just pulled your code locally and I found a google map we forgot about...

Currently totally useless as it's not working.

See: http://www.bewelcome.org/trip/825 in the sidebar move the up/down arrows down than a google map shows up with the whole trip.

I suggest to move this map from the sidebar to middle between (in the above case) "7 subtrips and "destinations of that trip"

Also I would add the + and - for zooming.

comment:4 Changed 6 years ago by globetrotter_tt

Do we display any information that are for interest there? If not, I would remove the map completely from that page.

comment:5 Changed 6 years ago by toub

There are some dead code that tried to create a polygon inside this lost map.

So yes, your idea is good, but not so easy to implement, due to the very old code here.

Let's create a "new feature" bug in this case (for later), and remove the current map.

comment:6 Changed 6 years ago by crumbking

okay ;-)

@toub I have seen your post in BW. I suggest to merge the stuff into develop. Than we could do some code review and planetcruiser can push it to alpha to test it with live data.

I guess something like:

git checkout develop

git merge --no-ff your-branch-with-OSM-stuff

should do it....

Last edited 6 years ago by crumbking (previous) (diff)

comment:7 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 6 years ago by toub

Ok crumbking, should I do it or can you try for me? (I don't know if I have the rights, and I'm not a git expert).

comment:9 Changed 6 years ago by toub

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:10 Changed 6 years ago by toub

  • Owner changed from toub to planetcruiser
  • Status changed from reopened to assigned

Fixed. To be tested and review.

Commited to: https://gitorious.org/~toub/bewelcome/osm-rox Live demo here: http://rox.mishk.org/

comment:11 Changed 6 years ago by toub

I just comment a few lines in build/trip/templates/singletrip_map.php in order to disable the unused map.

See demo here: http://rox.mishk.org/trip/17

Commited to https://gitorious.org/~toub/bewelcome/osm-rox

comment:12 Changed 6 years ago by globetrotter_tt

  • Milestone changed from unassigned to 0.9 - OSM

comment:13 Changed 6 years ago by planetcruiser

  • Milestone changed from 0.9 to unassigned

toub is travelling until end of september, let's reschedule this once he is back

comment:14 Changed 6 years ago by planetcruiser

  • Milestone changed from unassigned to 1.0

1.0 is the new osm release

comment:15 Changed 6 years ago by toub

Editing/creating a blog trip is broken:

TypeError?: $("geonameid") is null

$('geonameid').value = geonameid;

on file blogSmallMapGeoLocation.js (l49)

comment:16 Changed 6 years ago by toub

  • Owner changed from planetcruiser to toub

comment:17 Changed 6 years ago by toub

  • Owner changed from toub to planetcruiser

N/A

Last edited 6 years ago by toub (previous) (diff)

comment:18 Changed 6 years ago by toub

  • Owner changed from planetcruiser to toub

comment:19 Changed 6 years ago by toub

  • Owner changed from toub to planetcruiser

Fixed. Ready for tests and review (OSM branch on official ROX repository).

comment:20 Changed 6 years ago by crumbking

Tested locally in develop. NOT ready as the frame shows up but there is no map to see. Only a grey box. Zoom in/out does not help. But the switch to google map works.

Last edited 6 years ago by crumbking (previous) (diff)

comment:21 Changed 6 years ago by mahouni

I can confirm the grey box instead of the OSM map, when creating the blog post. Google map works.

comment:22 Changed 6 years ago by toub

Ok, I confirm the bug...

Last edited 6 years ago by toub (previous) (diff)

comment:23 Changed 6 years ago by toub

Fixed to develop branch: please redeploy to alpha

comment:24 Changed 6 years ago by toub

Tested OK on alpha.

comment:25 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from assigned to closed

tested on alpha - looking good

comment:26 Changed 6 years ago by planetcruiser

Note: See TracTickets for help on using tickets.