Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1643 closed bug (fixed)

Update location/signup/blog create/trip add: "Show them all" not working

Reported by: planetcruiser Owned by: planetcruiser
Priority: major Milestone: 1.2
Component: BW Profile Keywords:
Cc: toub

Description (last modified by crumbking)

When searching at http://www.bewelcome.org/setlocation (and signup/blog create/trip add) for a location and getting more than 10 results a link "Show them all?" appears.

Issue:

  • When clicking the link styles for extra results are updated in DOM, but the extra results are not displayed

Solution:

  • Show extra results when clicking the link

Clues:

  • Tested with Chromium, this might work in other browsers

Change History (16)

comment:1 Changed 7 years ago by planetcruiser

  • Description modified (diff)

comment:2 Changed 6 years ago by TimLoal

  • Milestone changed from Future to 1.1

comment:3 Changed 6 years ago by TimLoal

  • Component changed from BW Geo to BW Profile

comment:4 Changed 6 years ago by crumbking

  • Description modified (diff)
  • Summary changed from Update location: "Show them all" not working to Update location/signup/blog create/trip add: "Show them all" not working

This is still an issue. Not only in update location.

comment:5 Changed 6 years ago by crumbking

  • Cc toub added

comment:6 Changed 6 years ago by crumbking

My guess is that the javascript piece in build/geo/geo.view line 110 onwards which does not work...

comment:7 Changed 6 years ago by jsfan

There was a number of problems there... I won't try to find out who tried combining jQuery with Prototype without ever worrying about conflict and then wrote faulty jQuery code on top of that...

Fixed in https://gitorious.org/bewelcome/rox/commit/fc6ccd44941e1468c1c33bd206b1306a6dbafc1b/diffs/fa4ecabad955b30acfbaff2ac1e9b9558fda0943

Deployed on alpha. Please test.

comment:8 Changed 6 years ago by toub

Hi Jsfan,

I introduced JQuery and, according to the documentation:

"If you include jQuery before other libraries [...] There is no need for overriding the $-function by calling "jQuery.noConflict()".

So using "jQuery" instead of "$" here should be enough.

http://docs.jquery.com/Using_jQuery_with_Other_Libraries

comment:9 Changed 6 years ago by shevek

If I search for 'Berlin United' (hoping to get a list of all Berlins in the United States and the United Kingdom) instead a list of capitals is shown (known bug) but now the show all results shows even more of these :-)

comment:10 Changed 6 years ago by shevek

The link itself now has a function but doesn't reveal all results. Try to set the location to Lodz, Greater Poland Voivodeship.

Additionally shouldn't we only search for cities? The list of results if you search for Lodz is a mess of villages around Lodz.

comment:11 Changed 6 years ago by planetcruiser

  • Owner set to planetcruiser
  • Status changed from new to accepted

showing villages is ok i think, and the "list of capitals" bug is not pretty, but not critical.

currently the map always centres on zürich and not the currently chosen location, i'll look into that

comment:12 Changed 6 years ago by shevek

My comment wasn't about showing villages which would be fine if they at least have the name I searched for. But the way the geonames API is used it returns everything that contains the keyword which is pretty awkward.

comment:13 Changed 6 years ago by crumbking

I guess this ticket is done as the additional places are shown.

I fixed the long list in "setlocation" so that it shows the same 2 rows as in signup. Also removed the additional fieldset which doesn't show anything and left the form with the hidden values. I hope this won't break something.

http://gitorious.org/bewelcome/rox/commit/d0a5ec82f1244264355e8b3d52e8af66f5bfb86f

Last edited 6 years ago by crumbking (previous) (diff)

comment:15 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

"show current location on map, flag and parent region when first loading setlocation page; no single quotes around name in map marker bubble": https://gitorious.org/bewelcome/rox/commit/ecb0e6f0ab5308fbf70c13ab594f63ac577924d8

deployed and tested on alpha, closing.

the search result bug needs to be fixed elsewhere.. new ticket?

comment:16 Changed 6 years ago by shevek

The search result doesn't need a new ticket there is already one 1796.

Note: See TracTickets for help on using tickets.