Opened 7 years ago

Closed 6 years ago

#1647 closed bug (fixed)

Sign-up does not accept all UTF-8 chars

Reported by: planetcruiser Owned by: mahouni
Priority: blocker Milestone: 0.8
Component: BW Profile Keywords:
Cc: planetcruiser, mahouni

Description (last modified by globetrotter_tt)

Issue:

  • On http://www.bewelcome.org/signup - if any of these fields contains a special non-ISO character (like Turkish "İ") input is not validated:
    • First Name
    • Second Name
    • Last Name
    • Post code
    • Street
    • Street number
  • Especially in "İstanbul yolu" that's a big problem obviously ;)

Solution:

  • Accept all UTF-8 characters in these fields

Clue:

Related ticket:

Urgency:

  • This is pretty urgent, we are losing sign-ups because of this (I know at least 2 people that didn't complete the sign-up due to this bug)

Change History (12)

comment:1 Changed 7 years ago by planetcruiser

  • Description modified (diff)

comment:2 Changed 7 years ago by planetcruiser

  • Description modified (diff)

comment:3 Changed 6 years ago by globetrotter_tt

  • Cc planetcruiser added
  • Description modified (diff)

Please read #1671 before working on this one.

comment:4 Changed 6 years ago by globetrotter_tt

This ticket has still no owner. Should we move it to a later milestone?

comment:5 Changed 6 years ago by crumbking

Yes let's move this to a milestone after osm.

I want to add that the form fileds in signup and in update profile should be in sync! Therefore we need to check both places.

comment:6 Changed 6 years ago by mahouni

agreed. +1 for moving it to a later milestone

comment:7 Changed 6 years ago by planetcruiser

i don't agree. this is a grave bug that stops many people from signing up with their correct names and addresses, hence the blocker priority. so it should be fixed before the 0.9 osm milestone (which will probably generate its own bug tickets for 1.0)

i will send an email to the dev list about this ticket now

comment:8 Changed 6 years ago by mahouni

Sorry, got headache when looking at that ticket. But here was my entry point: In File https://gitorious.org/bewelcome/rox/blobs/master/build/signup/signup.model.php there is a function checkRegistrationForm().

All values of the registration form raise an error if they don't match a certain regular expression:

!preg_match(self::HANDLE_PREGEXP_STREET, $vars['street'])

The regular expressions HANDLE_PREGEXP_* can be found between line 32 and line 70 of the same file.

When editing a profile no such validation is done, see file: https://gitorious.org/bewelcome/rox/blobs/master/build/members/members.model.php.

comment:9 Changed 6 years ago by mahouni

  • Cc mahouni added
  • Owner set to mahouni
  • Status changed from new to assigned

This weekend Matthias and I worked on that ticket and tried to fix it.
Here is the commit:
https://gitorious.org/bewelcome/rox/commit/3e8e9b5f62d319aa596a669f0b6f2a3bb7a4f7a6

Testing and code review needed..!!

comment:10 Changed 6 years ago by planetcruiser

deployed to alpha, can be tested now

comment:11 Changed 6 years ago by planetcruiser

i just added user http://alpha.bewelcome.org/members/meinhard_test4 with first, middle and last name "İstanbul" - this was accepted during signup - looking good :)

comment:12 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from assigned to closed

I succesfully created a profile (konfuzius) using tamil language for all names. Looks like this is works now.

Note: See TracTickets for help on using tickets.