Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1649 closed bug (fixed)

Relationship comments can sometimes not be updated in profile settings

Reported by: planetcruiser Owned by: shevek
Priority: major Milestone: 1.4
Component: BW Profile Keywords:
Cc: mahouni

Description (last modified by planetcruiser)

Issue:

  • This only seems to be happening for not confirmed relationships and/or with members that don't have the status "Active"
  • On tab "Family and close friends" of http://www.bewelcome.org/editmyprofile text changes in the comment textareas are not saved when pressing "Save profile"

Solution:

  • Save changes on profile saving

Clues:

Related ticket:

Urgency:

  • High, because friend features should be working flawlessly

Change History (20)

comment:1 Changed 7 years ago by planetcruiser

  • Description modified (diff)
  • Priority changed from blocker to critical
  • Summary changed from Relationship comments can not be updated in profile settings to Relationship comments can sometimes not be updated in profile settings

comment:2 Changed 6 years ago by globetrotter_tt

This ticket has still no owner. Should we move it to a later milestone?

comment:3 Changed 6 years ago by crumbking

yes let's move it to the next milestone after osm.

comment:4 Changed 6 years ago by planetcruiser

  • Milestone changed from 0.8 to 1.0
  • Priority changed from critical to major

yes, this one could be moved, because it's not so important.

could anyone reproduce this?

comment:5 Changed 6 years ago by planetcruiser

  • Milestone changed from 1.0 to unassigned

not urgent, let's deal with this later

comment:6 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:7 Changed 6 years ago by jsfan

  • Milestone set to unassigned

It appears that empty descriptions cannot be edited even if the relationship is confirmed.

cf. http://www.bewelcome.org/forums/s2876

Last edited 6 years ago by jsfan (previous) (diff)

comment:8 Changed 6 years ago by shevek

  • Owner set to shevek
  • Status changed from new to assigned

Add relation ship always creates a new entry in specialrelations even if one already exists. That always works. (I'm not entirely sure if this wouldn't create problems later there are now two entries in the db for the same link.)

Why update relations fails isn't clear to me yet. I dig deeper into that.

comment:9 Changed 6 years ago by planetcruiser

  • Description modified (diff)

added related ticket #1868

comment:10 Changed 6 years ago by shevek

  • Keywords 1.4 added

comment:11 Changed 6 years ago by shevek

  • Keywords 1.4 removed
  • Milestone changed from unassigned to 1.4

comment:12 Changed 6 years ago by shevek

The following commit fixes the problem that empty relationship comments couldn't be updated.

Commit: https://gitorious.org/bewelcome/rox/commit/5a524de4338104e70615cf201493a4d06daac61d

comment:13 Changed 6 years ago by shevek

Just did a code review of 'updateRelation' in members.model.php. 'updateRelation' does exactly the same as 'addRelation' create a new entry in 'membertrads' and use that one. Leaving an orphan behind in the 'membertrads' table if a valid one already existed.

Could someone point to a profile where the update fails for a non active member? The code I saw up to now doesn't take the status into account.

comment:14 Changed 6 years ago by mahouni

  • Cc mahouni added

comment:15 Changed 6 years ago by mahouni

I tested it with an inactive member. editing works. I used this sql statement: Update members SET Status = 'ChoiceInactive?' where id = 77777777;

comment:16 Changed 6 years ago by jsfan

Deployed on alpha.

comment:17 Changed 6 years ago by shevek

  • Status changed from assigned to testing

comment:18 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Closing this one as the related one #1868 was set to fixed.

comment:19 Changed 6 years ago by crumbking

Updated an relation in edit profile form. Works

comment:20 Changed 6 years ago by planetcruiser

working fine for me, too.

added a text for a formerly empty relationship for meinhard_test (status ActiveHidden)

Note: See TracTickets for help on using tickets.