Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1672 closed bug (fixed)

Trip page does not load custom css

Reported by: globetrotter_tt Owned by: crumbking
Priority: minor Milestone: 1.4
Component: BW Layout Keywords: css, trips
Cc: mahouni

Description (last modified by globetrotter_tt)

Issue

Solution

  • Include the custom stylesheets in tripsingletrip.page.php

Attachments (6)

after.png (159.1 KB) - added by crumbking 6 years ago.
before.png (222.2 KB) - added by crumbking 6 years ago.
version2.png (156.6 KB) - added by crumbking 6 years ago.
trip_2col.png (53.5 KB) - added by shevek 6 years ago.
trip_2col.2.png (53.5 KB) - added by shevek 6 years ago.
tripview.png (80.3 KB) - added by shevek 6 years ago.

Download all attachments as: .zip

Change History (57)

comment:1 Changed 6 years ago by globetrotter_tt

  • Description modified (diff)

comment:2 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

Changed 6 years ago by crumbking

Changed 6 years ago by crumbking

comment:3 Changed 6 years ago by crumbking

  • Milestone set to unassigned

I worked a bit on the trip view page.

see: http://trac.bewelcome.org/wiki/SandBox/crumbking

I'm would say let's remove the whole gallery/pic functions as it seems no one use it.

I would move the edit and delete links to the sidebar as well.

What do you think?

Last edited 6 years ago by crumbking (previous) (diff)

comment:4 Changed 6 years ago by crumbking

  • Milestone changed from unassigned to 1.3
  • Owner changed from globetrotter_tt to crumbking
  • Status changed from new to assigned

comment:5 Changed 6 years ago by shevek

Changes look really good.

+1 for removing the gallery/pic funtionality if the DB shows no usage.

+1 to move edit and delete into the sidebar.

Changed 6 years ago by crumbking

comment:6 Changed 6 years ago by crumbking

Check version 2:

new:

  • fixed the tab functionality for adding a destination
  • removed the gallery functionality
  • moved all "actions" into the sidebar (also edit and delete)

new ideas see:

http://www.bewelcome.org/forums/s3532-Trip_application_improvements

comment:7 Changed 6 years ago by crumbking

  • Milestone changed from 1.3 to unassigned

I unsigned this one as this will slow us down for the release.

comment:8 Changed 6 years ago by crumbking

  • Milestone changed from unassigned to 1.4

comment:9 Changed 6 years ago by mahouni

  • Cc mahouni added

comment:10 follow-up: Changed 6 years ago by crumbking

2 issues:

  • subtrip order not right after editing
  • strange feedback messages after adding a subtrip (might go in another ticket)

comment:11 follow-up: Changed 6 years ago by mahouni

Cool! the trip function looks much better now!

Some minor things I have found:

  • select category box is empty -> do we need that box?
  • Trip_EditMyOwnSubTrip is a bit lost on the right side of the page
  • after editing the create, the "create"-button is broken. url is trip/7777/finish

Error message:

<input class="submit" type="submit" value=" Notice: Undefined variable: submitValue in myROXpath/build/trip/templates/subtrip_createform.php on line 261 ">

comment:12 in reply to: ↑ 11 Changed 6 years ago by crumbking

Replying to mahouni:

Cool! the trip function looks much better now!

Some minor things I have found:

  • select category box is empty -> do we need that box?

You can create categories here BW/blog/cat So eiter we add a link to create a category first or remove it. I would say let's remove it. Here we wanna add fast a subtrip.

  • Trip_EditMyOwnSubTrip is a bit lost on the right side of the page

moved below the text. better?

  • after editing the create, the "create"-button is broken. url is trip/7777/finish

Error message:

<input class="submit" type="submit" value=" Notice: Undefined variable: submitValue in myROXpath/build/trip/templates/subtrip_createform.php on line 261 ">

This should work now even I don't like this hack ;-) BTW this was broken before (see www.bewelcome.org)

comment:13 in reply to: ↑ 10 ; follow-up: Changed 6 years ago by crumbking

Replying to crumbking:

2 issues:

  • subtrip order not right after editing

Could someone help me here? The subtrips are ordered via blog_start as far as I understand via model. But after editing a subtrip this seems to be updated with the current date so the list is out of order. It should order the list via the travel calender ;-) and not via blog start date.

  • strange feedback messages after adding a subtrip (might go in another ticket)

fixed

comment:14 in reply to: ↑ 13 Changed 6 years ago by mahouni

Replying to crumbking:

  • subtrip order not right after editing

Could someone help me here? The subtrips are ordered via blog_start as far as I understand via model. But after editing a subtrip this seems to be updated with the current date so the list is out of order. It should order the list via the travel calender ;-) and not via blog start date.

should be fixed now. The items were ordered by a strange "blog_display_order", but I don't think that it is used somewhere. So order by blog_start should work hopefully.

comment:15 follow-up: Changed 6 years ago by mahouni

works for me locally.

code reviewed. looks fine.

Just a few things:

  • I don't know if it is okay to start a template with html code instead of a <?php tag ?
  • test ? dothis : dothat; should be avoided. The code is probably copy pasted from somewhere else. I guess I also have a lot of that in the subgroups patch. But if possible, change those to If-statements in brackets.
  • would it be possible to use main.js for loading the scripts in templates/subtrip_createform.php line 311+312 ?

BTW: I found a nice way to compare different commits on gitorious:

for example the first and the last commit related to the trip ticket: https://gitorious.org/bewelcome/rox/commit/118bc210423ee0762bf31eded3df1bdf22d9346e/diffs/94da3421ed8e29d2cddee2e5dd08b404c2517d46 Looks much better than the difftool that is installed on my system.

ready for alpha..

comment:16 in reply to: ↑ 15 Changed 6 years ago by crumbking

Replying to mahouni:

works for me locally.

code reviewed. looks fine.

Just a few things:

  • I don't know if it is okay to start a template with html code instead of a <?php tag ?

Just checked other templates a lot start with HTML. I added some info section in templates.

  • test ? dothis : dothat; should be avoided. The code is probably copy pasted from somewhere else. I guess I also have a lot of that in the subgroups patch. But if possible, change those to If-statements in brackets.

This was there before...All tests I introduced should be in brackets.

  • would it be possible to use main.js for loading the scripts in templates/subtrip_createform.php line 311+312 ?

done!

I cleaned up a bit and also validated the code via W3C.

Btw: There is a $trip->trip_text which seems not in use...

comment:17 Changed 6 years ago by jsfan

Deployed on alpha.

Changed 6 years ago by shevek

Changed 6 years ago by shevek

comment:18 Changed 6 years ago by shevek

I find that the sub trips occupy to much space. Could we use a two column display? Something like this:

Last edited 6 years ago by shevek (previous) (diff)

comment:19 Changed 6 years ago by crumbking

Yeah that was the idea. But somehow I don't get it working.

We should count the array and divide by two. Than show the the first half in a 50% column and the other half in the other 50% column.

Alternative I thought about: We had a map showing the subtrips connected via polygons. Could go on the right side of a 50/50 grid.

comment:20 Changed 6 years ago by shevek

Two columns with the sub trips sounds fine to me. The trip I selected is going round the world it seems so the map would look pretty funny :-)

Sorting in the two columns seems to be a little difficult though. We probably want dates on the right follow on the dates on the left, but if the first trip has really long description the right column might already show two dates.

To be clear here's a table mockup:

LeftRight
14 March
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
23 March
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.
3 May
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.
28 April Amsterdam

So maybe we just go for a table that might have a lot of empty spaces? Like this:

LeftRight
14 March
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
23 March
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.
28 April Amsterdam
No nothing's to see.
3 May
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.
Last edited 6 years ago by shevek (previous) (diff)

comment:21 Changed 6 years ago by crumbking

I thought about that, too. But as we currently see people tend to not write that much. Also after a couple of chars the text will be cutted with a "... more" link.

So if we have 4 subtrips I would do it like:

<div class="subcolumns">
  <div class="c50l">
    <div class="subcl">
        SUBTRIP 1
        SUBTRIP 2
   </div>
  </div>
  <div class="c50r">
    <div class="subcr">
        SUBTRIP 3
        SUBTRIP 4
    </div>
  </div>
</div>

reminder for me:

  • "more" should be translatable

comment:22 Changed 6 years ago by shevek

The cut happens rather late (See http://alpha.bewelcome.org/trip/1144 Europe).

I'm not sure about your numbering scheme but would expect that subtrip 2 has a date between 1 and 3 so I would expect this:

<div class="subcolumns">
  <div class="c50l">
    <div class="subcl">
        SUBTRIP 1
        SUBTRIP 3
   </div>
  </div>
  <div class="c50r">
    <div class="subcr">
        SUBTRIP 2
        SUBTRIP 4
    </div>
  </div>
</div>

That would be fine.

PS: Read more... is already translatable. But there's a space missing.

comment:23 Changed 6 years ago by mahouni

  • Status changed from assigned to testing

comment:24 Changed 6 years ago by shevek

Trip feature looks better now. Far better.

On the edit page (http://localhost/blog/edit/94) the fieldset is broken, though.

Last edited 6 years ago by shevek (previous) (diff)

comment:25 Changed 6 years ago by crumbking

Fixed the blog edit so that we have the same tab styles. Also some other improvements.

Is there an easy hack to edit subtrips/destinations and come back to the trip page?

BTW I'm not going to look into the grid thingy. I'm a bit busy these days... Hopefully better end of February.

comment:26 Changed 6 years ago by crumbking

  • Status changed from testing to needs_work

comment:27 Changed 6 years ago by crumbking

  • Status changed from needs_work to local_testing

comment:28 Changed 6 years ago by jsfan

  • Status changed from local_testing to to_alpha

Deployed on alpha.

comment:29 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:30 Changed 6 years ago by crumbking

Are you sure this is on alpha. Miss my last commits.

comment:31 Changed 6 years ago by shevek

According to the footer the last commit used is https://gitorious.org/bewelcome/rox/commit/32d36e4.

That's 7 days old. Seems that the deployment script failed.

comment:32 Changed 6 years ago by jsfan

I re-ran the deployment script and it claimed that it did not do anything. I didn't check beforehand but I definitely see commit 32d36e4 now. Don't know what went wrong there.

comment:33 Changed 6 years ago by shevek

But 32d36e4 isn't the right one. According to the timestamp it should be https://gitorious.org/bewelcome/rox/commit/82b1982d02bd33822b8bcf729b3274be7df7aafc

Since than there where two more commits.

comment:34 Changed 6 years ago by jsfan

Not sure why I identified this as the latest commit. Seems that my local pull got it wrong. Re-deployed at c43a851 now.

comment:35 Changed 6 years ago by crumbking

My changes are visible on alpha now. Ready for testing on alpha.

Last edited 6 years ago by crumbking (previous) (diff)

comment:36 follow-up: Changed 6 years ago by shevek

Does the change make use of the truncatewords function yet? There is an odd '...' and a 'Read more...' in one of the subtrip mentioned in comment 22.

The fieldset in blogs is fixed.

comment:37 in reply to: ↑ 36 Changed 6 years ago by crumbking

Replying to shevek:

Does the change make use of the truncatewords function yet? There is an odd '...' and a 'Read more...' in one of the subtrip mentioned in comment 22.

Yes the truncatewords function should working now. Do you mean we do not need the first '...' ?

comment:38 Changed 6 years ago by shevek

As we obviously put a 'Read more' after the truncated text I'd drop the '...'.

comment:39 Changed 6 years ago by shevek

  • Status changed from testing to needs_work

comment:40 Changed 6 years ago by shevek

  • Status changed from needs_work to to_alpha

I saw a commit that would drop the '...'. As soon as that is on alpha I'm fine with closing.

https://gitorious.org/bewelcome/rox/commit/9d2e591774e8e256226c21e3d127cc3c04f1c1af

Last edited 6 years ago by shevek (previous) (diff)

comment:41 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:42 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Tested and regarded as fixed.

Changed 6 years ago by shevek

comment:43 Changed 6 years ago by shevek

For 1.5 I'd propose to change it like this:

If it's okay to base that on a table I can submit that to 1.5 now. If not it takes another hour to change <tr></tr> to divs ;-)

Created a new ticket for this (as requested below by crumbking): #1927.

Last edited 6 years ago by shevek (previous) (diff)

comment:44 Changed 6 years ago by crumbking

Please no tables ;-) I'm ok with the layout. But let's create another ticket for it.

comment:45 Changed 6 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

Just replaced a wordcode. So that I can introduce a new wording.

comment:46 Changed 6 years ago by crumbking

  • Status changed from reopened to local_testing

comment:47 Changed 6 years ago by crumbking

  • Status changed from local_testing to to_alpha

comment:48 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:49 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

A small little 'Trip_desc2' is shown below the the description of your trip box on /trip/create. Closed as fixed again.

comment:50 follow-up: Changed 6 years ago by planetcruiser

tested ok, trips look *much* better now. :)

some things:

  • the font size in the trip introduction is larger than the standard font we use everywhere else on the site - this should be reduced to the standard size
  • http://alpha.bewelcome.org/trip has a left padding in the content part now (trips are indented by around 20px). is this intended? on most other bw pages content is left-aligned with the page headline, so i suggest to remove the left padding again

comment:51 in reply to: ↑ 50 Changed 6 years ago by crumbking

Replying to planetcruiser:

tested ok, trips look *much* better now. :)

some things:

  • the font size in the trip introduction is larger than the standard font we use everywhere else on the site - this should be reduced to the standard size

I changed that as most of the text is so little and looks "lost on this huge page.

  • http://alpha.bewelcome.org/trip has a left padding in the content part now (trips are indented by around 20px). is this intended? on most other bw pages content is left-aligned with the page headline, so i suggest to remove the left padding again

Yeah I fixed a bug with missing div in the teaser and the content breaks out on www. Somone fixed it with this padding. So we can remove it. But check other pages which use trip.css if everything is still fine.

Can't help now as I'm on the wrong computer ;-)

Note: See TracTickets for help on using tickets.