Opened 7 years ago

Closed 6 years ago

#1676 closed volunteer task (fixed)

pass the correct success or error message after uploading a picture to gallery

Reported by: mahouni Owned by:
Priority: minor Milestone: 1.0
Component: BW Gallery Keywords:

Description (last modified by mahouni)

In file gallery.ctrl.php on line 440


should callback to gallery/upload and display an error message if the upload fails. At the moment the redirect is in both cases (successful and fail) set to the members gallery page.

PS: It seems that it gets "false" even when the upload was successful..

Change History (7)

comment:1 Changed 7 years ago by mahouni

  • Description modified (diff)

comment:3 Changed 7 years ago by jsfan

  • Milestone changed from Future to 1.0

comment:4 Changed 6 years ago by globetrotter_tt

I tried to upload a .psd file (600kb) and i got following message:

Sorry :(

BeWelcome has just suffered an error of some magnitude (i.e. we cannot show you the page you were looking for and something went wrong as we looked for it), which is why you are looking at this error message. We apologise for the inconvenience many times, and humbly request that you send the address of this page to us through the feedback (and hopefully that is not the page that brings up this error ...).

Uploading .svg and .eps files gave me a proper error message (logo_orange_blue.eps => Not an image file.)

comment:5 follow-up: Changed 6 years ago by jsfan

Not that I like it but you can just check for more details. Basically, the image module detects and image but throws an exception because it is not supported. :( Maybe we need a new ticket for that.

comment:6 in reply to: ↑ 5 Changed 6 years ago by jsfan

I just had a quick look and this is definitely a new ticket. While the method isImage() in the image module only cares about the image being supported or not, the method createThumb() makes a difference between "supported" and "unsupported" image types. This was not introduced by the patch but has always been a bug.

This bug is now #1751. If there are no further problems here, I'd suggest we close this ticket.

comment:7 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.