Opened 6 years ago

Closed 6 years ago

#1677 closed improve feature (wontfix)

Relationship in comments view is very counter-intuitive

Reported by: jsfan Owned by: shevek
Priority: minor Milestone: 1.5
Component: BW Profile Keywords: comments
Cc:

Description

In the comments view, comments are always shown along with replies. However, next to either one it will say something like "He/she was my host", "He/she was my guest", etc..

While the view gives impression that this refers to if the person next to the comment was guest or host, it is actually the same for any given pair and refers to the profile being viewed. In other words, all my guests will have a "He/she was my guest" next to both their comment and my reply and all my hosts will have a "He/she was my host" both next to her name and next to mine.

I believe that this is very counter-intuitive. The wording should refer to the shown pair not the profile. Maybe even a wording like "Foo was my guest" and "Bar was my host" next to the two parts of the comment pair could be used.

Change History (17)

comment:1 Changed 6 years ago by crumbking

Yes, agree we should show the data of the writers of the comments.

Means:

from Username Y: Username X was my host

from Username X to Username Y: Username Y was my guest

Or other way around with host/guest.

Shorter Alternative (not sure if it's still clear then):

from Username Y: Username X was my host

from Username X: Username Y was my guest

Or other way around with host/guest.

comment:2 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:3 Changed 6 years ago by planetcruiser

  • Milestone set to unassigned
  • Owner set to planetcruiser
  • Status changed from new to assigned

too complicated! :) can't we just remove "He/she was my ..." for counter-comments and be done with it?

this would at least solve this issue quickly: http://www.bewelcome.org/forums/s2853-Bug__Check_mark_guest_host_in_the_references

comment:4 Changed 6 years ago by planetcruiser

  • Owner changed from planetcruiser to jsfan

oops, didn't mean to assign to myself

comment:5 Changed 6 years ago by shevek

  • Milestone changed from unassigned to 1.5
  • Owner changed from jsfan to shevek

Too complicated? There was just a c missing ;-)

comment:7 Changed 6 years ago by shevek

  • Status changed from assigned to local_testing

comment:8 Changed 6 years ago by mahouni

local_testing on the mileston 1.5 branch:
https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commits/ms15_develop_20130129

Don't forget the Database update for ticket #1892 and #1858.
Check: http://trac.bewelcome.org/wiki/DatabaseChanges

Last edited 6 years ago by mahouni (previous) (diff)

comment:9 Changed 6 years ago by crumbking

I get an notice in the comment section of the profile:

Notice: Undefined property: stdClass::$Username in /home/crumb/webdev/bw/build/members/templates/profile.subcolumn_right.php on line 219 Notice: Undefined property: stdClass::$Username in /home/crumb/webdev/bw/build/members/templates/profile.subcolumn_right.php on line 219 from - 2009-06-03 14:13:23

... while beeing on the 1.5 branch.

comment:10 Changed 6 years ago by shevek

That's okay... because I didn't touch that one ;-)

comment:11 Changed 6 years ago by dima42

There appears to have been a communication gap:

I don't think the commit fixes this ticket. As I read, it, the ticket asks to change the display text from the form "He/she was my guest" to the form "xxx was my guest"

This is handled in comment_template.php lines 80-82 and 166-168, which each pull the "$words->get("Comment_"[i])" attribute. These pull the words "He was my guest" directly using the "hewasmyguest" key. There is still no reference to the usernames involved. We would additionally have to strip the text.

What the commit does do is add both a "from" and a "to" field to the header of the comment, e.g. explicitly notes that a comment is from xxx to yyy rather than just from xxx. It's not clear to me whether this was ambiguous in the first place.

The commit also uncouples the relationship links, and instead looks up the individual Lenght entries in the words database. This is a good idea; however, it still leaves ambiguity. When we see a reference on henri's page from wuuk to henri, and the comment notes "He\She was my guest" it is completely unclear to me whether it is from the point of view of henri or wuuk. So we have the opposite ambiguity from the one we had before.

This is probably somewhat better than what we had before; however, I don't think the ticket should be closed.

comment:12 Changed 6 years ago by shevek

The problem described in the summary stems from the wrong display of the relation 'he/she was my guest' and 'he/she was my host'. As this is now sorted I don't think we need further changes.

We probably should close this ticket as wontfix.

comment:13 Changed 6 years ago by jsfan

  • Status changed from local_testing to to_alpha

Agreed.

comment:14 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:15 Changed 6 years ago by jsfan

  • Resolution set to fixed
  • Status changed from testing to closed

comment:16 Changed 6 years ago by jsfan

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:17 Changed 6 years ago by jsfan

  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.