Opened 6 years ago

Closed 6 years ago

#1702 closed task (fixed)

Remove chat

Reported by: jsfan Owned by: jsfan
Priority: critical Milestone: 0.9
Component: unknown Keywords:
Cc:

Description (last modified by planetcruiser)

The current chat isn't used and doesn't work well, either. It should be removed.

Later, it could be replaced by a different chat (cf. #1564)

Forum thread:

Change History (18)

comment:1 Changed 6 years ago by planetcruiser

  • Description modified (diff)

comment:2 Changed 6 years ago by jsfan

I quickly went through this and if I haven't missed any links, I should be done already. I didn't touch any of the configuration related stuff though.

I'm happy to attach this to 0.9 and push straight away but could also hold back until 1.0 to not overwork the testers. ;)

comment:3 Changed 6 years ago by jsfan

  • Owner set to jsfan
  • Status changed from new to accepted

comment:4 Changed 6 years ago by jsfan

I have a patch ready for this but will only push it once the milestone to assign this to has been agreed on.

comment:5 Changed 6 years ago by jsfan

As I just found out (thanks for the pointer, globi :)), I inadvertently merged this and pushed it a while ago. Well, I suppose it's done now... ;)

comment:6 Changed 6 years ago by jsfan

  • Milestone changed from unassigned to 0.9

comment:7 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from accepted to closed

Chat is not available on alpha anymore. all good :)

comment:8 Changed 6 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

Found one error while opening the http://alpha.bewelcome.org/chat

It jumps to the internal startpage. Thats fine. But it shows some errors in the recent forum posts.

Warning: Cannot modify header information - headers already sent by (output started at /var/rox/deployment/alpha.bewelcome.org-d352192/templates/shared/roxpage/topmenu.php:61) in /var/rox/deployment/alpha.bewelcome.org-d352192/lib/handler/requesthandler.lib.php on line 86 

comment:9 Changed 6 years ago by jsfan

  • Resolution set to fixed
  • Status changed from reopened to closed

Re the PHP error:

Who would have thought that it's a bug in the forums model... ;)

This bug has probably always existed. It's just that nobody has ever noticed it before...

I'm closing this ticket. The new ticket for this issue is #1709.

comment:10 Changed 6 years ago by planetcruiser

if someone is really bored, grepping for "chat" still returns some files that should probably be looked at as well. it's mostly about chat configuration as far as i can see:

  • inc/config.inc.php.example
  • build/online/online.ctrl.php
  • roxlauncher/environmentexplorer.php
  • roxlauncher/roxlocalsettingsimporter.php
  • roxlauncher/roxloader.php

comment:11 Changed 6 years ago by planetcruiser

  • Resolution fixed deleted
  • Status changed from closed to reopened

i think this deserves a reopen, because it's part of removing the chat

comment:12 follow-up: Changed 6 years ago by jsfan

Well, I kind of left those on purpose. I didn't see much benefit in removing it but some change of breaking something. Happy to chuck all these out and take my chances though... ;)

BTW, build/online isn't linked to anywhere, is it? Shouldn't we remove it altogether then as well?

comment:13 in reply to: ↑ 12 ; follow-up: Changed 6 years ago by planetcruiser

Replying to jsfan:

Well, I kind of left those on purpose. I didn't see much benefit in removing it but some change of breaking something. Happy to chuck all these out and take my chances though... ;)

let's not clutter the code any further by leaving unused bits around? i didn't look at those lines, but are they really so intertwined with other things that could break?

BTW, build/online isn't linked to anywhere, is it? Shouldn't we remove it altogether then as well?

well, that's another discussion (http://bewelco.me/f/1079) - i would like to see it back on the site, because i think it's a nice gadget

comment:14 in reply to: ↑ 13 ; follow-ups: Changed 6 years ago by jsfan

Replying to planetcruiser:

Replying to jsfan:

Well, I kind of left those on purpose. I didn't see much benefit in removing it but some change of breaking something. Happy to chuck all these out and take my chances though... ;)

let's not clutter the code any further by leaving unused bits around? i didn't look at those lines, but are they really so intertwined with other things that could break?

Sure. Just cleaned it up and pushed it. One of the files you listed only had a comment (in online) while there were also the files.

  • text/en/apps/mytravelbook/topmenu.php
  • text/de/apps/mytravelbook/topmenu.php
  • htdocs/bw/layout/menus.php

Should the former two even exist at all? Now that we're talking cleanup... ;)

BTW, build/online isn't linked to anywhere, is it? Shouldn't we remove it altogether then as well?

well, that's another discussion (http://bewelco.me/f/1079) - i would like to see it back on the site, because i think it's a nice gadget

Yes, it is. I can't see the thread you are referring to though. It tells me "Please log in to see the thread" even when I am logged in. :(

comment:15 in reply to: ↑ 14 Changed 6 years ago by globetrotter_tt

  • text/en/apps/mytravelbook/topmenu.php
  • text/de/apps/mytravelbook/topmenu.php
  • htdocs/bw/layout/menus.php

Should the former two even exist at all? Now that we're talking cleanup... ;)

We still need htdocs/bw/layout/menus.php for the admin pages and the password recovery page.

The mytravelbook should not be in use anymore (hopefully - you never know with rox)

comment:16 in reply to: ↑ 14 ; follow-up: Changed 6 years ago by planetcruiser

Replying to jsfan:

  • text/en/apps/mytravelbook/topmenu.php
  • text/de/apps/mytravelbook/topmenu.php
  • htdocs/bw/layout/menus.php

Should the former two even exist at all? Now that we're talking cleanup... ;)

probably not. but let's stay on topic and ignore those for now. ;) htdocs/bw is an unholy mess anyway. anyway, thanks for the quick fix. once successfully tested on alpha this ticket can be closed for good i believe.

I can't see the thread you are referring to though.

oops, sorry, it's a group only thread. you need to join the http://www.bewelcome.org/groups/47 first. it might be worth discussing this in a public thread.

It tells me "Please log in to see the thread" even when I am logged in. :(

the error message is misleading. i thought this was fixed a while ago? hm..

comment:17 in reply to: ↑ 16 Changed 6 years ago by jsfan

Replying to planetcruiser:

Replying to jsfan:

  • text/en/apps/mytravelbook/topmenu.php
  • text/de/apps/mytravelbook/topmenu.php
  • htdocs/bw/layout/menus.php

Should the former two even exist at all? Now that we're talking cleanup... ;)

probably not. but let's stay on topic and ignore those for now. ;) htdocs/bw is an unholy mess anyway. anyway, thanks for the quick fix. once successfully tested on alpha this ticket can be closed for good i believe.

Yep. The last one I had overlooked in my original patch. Feel free to close this ticket again if you are satisfied that all references to the chat have been removed now. :)

comment:18 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from reopened to closed

clicking around on http://alpha.bewelcome.org/ things look good

Note: See TracTickets for help on using tickets.