Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1703 closed improve feature (fixed)

Allow more than one group admin

Reported by: mahouni Owned by: crumbking
Priority: critical Milestone: 1.2
Component: BW Group Keywords:
Cc: planetcruiser

Description (last modified by mahouni)

It should be possible to add more than one group admin to a group.

A first patch is ready and can be tested here: [nunatakker.li/bewelcome]

username: lupo-test or ieva passoword: Obatzda77

  • As group owner go to Group Settings -> Administrate members
  • the group Owner can add other group members as admin
  • a group admin can resign as admin
  • the group fonder can eventually leave the group after resigning
  • a BW admin can add group members as admin
  • usernames of group admins (with profile links) are displayed underneath the group members

please review the source code here (I already worked on it, so it isn't the latest code, but I will update regularly): https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commits/groupadmins

Attachments (1)

26.png (97.4 KB) - added by crumbking 6 years ago.
group overview

Download all attachments as: .zip

Change History (26)

comment:1 Changed 6 years ago by mahouni

  • Description modified (diff)

comment:2 Changed 6 years ago by TimLoal

  • Component changed from unknown to BW Group
  • Status changed from new to assigned

comment:3 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:4 Changed 6 years ago by jsfan

  • Milestone set to unassigned

Looks good to me. However, you don't allow for large groups by listing all members without pagination in the admin's member settings view.

comment:5 Changed 6 years ago by beatnickgr

  • Priority changed from major to critical

is this ready to be released on alpha for testing then?

comment:6 Changed 6 years ago by planetcruiser

  • Milestone changed from unassigned to 1.2

jsfan said he'll patch it in

comment:7 Changed 6 years ago by jsfan

  • Owner changed from mahouni to jsfan

@mahouni: I'll take over the ticket to make some slight modifications, if you don't mind.

comment:8 Changed 6 years ago by mahouni

yes, that would be great. I haven't found much time to work on ROX recently. The branch should be up to date with the current milestone.

Pagination to administrate members is missing at the moment, but on the other hand, our pagination feature is sometimes improving for the worse: without pagination you can easily find a username by using the search feature of the browser. But with the pagination, you'll need to find out on which page that username would be. The pages in the middle of the pagination division are more or less lost, unless you click endlessly through the "next" buttons, or write the page number directly in the url.

I also wanted to add the possibility to create groups without admins, but that could be something for a different ticket in a later milestone. And it is already possible: if the group owner leaves the group after creating it.

comment:9 Changed 6 years ago by toub

Cool. That's definitely a nice feature!

Works on demo web site, need to test to alpha.

comment:10 Changed 6 years ago by beatnickgr

  • Resolution set to fixed
  • Status changed from assigned to closed

has been tested on alpha, working fine. TT closing.

comment:11 Changed 6 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

Mahouni could you write down all new wordcodes for the tool? (alpha links)

So that after the release we can post them to the translation team?

The design is - how to say -ugly ;-)

Admins should get a face. I will add pics to the group front page. As this is visible to the world.

comment:12 Changed 6 years ago by crumbking

  • Owner changed from jsfan to crumbking
  • Status changed from reopened to assigned
Last edited 6 years ago by crumbking (previous) (diff)

comment:13 Changed 6 years ago by mahouni

Not showing the pictures of the the admins is an essential part of this ticket. We are totally fed up with looking at the group moderators on couchsurfing, aren't we? The admins have to be listed (with profile links, but without picture) somewhere at the bottom of the group page, also we need to make the admin title smaller:

 <h4><?php echo $words->get('GroupAdmins'); ?></h4>

Though, I agree that the design of the group page is ugly.
But we have space now. The admins list needs much less space than the group owner before. We could add a bigger group image or another improvement could be achieved by showing more group members. I would say 15, newest members first.
I will have a look at this.

comment:14 Changed 6 years ago by jsfan

  • Cc planetcruiser added

I thought the same thing as crumbking when I first looked at this but now agree with mahouni. I think there is no need to double up the admins' pictures (they are in the member list, anyway). All that matters is that we show who the admins are.

I'd vote for reverting to the text link list.

What I'd still find more important is pagination on the member list in the members administration.

comment:15 follow-up: Changed 6 years ago by crumbking

The admins might be in the members list (on small groups) but the suggestion by mahouni would help here: another sort order of the member list.

As you don't want such "prominent/visible" space for the admins pictures extend the member list.

So:

  • +1 extend memberlist
  • +1 change sort order member list to not show admins
  • +1 show a smaller admins section (smaller admin pics, smaller headline)
  • +1 larger group pic

But please don't show something like username / username / username. ;-) Loos like HC.org ;-)

comment:16 in reply to: ↑ 15 Changed 6 years ago by mahouni

Replying to crumbking:

But please don't show something like username / username / username. ;-) Loos like HC.org ;-)

Yes, that's also true! I am definitively not a Frontend man.

A memberlist with 15 group members and admins picture size with PIC_30_30 seems to be acceptable. Maybe a border line around the block? But that's for another ticket about a group page redesign.

Pagination is ready, but needs further testing. I've set 5 items per page atm, for testing. I would increase it to ~50 later. Please test what happens to the member list on the administration page if e.g. someone has a long username or translation words are longer. BTW those slashes origin from there - banMember / kickMember ...


https://gitorious.org/bewelcome/rox/commit/fc6ccd44941e1468c1c33bd206b1306a6dbafc1b

Last edited 6 years ago by mahouni (previous) (diff)

Changed 6 years ago by crumbking

group overview

comment:17 Changed 6 years ago by crumbking

@mahouni: looks much better now.

I attached a pic. There I improved / cleaned up the sidebar. Removed the Headline above the button to join/leave. Because I believe the button says what you can do. Therefore the extra headline seem to me not useful. This moves everything a bit up and therefore I added some space between members <-> button and some space between "see all members" and "Groupadmins".

  • Should I add those changes?
  • mahouni could you live with 12 members in the members list? ;-)
  • 30x30 is really small. Could we go for 40x40 for the admins? ;-)

A side note: The layoutsbits function does not seems to scale down the pics. I have the feeling the quality is really bad. Or maybe it's just my screen?

comment:18 Changed 6 years ago by jsfan

I'll leave this in your capable hands guys. I'm off to finally fixing the search?!

comment:19 Changed 6 years ago by mahouni

Yes, go ahead: 12 members and 40x40 looks good.

That headline is really not necessary. I think we have this in other places too, e.g. on the forum page you can read 4 times that you can do a search.

About the image scaling: There is something about an image quality option, maybe check that. But my screen is poor too, since I broke some settings on my notebook, so can't comment on that...

I still don't like the different buttons for "join group" and create "new topic". Both seems to be a bit lost and could be placed better. But I don't know where.. And I think that the group comments/shouts are rather useless. But that's for another ticket!

comment:20 Changed 6 years ago by beatnickgr

quite better :)

instead of 12 new members, i think it's better to put 12 members who last login. many new members dont have a profile picture, and this doesnt look good in the group. i'd prefer to see the members who are more active instead, what you think?

comment:21 Changed 6 years ago by mahouni

I changed it to 12 and to order by last logged in members, but those members who logged in in the previous week are sorted by name. It needed some additional work and I hope I haven't broke other things. Admins picture are now 40x40. please test again...

If it works and after crumbking's changes I will set the pagination of members administration to 50 and close the ticket.

Further redesigns to new tickets please.

comment:22 Changed 6 years ago by crumbking

done: http://gitorious.org/bewelcome/rox/commit/2bb33b31529a8a298b927a32f3b368c037dee376

let's close this one....

Mahouni could you write down all new wordcodes for the tool? (alpha links)

this will be open for the release.

Let's focus on OSM, now ;-)

comment:23 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:24 Changed 6 years ago by mahouni

okay I just updated the pagination to 50 members per page and will ask 2-3 admins of bigger groups, if that number is appropriate or not.

the wordcodes:

on http://alpha.bewelcome.org/groups/200000

  • GroupAdmin
  • and maybe GroupNoAdmin

on http://alpha.bewelcome.org/groups/200000/memberadministration

  • GroupsAddAdmin
  • MemberIsAdmin
  • resignAsAdmin
  • GroupsConfirmMemberAsAdmin
  • GroupsConfirmResignAsAdmin

that's it.

comment:25 Changed 6 years ago by mahouni

Addtionally there are some new setFlashNotices and -Errors with translation words for this feature and for the group join/invitation tickets.

most of them probably in the file groups.ctrl.php:

  • GroupAdminResignationFailed_LastAdmin
  • GroupAdminResignationFailed
  • GroupAdminResignationSuccess
  • !GroupLeaveFail_ResignAdminFirst
  • GroupNewAdminSuccess
  • GroupAdminResignationFailed


  • GroupsLeaveSuccess
  • GroupsLeaveFail
  • GroupJoinSuccess
  • GroupsJoinApprovalWait
  • GroupsErrorJoiningGroup
Note: See TracTickets for help on using tickets.