Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1721 closed improve feature (fixed)

OSM: Button for a switch to "old search" / google search

Reported by: midsch Owned by: midsch
Priority: major Milestone: 1.2
Component: BW Geo Keywords: OSM mapsearch
Cc:

Description

For the beginning in the forum was mentioned (and not opposed) to have a switch button to access the old/google search. This is still missing at http://rox.mishk.org/searchmembers so it probably needs to be added.

Change History (13)

comment:1 Changed 6 years ago by planetcruiser

hm, why would this be needed and until when is this supposed to stay? i can't find the forum post you are referring to.

cons:

  • duplicate code to maintain
  • remaining google code in rox
  • extra work for osm release

pros?

my suggestion: don't bother about a google/osm button, but go osm only

comment:2 Changed 6 years ago by midsch

I'm fine with dropping google at all (there's still the general search script to get rid of) and closing this ticket. The switch was suggested by toub in: http://www.bewelcome.org/forums/s2234-Switch_to_Openstreetmap - his arguments:

<snip> About OSM switch, I have just one remark: I would like to keep GMap as an alternative, at least in the first weeks.

Why? Because OSM maps are good/better in the cities, but outside it's sometime very worse. So why don't let the choice to the user? It is easy to do it with Leaflet map API, now we have removed GoogleMap? v2 (this functionnality only works with GoogleMap? v3). </snip>

So it's just a failback option for the first time (we could even set a date) with no code maintainance for google code intended;)

comment:3 Changed 6 years ago by crumbking

I would also keep the gmap option as user option. Check OSM in Asia country side - not even streets ;-)

comment:4 Changed 6 years ago by abyssin

On the demo server (http://rox.mishk.org/searchmembers) Open Street Map is missepelled "Open Steet Map" (missing the "r") in the menu to switch to Google Map.

(Don’t know if it’s the right place to report but I hope someone will correct me if I’m wrong.)

comment:5 follow-up: Changed 6 years ago by toub

Fixed, merged with develop branch, then pushed to a new temporary branch named "osm": https://gitorious.org/bewelcome/rox/commits/osm

Ready for tests and review.

===============================

abyssin: thanks for the report, could you open a new bug for that?

comment:6 in reply to: ↑ 5 Changed 6 years ago by abyssin

Replying to toub:

abyssin: thanks for the report, could you open a new bug for that?

done! http://trac.bewelcome.org/ticket/1725

Last edited 6 years ago by abyssin (previous) (diff)

comment:7 Changed 6 years ago by toub

  • Owner changed from toub to midsch
  • Status changed from new to assigned

Fixed (we can switch directly on the map).

comment:8 Changed 6 years ago by crumbking

Works. We should move to alpha.

comment:9 Changed 6 years ago by toub

Still ok on alpha.

comment:10 Changed 6 years ago by midsch

Fine on alpha with Chromium Version 20.0.1132.47 Ubuntu 12.04 (144678)

comment:11 Changed 6 years ago by crumbking

Fine on alpha. Switch works on the map. with FF.

comment:12 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from assigned to closed

Works for me, too.

comment:13 Changed 6 years ago by sanderr

Yep, fine on alpha. Smooth!

Note: See TracTickets for help on using tickets.