Opened 5 years ago

Last modified 3 years ago

#1743 new bug

Hidden groups are not really hidden

Reported by: globetrotter_tt Owned by: jsfan
Priority: critical Milestone: unassigned
Component: BW Group Keywords: groups privacy
Cc: planetcruiser

Description

Issue:

  • When creating a group, the user has the option: "This is a hidden group, only invited members can join". While non members can not see the content of this group, it is not really hidden and shows up in list of all groups list and search. Furthermore discussions of groups are listed in the list of recent posts in the forum because the default setting is not "group only"

Solution:

  • Either the group should be really hidden or renamed to "private group"
  • Change the default setting for starting a discussion inside a group to "group only"

Change History (10)

comment:1 Changed 5 years ago by jsfan

  • Owner changed from Fake51 to jsfan
  • Status changed from new to assigned

This probably comes totally unexpected but the code behind this is a mess. :(

There is in fact a setting that allows you to make all new threads of a group default to "group only". The problem is that "hidden" groups do not default to that and it can only be set if the group settings are edited AFTER creation.

What do we want to do now?

  • default "hidden" (really "private") groups to "group only" default
  • set all groups to "group only" default
  • set hidden groups to "group only" everything else to "members only"

I think at the moment the last option could work but with the forums becoming busier, the second one might make more sense long term.

Also, we could get rid of the "NoRestriction" option altogether.

comment:2 Changed 5 years ago by jsfan

  • Cc planetcruiser added
  • Milestone set to 1.1

comment:3 Changed 5 years ago by jsfan

My current patch (not merged/pushed yet) now

  • allows setting of thread visibility at group creation time.
  • defaults all forum posts to "MembersOnly"

Should I merge and push?

comment:4 Changed 5 years ago by jsfan

I've decided to push my changes because I might not be online much later today. I haven't deployed on alpha, however.

comment:5 Changed 5 years ago by planetcruiser

ok, i am a bit confused. do your changes only apply to posts in the hidden groups or to all forum posts?

Also, we could get rid of the "NoRestriction?" option altogether.

NoRestriction? means world-readable in rox speak, right? get rid of it in the hidden group context you mean? makes sense.

the behaviour of a hidden group i would expect is this:

  • all threads are only visible by group members
  • if the group itself gets unhidden for the world or bw members, all threads will be visible for the world or bw members

setting of visibility per post does not make sense to me, because it will break a conversation for outside readers if visibility settings of posts within one thread differ. visibility should only be set for threads.

my 2ct. ;)

comment:6 Changed 5 years ago by jsfan

Sounds like a forums rewrite... :P

comment:7 Changed 5 years ago by jsfan

I've reverted the change to the default now.

comment:8 Changed 5 years ago by jsfan

Without the change to the default this is a trivial fix. I don't think this really fixes the bug as described before but maybe we should close this ticket and move the remaining problems onto a new ticket.

comment:9 Changed 5 years ago by jsfan

  • Milestone changed from 1.1 to unassigned

I have now moved the separate issue of allowing setting the default visibility at creation time to ticket #1764 and unassigned this ticket.

comment:10 Changed 3 years ago by shevek

  • Status changed from assigned to new
Note: See TracTickets for help on using tickets.