Opened 10 years ago

Closed 9 years ago

#175 closed bug (fixed)

Members per Country don't appear on Algeria

Reported by: midsch Owned by: peleg
Priority: minor Milestone: 0.1.2-outreach-bugfixing
Component: BW Search Keywords: by country
Cc: micha

Description

from: https://www.bewelcome.org/flyspray/task/192

click on http://www.bewelcome.org/countries.php and on Algeria the counting says one member and there is one. but with a click on Algeria you just get a white page .. maybe because the one member is living in a City that belongs to ‘no region defined’ ?

additional comment from midsch:
in a way it's still valid in production, the page for Algeria is only listing 2 out of 3 members. Membersearch is finding all the 3 of them.

Outdated with the new search?

Change History (16)

comment:1 Changed 9 years ago by micha

  • follow_up set to test
  • Milestone changed from unassigned to 0.1.1-outreach-bugfixing

please test again with new /country application.

comment:2 Changed 9 years ago by micha

  • version changed from production to all

comment:3 Changed 9 years ago by matrixpoint

  • follow_up changed from test to move to alpha

I compared the members per country with the Advanced Search results on the test server. The results were identical. Each of the countries had the correct number of members.

comment:4 Changed 9 years ago by matrixpoint

  • follow_up changed from move to alpha to test on alpha

The new country app is already on alpha, so I did a quick test, picking a few random countries: Algeria (3 members) and Sweden (13 members). It seems to work. So one more alpha tester is needed.

comment:5 Changed 9 years ago by steinwinde

I checked with Estonia, Greece, Bulgaria, which all was right: display of total showed the same number as the list of the members; I tested as logged in member and not logged in member.

To my big surprise also those members are displayed to me (user name and city), who don't want to be publicly visible. Has this been discussed somewhere? I can't believe, that this is agreed. This is a serious privacy issue - not only I use a username in BeWelcome, which is known outside of it - and I'd like to be able to hide my membership! At least I don't want Google to find out about it!

comment:6 Changed 9 years ago by micha

this is right. We have to fix this for non-public profiles. Even though I don't consider that critical.

Will try to find a way around this, before we move on production.

comment:7 Changed 9 years ago by micha

  • Owner set to micha
  • Status changed from new to assigned

comment:8 Changed 9 years ago by peleg

  • Cc micha added
  • follow_up changed from test on alpha to test
  • Keywords by country added
  • Owner changed from micha to peleg
  • Status changed from assigned to new

The last problem mentioned (unlogged users can see non-public profiles in country search) is fixed on changeset 3519.

comment:9 Changed 9 years ago by peleg

  • follow_up changed from test to move to alpha

comment:10 Changed 9 years ago by matrixpoint

  • follow_up changed from move to alpha to test on alpha

moved country.model.php to alpha r3527.

comment:11 follow-up: Changed 9 years ago by matrixpoint

Tested Algeria on alpha. Shows no members when not logged in, 3 members when logged in.

One more alpha test needed.

comment:12 in reply to: ↑ 11 Changed 9 years ago by peleg

That's not a good test; the other test should check in countries where there are users with public profiles, like Germany.

comment:13 Changed 9 years ago by matrixpoint

Good point. I tested Canada also, which has 9 public profiles out of 48 members.

comment:14 Changed 9 years ago by micha

  • follow_up changed from test on alpha to release

I tested aswell. Seems to work smoothly. Still it's an application on construction but it's working for now and not showing security issues. Move it to production!

comment:15 Changed 9 years ago by matrixpoint

Moved to production in r3566: country.model.php

comment:16 Changed 9 years ago by matrixpoint

  • follow_up changed from release to none
  • Resolution set to fixed
  • Status changed from new to closed

Looks good on bewelcome.org.

Note: See TracTickets for help on using tickets.