Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1756 closed bug (fixed)

edit profile translation

Reported by: beatnickgr Owned by: crakk
Priority: trivial Milestone: 1.4
Component: BW Profile Keywords:
Cc:

Description

When i'm on a translation of my profile and i clic edit, it goes to the default one. I have to clic on the language i want to edit again. It should go directly to the language i want to edit.

Change History (23)

comment:1 Changed 6 years ago by lantti

Should be easy to make the edit links in profile point to the current profile language version of edit page. Just add $profile_language_code to the end of them?

comment:2 Changed 6 years ago by beatnickgr

I want to add, that if default language is greek and i save my acomodation in greek, changes are made correctly but i continue editing the english profile summary.

It should either :
1) stay on the acomodation of the language i'm editing, or
2) go to the profile of the language i just edited.

Last edited 6 years ago by beatnickgr (previous) (diff)

comment:3 Changed 6 years ago by mahouni

https://gitorious.org/jonbeda-rox/jonbeda-rox/commit/34ffe296b678b186e2f5117493d69acc43c9f125 In build/members/templates/profile.subcolumn_left.php you are removing the leading slashes :

<a href="/editmyprofile

in subcolumn_right.php it is still there.

I think on www.bewelcome.org both will work. But on my local installation it actually only works without the leading slash.

comment:4 follow-up: Changed 6 years ago by crakk

ok, I will remove the leading slash asap!

comment:5 in reply to: ↑ 4 Changed 6 years ago by mahouni

Replying to crakk:

ok, I will remove the leading slash asap!

great! please modify the ticket and set the milestone to 1.4.Thanks.

Do you have write access to push the code to the bewelcome develop branch on gitorious? Let me know if you need help ther Else just push your update to your repository, and I can merge it into the develop branch.

comment:6 Changed 6 years ago by mahouni

  • Owner set to mahouni
  • Status changed from new to assigned

It is on develop now: http://gitorious.org/bewelcome/rox/commit/6eb05321ea20dd15b58d96eddf90bd16ae58f5ee

Not yet on alpha, test locally for now.

comment:7 Changed 6 years ago by mahouni

  • Milestone changed from unassigned to 1.4
  • Owner changed from mahouni to crakk

comment:8 Changed 6 years ago by crumbking

The "edit profile" in the left sidebar should do the same as the links in the profile. So we should add it there, too.

comment:9 Changed 6 years ago by crakk

And in the menu when we select 'edit my profile'! I work on the menu and the side bar asap (will be done before saturday I hope).

comment:10 Changed 6 years ago by crakk

I think it will be okay tonight (Wednesday the 9th).

comment:11 Changed 6 years ago by crakk

Done, I used the $_SESSIONlang? variable for the top-menu one because I don't know where else I can find this info. What do you think? https://www.gitorious.org/jonbeda-rox/jonbeda-rox/commit/29b9897e62eddad39e18ced0a38a152d79baa355

comment:12 Changed 6 years ago by mahouni

hmm, the

$_SESSION['lang'] 

is the language in which the member is browsing the website. This is different from the language of the profile translation he might want to edit.

For the edit links directly on the profile fields it makes sense to use the active translation of the profile. But I vote for not touching the other two menu links for editting the profile. Because you can see them also when you are not on the profile page. In general we can assume that the member want to edit the main profile (in english). Keep it simple! Many people probably are alreay confused by different profile translation. -> accidently editing a non-english translation of the profile, and not finding their edits later on the profile, when they browse to the english main profile later.

Last edited 6 years ago by mahouni (previous) (diff)

comment:13 Changed 6 years ago by crumbking

I actually mean just the field in the profile view not the main menu

comment:14 Changed 6 years ago by mahouni

maybe there it would be okay. But that field is shown also when on other views like "my preferences", "comments", "profile visitors". So it would need a test, if it really is the profile view.

comment:15 Changed 6 years ago by jsfan

Deployed on alpha.

comment:16 Changed 6 years ago by shevek

Worked for me.

comment:17 Changed 6 years ago by crakk

The same modification on the left sidebar is missing (In the profile section under the picture). I have to deal with it today. I keep you posted.

comment:18 Changed 6 years ago by mahouni

  • Status changed from assigned to testing

comment:19 Changed 6 years ago by crakk

Hi Toni, can you please merge the change I made in https://gitorious.org/jonrox/jonrox. The difference is just that the left sidebar includes the language in the edit my profile link too.

comment:21 follow-up: Changed 6 years ago by crumbking

Works locally move to alpha

Last edited 6 years ago by crumbking (previous) (diff)

comment:22 in reply to: ↑ 21 Changed 6 years ago by midsch

  • Resolution set to fixed
  • Status changed from testing to closed

Tested on alpha with Chromium: "edit profile" from top and leftmenu always jump to the profil version of the "preferred language" choosen for the site. If this version doesn't exist, the page jumps to the editpage of the first/main profile language.

The "edit" buttons on fields jump to the fields of the choosen profil translation.

I think this was how it was supposed to work -> works.

comment:23 Changed 6 years ago by planetcruiser

tested ok, clicking "edit my profile" when viewing my profile in german leads me to the german edit form

Note: See TracTickets for help on using tickets.