Opened 6 years ago

Closed 5 years ago

#1761 closed unknown (fixed)

Replace split up label string in searchmembers with one string

Reported by: jsfan Owned by: sitatara
Priority: trivial Milestone: 2.1
Component: BW Search Keywords: easy
Cc:

Description

The notice shown when searching members while not logged in is currently split into three parts. This is hard to translate and should be replaced with one string containing two placeholders.

Change History (10)

comment:1 Changed 6 years ago by jsfan

  • Milestone changed from unassigned to 1.1

I've now merged the label around the number of additional results into just one string. The log in link is still a separate string.

comment:2 Changed 6 years ago by planetcruiser

where does this appear again, i can't find the original ticket. please always add a related ticket part on both ends if a ticket was forked off from another ticket.

also links to commits help code review and testing. ;) the more cross-linking the better.

the commit is here: https://gitorious.org/bewelcome/rox/commit/54192c1fcde491dcf45ade0f35fd3631ea4b1f6e

the page the string appears on is: http://alpha.bewelcome.org/searchmembers

related forum discussion: http://www.bewelcome.org/groups/60/forum/s2330-Translation_Anouncements#post14668

confirm with the translation team, but i would include the login link in the string. some languages put the verb in a sentence first, some at the end. also there is the brackets issue. in china and korea different brackets are used than in europe. currently this would still be untranslatable. i suggest to leave everything in one string:

something like:

%RESULT_COUNT% found (%LINK_START%log in%LINK_END% to see more results)

comment:3 Changed 6 years ago by jsfan

Feel free to fix it up or revert. I might not be able to attend to it before the release happens.

comment:4 Changed 6 years ago by jsfan

I am reverting this and re-assign it to the next release. Probably better to think about a clean solution.

comment:5 Changed 6 years ago by jsfan

  • Milestone changed from 1.1 to 1.2

comment:6 Changed 6 years ago by jsfan

  • Milestone changed from 1.2 to unassigned

Patch should probably be reworked once again. Taking it off the next milestone for now.

comment:7 Changed 5 years ago by shevek

  • Keywords easy added
  • Milestone changed from unassigned to 2.1
  • Owner changed from jsfan to sitatara
  • Status changed from new to assigned

comment:8 Changed 5 years ago by sitatara

  • Status changed from assigned to to_alpha

Replaced the split up string with the one string that is already in use on the new search page: https://gitorious.org/bewelcome/rox/commit/ddbb5ad6837152e3059c33e422804f7b3902db16

comment:9 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:10 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Code looks good. Hint on alpha is still fine. Closed as fixed.

Note: See TracTickets for help on using tickets.