Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1770 closed improve feature (fixed)

Add a number behind messages in header sub navigation while having unread messages

Reported by: crumbking Owned by: mahouni
Priority: major Milestone: 1.3
Component: BW Layout Keywords:
Cc:

Description (last modified by jsfan)

  • Issue: If you log in and do not visit the personal start page you can miss important information through messages.
  • Solution: Add a number behind "messages" in header subnavi while having unread messages. Add some style like bold/colour to catch your eye.
  • Additional: Add some style like bold/colour on the personal start page. Maybe we simply change the inactive tab colour of the message counter from grey to black colour.

Change History (17)

comment:1 Changed 6 years ago by beatnickgr

  • Priority changed from major to critical

when we are already in bewelcome.org/messages we should be able to see:

-which messages are unread (bold)

-which messages have been answered (with a left arrow).

-which messages have been forwarded (with a right arrow).

i switch to critical, because people might be missing some unread messages.

Last edited 6 years ago by beatnickgr (previous) (diff)

comment:2 Changed 6 years ago by mahouni

  • Owner set to mahouni
  • Priority changed from critical to major
  • Status changed from new to assigned

code is ready, I will add this ticket to one of the next milestones

comment:3 Changed 6 years ago by mahouni

The function was already there, but there was a bug. The message has been marked as read just after the Sender has sent the message and was directed to url /message/77/sent. To get the number of unread messages I had to initialize a Rox class in tools/page/roxlayout.page.php. I don't like that, but haven't found another work around. Also using $_SESSIONIdMember? isn't really recommended, but I just copied that from other lines of that fi: le. I don't know if it would be possible to use getloggedInMember() there.

https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commit/9271d2e4670834e15509fb78816689f9c4508c26

To test locally, you'll have to set the status of the message in the db table to "Sent":

UPDATE messages SET Status='Sent' WHERE id=77;
Last edited 6 years ago by mahouni (previous) (diff)

comment:4 Changed 6 years ago by mahouni

  • Milestone changed from unassigned to 1.3

merged into develop:
https://gitorious.org/bewelcome/rox/commit/763040e874bcdd549915dcb86b1c3d2ddd2c9787

and added to milestone 1.3. (with see topic about 1.3 on the mailing list)

comment:5 Changed 6 years ago by shevek

Could someone please send me a message on BeWe?? (I don't like to create a test account...)

comment:6 Changed 6 years ago by shevek

Thanks crumbking. I see a counter now.

comment:7 follow-up: Changed 6 years ago by shevek

Seems that there are still messages that are set to read directly. I should see two unread messages but I have only one. The message list reflects that.

comment:8 in reply to: ↑ 7 Changed 6 years ago by mahouni

Replying to shevek:

Seems that there are still messages that are set to read directly. I should see two unread messages but I have only one. The message list reflects that.

let' test more on that... I ' ll send another test message to shevek and crumbking. Please also check if both messages were sent from alpha.bewelcome? Was there a reply or only new messages? When were the messages sent, respectively when has the new code been deployed?

comment:9 Changed 6 years ago by shevek

Okay, thought it doesn't matter where the message was sent from. Mails arriving from alpha work fine. Counter is updated as you switch between pages. Good to see that the counter's back.

comment:10 Changed 6 years ago by jsfan

Deployed on alpha.

comment:11 Changed 6 years ago by shevek

Nice. If you send a message from alpha the message counter shows up on www as well. That might lead to some confusion so please don't do it ;-)

comment:12 Changed 6 years ago by jsfan

  • Description modified (diff)

comment:13 Changed 6 years ago by jsfan

  • Description modified (diff)
  • Summary changed from Add a nummer behind messages in header subnavi while having unread messages to Add a number behind messages in header sub navigation while having unread messages

comment:14 Changed 6 years ago by jsfan

  • Description modified (diff)

comment:15 Changed 6 years ago by shevek

Exchanged several messages with other members using alpha to send messages and always got a message counter. Seems fixed.

comment:16 Changed 6 years ago by jsfan

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks good to me as well. Closing.

comment:17 Changed 6 years ago by planetcruiser

tested locally - works. really nice improvement! :)

Note: See TracTickets for help on using tickets.