Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1775 closed improve feature (fixed)

Settings for thread/post in forum need to be more visible

Reported by: jsfan Owned by: shevek
Priority: minor Milestone: 1.4
Component: BW Forum Keywords: 1.4 1.5
Cc: planetcruiser, mistersquiggle@…, james.oder.dave@…

Description

Issue:

  • The visibility settings and tags for forum posts (or threads if first post) are currently hidden behind an inconspicuous word link which expands the form.

Solution:

  • The setting should either be displayed by default or the link modified in such a way that it is obvious that it can be expanded.

Change History (14)

comment:2 Changed 6 years ago by JonJon

  • Cc mistersquiggle@… added
  • Owner set to JonJon
  • Status changed from new to accepted

comment:3 Changed 6 years ago by James_Oder_Dave

  • Cc james.oder.dave@… added

comment:4 Changed 6 years ago by shevek

  • Keywords 1.4 1.5 added
  • Owner changed from JonJon to shevek
  • Status changed from accepted to assigned

I prepared a fix that uses a slightly different approach than the one discussed in the thread.

Now regardless of edit, reply or new post the visibility box below a thread is always there.

Forum: If you start a new thread it defaults to 'Members Only'. If you want to post to the world you have to do that on purpose.

Groups: A new thread will also default to 'Members Only' if the group setting for visibility is not set to 'Group Only'.

All subsequent posts inherit from the first one. And can be set to any lower level where the order of levels is 'World', 'Members Only', 'Group Only'.

comment:5 Changed 6 years ago by mahouni

I tested it a little bit. The dropdown boxes and visibility options seem to work. But I think there is a problem, for example if you set the visibility of the post to "world" and the reply with "member only" or "group only" posts. The replies all have visibility "world".

I will test more in the next days.

Last edited 6 years ago by mahouni (previous) (diff)

comment:6 Changed 6 years ago by shevek

While merging the code with develop I used code from develop that set the visibility fixed to the ThreadVisibility?. Changed that back to my implementation.

Should work with this commit included: https://gitorious.org/~thisismeonmounteverest/bewelcome/thisismeonsentis-rox/commit/1163fa8f75321ad91e3c1f64681a7e9d603956f0

comment:7 Changed 6 years ago by mahouni

  • Milestone changed from unassigned to 1.4
  • Status changed from assigned to local_testing

comment:8 Changed 6 years ago by shevek

All operations show the visibility dropdown now. Additionally the default value doesn't exist anymore (as it was never clear which one that would be).

For forum posts members only is preselected for group posts it is groups only.

comment:9 Changed 6 years ago by crumbking

cool works.

Minor thing: let's remove "Choose Visibility" The headline is "Visibility" and that's enough I think. It's a drop down. So everything is clear.

comment:10 Changed 6 years ago by shevek

Removed the 'Choose visibility' so that it matches the Language box. Found a spurious '</select>' and removed that as well.

(Would like to have these drop down boxes the same size... and looking good.)

Commit: https://gitorious.org/bewelcome/rox/commit/c43a851c33355b42f57782ecff476015d91f4cc5

Please check again.

Last edited 6 years ago by shevek (previous) (diff)

comment:11 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

Deployed on alpha. Please test.

One change to the comment 3 was done, though. Default for groups is groups only regardless of the groups settings.

comment:12 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:13 Changed 6 years ago by mahouni

  • Resolution set to fixed
  • Status changed from testing to closed

works great!

comment:14 Changed 6 years ago by planetcruiser

tested ok, i see the visibility select without unfolding

but like mentioned at the end of http://trac.bewelcome.org/ticket/1838#comment:22 usability experts recommend selects only when there are too many options for radio buttons: http://baymard.com/blog/drop-down-usability - but that's for another time. ;)

Note: See TracTickets for help on using tickets.