Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1783 closed improve feature (fixed)

Profile: Birth date hidden means age hidden

Reported by: shevek Owned by:
Priority: major Milestone: 1.2
Component: BW Profile Keywords:
Cc:

Description

In the preferences a checkbox enables the member to hide his/her birthday but the birthday is never shown on the web site anyway.

What is triggered by the checkbox is if the age is shown on the profile and if the age range can be used in a search.

The checkbox should be moved below birth date and be labeled 'Hide age on profile and in search'.

Attachments (1)

fix1783.png (1.4 KB) - added by shevek 6 years ago.
Suggested fix

Download all attachments as: .zip

Change History (25)

Changed 6 years ago by shevek

Suggested fix

comment:1 Changed 6 years ago by shevek

Hi, I just fixed this locally.

See image for the proposed changes:

Suggested fix

HideAge? would need to be put into the words table and at that time 'birth date' could be changed to 'Birth date' as well.

comment:2 Changed 6 years ago by planetcruiser

why not just change the label of the existing checkbox to "Hide age"? this would still need a new word code "HideAge?" however, because "Hidden" is in use in many other places.

"birth date" is correct in the live db. the words table in the test db is massively behind, so always check on live first.

comment:3 Changed 6 years ago by shevek

I'm all in for loose coupling :-)

The current implementation adds an additional HideAgeInfo? below the checkbox to tell the member where the age is hidden. As this checkbox affects the search as well, I think that info is necessary.

comment:4 Changed 6 years ago by planetcruiser

  • Milestone changed from unassigned to 1.2

so you implemented differently to what you suggested? hm.. ok.

i'll address things from your mail here, to keep things transparent:

alpha runs on the live db (this needs changing). so translations on alpha are automatically live. after a possible alpha/live db split this probably needs to be synced manually somehow. not sure.

looks like you skipped the ticket queue and committed this to develop already, despite the ticket not being assigned to the current milestone:

i will have to either shoot a puppy now or revert. ;) well, i'm sure the korean cooks around here have good use for dead dog meat, so i'll go for option A, assign to 1.2 and redeploy alpha so we can look at this.

comment:5 Changed 6 years ago by jsfan

And I repent in sackcloth and ashes for now initiating the newbie correctly... ;)

comment:6 follow-up: Changed 6 years ago by planetcruiser

wording suggestion by shevek:

HideAge: Hide Age
HideAgeInfo: If checked your age isn't shown on your profile and in
the search results. Additionally a search for age will not find your
profile.

my suggestion:

Birth date: *      [...............]         [ ] Hide age

                   Birth date is used to calculate your age only and will
                   not be shown to anyone. If "Hide age" is checked your age
                   won't be revealed on your profile or in searches.

"Hide age: [ ] Yes" is bad usability IMHO, because there is no "No" option

even more usable would be to make birth date optional altogether, with a note: "If given, your age will be displayed on your profile and available in searches". but this would mean further changes and break backward compatibility, so let's not do this. ;)

this makes me wonder why birth date is mandatory. legal reasons?

comment:7 in reply to: ↑ 6 Changed 6 years ago by shevek

my suggestion:

Birth date: *      [...............]         [ ] Hide age

                   Birth date is used to calculate your age only and will
                   not be shown to anyone. If "Hide age" is checked your age
                   won't be revealed on your profile or in searches.

I like the text you propose better than mine but disagree on the next:

"Hide age: [ ] Yes" is bad usability IMHO, because there is no "No" option

People that use websites are used to that stuff. Your argument would also mean that 'Hidden' can't be used as checkbox text as there is no 'Unhidden'.

I put it on different row on purpose as the connection between the two things birth date and hide age is only a technical one. Especially as the birth date is mandatory I didn't want to have an not mandatory feature on the same row.

So lets combine these:

Birth date: *      [...............]         
Age visibility:    [ ] Hidden
                   If "Hidden" is checked your age won't be revealed on your profile or in
                   searches.

this makes me wonder why birth date is mandatory. legal reasons?

Not necessarily. But during signup there is a check that you're at least 18. It is compulsory there. So I guess it just stays that way :-)

comment:8 follow-up: Changed 6 years ago by planetcruiser

hm, this still doesn't nail it for me. if you look at the "Contact information" tab in the same form, you see that the "Hidden" (should really be called "Hide") is always in the same place.

i see the birth date and "Hide age" directly linked, that's why i would put them in one line.

anyway, to emphasize the age display, how about this:

Birth date: *    [...............]  Always hidden
Age:             (*) Show ( ) Hide

or

Birth date: *    [...............]  Always hidden
Age:             [ ] Hidden

i added "Always hidden" to match the email field. show/hide in variant 1 are radio buttons.

like this it doesn't need more explanation underneath i think. our forms are pretty minimalist everywhere, so if we start introducing explanations here, we would need to do it throughout to stay consistent. which would be a good thing to have, but the work involved for translators and coders is not to be underestimated. also we have more pressing issues i think.

Your argument would also mean that 'Hidden' can't be used as checkbox text as there is no 'Unhidden'.

i disagree. "hidden" is a property, "yes/no" is a choice. i can't linguistically express this properly right now, but your comparison doesn't work for me.

comment:9 Changed 6 years ago by planetcruiser

sorry, i just realised that my second variant is almost identical to your last suggestion. so, are you okay with adding "Always hidden", dropping "visibility" and the help text?

comment:10 Changed 6 years ago by crumbking

We could shorten the birth field and then:

Birth date:*  [...........] Always hidden    Age: [ ] Hidden

No help text, please.

comment:11 follow-up: Changed 6 years ago by crumbking

btw: always do a keyword search before opening tickets: duplicate: #1168:

" ...or the tick box should be re-labelled 'hide age' "

Might be another option.

Last edited 6 years ago by crumbking (previous) (diff)

comment:12 in reply to: ↑ 11 Changed 6 years ago by shevek

btw: always do a keyword search before opening tickets: duplicate: #1168:

I did that but failed to find anything so I raised a ticket.

comment:13 in reply to: ↑ 8 ; follow-up: Changed 6 years ago by shevek

hm, this still doesn't nail it for me. if you look at the "Contact information" tab in the same form, you see that the "Hidden" (should really be called "Hide") is always in the same place.

Right but only because there is something in front of it that it relates to.

Birth date: *    [...............]  Always hidden
Age:             [ ] Hidden

Okay that gives the information that the birth date is never shown on the site.

so if we start introducing explanations here, we would need to do it throughout to stay consistent.

:-) I added the string only because there is one for the profile picture as well.

Additionally in this case we should tell the members that a hidden age impacts the search feature as well. Which isn't obvious.

I agree that this means more work for the translation team but work for teams should never be a reason to keep a member informed.

comment:14 in reply to: ↑ 13 Changed 6 years ago by crumbking

Replying to shevek:

Birth date: *    [...............]  Always hidden
Age:             [ ] Hidden

This would do it. No need for further infos. Maybe add some more information in a hover tool tip.

I would suggest to remove:

<div class="small"><?= $words->get('HiddenAgeInfo'); ?></div>

Additionally in this case we should tell the members that a hidden age impacts the search feature as well. Which isn't obvious.

I agree that this means more work for the translation team but work for teams should never be a reason to keep a member informed.

There are more place the age is used and I believe the "edit profile" page should be as short as possible. It's not the place for long explanations. (maybe better in the FAQ, Wiki) It's not a matter of to much work for the translation team. But we really should keep the edit profile page without to much explanation.

What would be the wording of: Hiddenageinfo ?

comment:15 follow-up: Changed 6 years ago by globetrotter_tt

I agree, i think we don't need an explanation about hiding the age, so better remove the line

<div class="small"><?= $words->get('HiddenAgeInfo'); ?></div>

comment:16 in reply to: ↑ 15 Changed 6 years ago by shevek

The text for HiddenAgeInfo? would be 'If "Hidden" is checked your age won't be revealed on your profile or in searches.' I just updated alpha with it. The text only covers one line and is pretty small.

Which other places is the age used?

comment:17 Changed 6 years ago by globetrotter_tt

ok, looks good to me. i think we can close this ticket.

comment:18 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from new to closed

comment:19 Changed 6 years ago by planetcruiser

three people here didn't want a help text underneath, because it is inconsistent with the rest of the forms. we only added a help text to the image field, because we got frequent complaints from people uploading too large images.

but ok, i want to see this closed too. i shortened the text to a simple "Effects profile display and searches" (de: "Beeinflusst Profilanzeige und Suchanfragen") - says everything, right?

comment:20 Changed 6 years ago by shevek

1st) I answered a question what the my intented content for AgeHiddenInfo? would be. To be able to answer that I updated the text accordingly instead of submitting a change to hide it to develop.

2nd) Sorry but 'Effects profile display and search' is utter nonsense. No one without the knowledge how it effects would understand that. And it doesn't even have the feel of a sentence to me.

3rd) I disagree that the info isn't necessary as the 'normal' users doesn't know where the age is used. A lot of people probably don't know that there is an advanced search. So this would act as a pointer as well.

comment:21 Changed 6 years ago by planetcruiser

  • Resolution fixed deleted
  • Status changed from closed to reopened

let's reopen this beast.

we have two suggestions:

Birth date: *    [...............]  Always hidden
Age:             [ ] Hidden
                 If "Hidden" is checked your age won't be revealed on your profile or in searches.

vs.

Birth date: *    [...............]  Always hidden
Age:             [ ] Hidden
                 Don't reveal age on your profile or in searches.

(revised)

which one?

on my suggestion: we should keep things as short as possible. no need to mention the checkbox label again and the fact that it can be checked. i believe that less is more.

comment:22 Changed 6 years ago by shevek

So we argue between two of your suggestions? :-)

I agree that the second one is better.

comment:23 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from reopened to closed

ok, misunderstanding, i thought the first one was your suggestion. changed the text to the second suggestion. done, finally! thanks for fixing this and standing by until now.. :)

comment:24 Changed 6 years ago by shevek

Had a discussion yesterday why so many people have there age hidden on BW :-) Well, hopefully the amount of new members that hide there age will drop now...

Note: See TracTickets for help on using tickets.