Opened 6 years ago

Closed 6 years ago

#1793 closed improve feature (fixed)

Refactor "Add Note" Page

Reported by: midsch Owned by: shevek
Priority: minor Milestone: 1.6
Component: BW Profile Keywords: notes, rox, refactor
Cc: crumbking

Description (last modified by crumbking)

This ticket is about moving the old mycontacts to rox build/members as notes.

Related tickets:

Change History (64)

comment:1 Changed 6 years ago by midsch

comment:2 Changed 6 years ago by crumbking

I guess there is more to do than just the footer. It calls old profile layout files.

Maybe a whole move to:

build/members would be better.

Just checked it: There a are only 2 functions in bw/layout/mycontacts.php

I would create the pages. We need 2 views: Notes overview and the notes add/update page for every member.

If someone help with the logic I guess we could get in pretty fast moved ...

comment:3 Changed 6 years ago by midsch

In the meantime I've had a look on the notepage as well: If you start with adding a note, you'll end up in weird old pages like https://www.bewelcome.org/bw/viewcomments.php?cid=32499 ... But besides the "add note" link there is no access to the notes anywhere unless you make a note on profile and access it via "show my notes" on the profile with the link.

If "notes" shall become a usefull feature https://www.bewelcome.org/bw/mycontacts.php must be accessible via own profile sidemenue and "my account" main menu.

It doesn't look to difficult to solve (I'd volunteer for testing), but maybe we should try to find out how many notes are actually stored (in the last year). If the feature isn't used right now, we're maybe better off with disabling the "add note"-link and wait for a rewrite of profiles and add a note feature there. (I myself would like to see storage space for mail templates, drafts and other general stuff their as well.)

comment:4 Changed 6 years ago by crumbking

  • Owner set to crumbking
  • Status changed from new to assigned

comment:5 Changed 6 years ago by planetcruiser

  • Description modified (diff)

#1310 was closed as a duplicate of this

comment:6 Changed 6 years ago by planetcruiser

  • Description modified (diff)

comment:7 Changed 6 years ago by planetcruiser

  • Description modified (diff)

#1606 was closed as a duplicate of this

comment:8 Changed 6 years ago by planetcruiser

  • Cc bikepunk added
  • Description modified (diff)

#1429 was closed as a duplicate of this.

hehe, bikepunk reported the same thing 3 times ;)

comment:9 Changed 6 years ago by shevek

  • Milestone changed from unassigned to 1.5
  • Owner changed from crumbking to shevek

As I just moved the lost password code I take this one as well. Enough people asked for it.

comment:10 Changed 6 years ago by shevek

Move mynotes functionality into rox. Adding a new item 'mynotes' into the sidebar for own profiles. Reusing the existing link to old functionality for other profiles.

Commit: https://gitorious.org/~thisismeonmounteverest/bewelcome/thisismeonheiligenberg-rox/commit/61d5392b86e7cdf78bc6fcc7af6ec76e5ca16d03

comment:11 Changed 6 years ago by shevek

  • Status changed from assigned to local_testing

comment:12 Changed 6 years ago by jsfan

  • Milestone changed from 1.5 to unassigned

I'll unassign for now. This is not urgent and not in develop, yet.

comment:13 Changed 6 years ago by shevek

  • Milestone changed from unassigned to 1.6-proposed

Adding to 1.6.

comment:14 follow-up: Changed 6 years ago by shevek

  • Cc crumbking added; bikepunk removed

Commited to develop now: https://gitorious.org/bewelcome/rox/commit/368fe449c39297cb72f265649cc20d216dd8e762

Maybe someone could have a look at the css and give it some love?

Additionally I wonder if we need to be able to delete notes. Currently it is only possible to edit them.

comment:15 in reply to: ↑ 14 ; follow-up: Changed 6 years ago by crumbking

Replying to shevek:

Commited to develop now: https://gitorious.org/bewelcome/rox/commit/368fe449c39297cb72f265649cc20d216dd8e762

Maybe someone could have a look at the css and give it some love?

Really needed ;-) I will see what I can do.

Additionally I wonder if we need to be able to delete notes. Currently it is only possible to edit them.

+1!

Things I have seen so far:

  • time->better use 2 days ago format
  • menu: let's show it in the top or bottom menu (I would prefer bottom below trips)

Otherwise works so far. Is it backwards compatible? (Does it show old entries?)

comment:16 Changed 6 years ago by midsch

Der olle Footer ist weg, insofern könnte man das Ticket schließen.

  • Kategorien funktionieren komisch oder eher: nicht. Mir war erst unklar, dass ich das leere, unbeschriftete Feld für neue Kategorien benutzen muss. Habe ich eine Kategorie ausgewählt, kann ich dann per Pulldown noch zwischen existierenden Kategorien wechseln, aber keine neue anlegen (dann ist die leer Box aber besser gar nicht da), es sei denn, ich leere das Pulldown. Ändere ich die Kategorien so, dass keine Notes in der Kategorie mehr existieren, verschwindet diese Kategorie ganz. Das scheint mir alles etwas undurchdacht, suchen/sortieren kann man ja nach Kategorien auf seiner Übersichtsseite auch nicht.Vielleicht sollte man da aber bis zum Ersatz/Streichen? durch Welen die Finger von lassen - Könnte man auf der echten DB mal gucken, wieviele Notes es überhaupt gibt? Ob das jemand nutzt? Wenn das nur 3 von mir und 15 von Jean-Yves von vor 2008 sind, lässt sich das vielleicht auch deaktivieren ...
  • Löschen von Notes? Ja!

comment:17 Changed 6 years ago by midsch

Sorry, this was all in German ... translation:

The old footer is gone, so this ticket could be closed.

  • Categories for not work strange or not at all. For a user it's unclear that he needs to use the empty, undeclared box to introduce new categories. After doing this, it's possible to switch categories via pulldown (if there's more than one). New categories for existing notes can only be choosen after setting the pulldown to nothing. Unused categories just disappear ... The whole note-concept would need some love, as it's also impossible to sort or search for them. Maybe it's better to leave it untouched until a Welen replacement - Is it possible to search in the real DB how many of this notes exist? If the feature isn't used (except some pre-2008 notes by Jean-Yves or me;), it's maybe best to just deactivate this feature
  • Deletion of notes? Yes!

comment:18 Changed 6 years ago by shevek

The problem with the categories is that HTML doesn't offer a combo box so you can't just say fill in something or select from the drop down.

But as there is a ProfileCategoryInfo? we can tell people that they either have to enter a new one in the second field or select an existing one (we could put that into the drop down as well).

I know of at least one other member that uses the notes feature >:-)

I didn't include any fancy stuff as I just wanted to get rid of another old footer page and a lot of people asked to be able to add notes to profiles or have a contact list of a sort.

We can build on that with welen I suppose.

comment:19 in reply to: ↑ 15 ; follow-up: Changed 6 years ago by shevek

@crumbking:

Maybe someone could have a look at the css and give it some love?

Really needed ;-) I will see what I can do.

Thanks. Could you add a placeholder for the delete option as well?

  • time->better use 2 days ago format

I really would like to know when I made that note. We could probably drop the time.

  • menu: let's show it in the top or bottom menu (I would prefer bottom below trips)

If anywhere it should be in 'My Profile'.

Otherwise works so far. Is it backwards compatible? (Does it show old entries?)

Yes, it is. I did not add anything it is just the old mycontacts.php repackaged. That's with it access the mycontacts DB table as well.

Hmm, maybe we want to rename that table now...

comment:20 in reply to: ↑ 19 Changed 6 years ago by crumbking

Replying to shevek:

@crumbking:

Maybe someone could have a look at the css and give it some love?

Really needed ;-) I will see what I can do.

Thanks. Could you add a placeholder for the delete option as well?

  • time->better use 2 days ago format

I really would like to know when I made that note. We could probably drop the time.

  • menu: let's show it in the top or bottom menu (I would prefer bottom below trips)

If anywhere it should be in 'My Profile'.

Otherwise works so far. Is it backwards compatible? (Does it show old entries?)

Yes, it is. I did not add anything it is just the old mycontacts.php repackaged. That's with it access the mycontacts DB table as well.

Hmm, maybe we want to rename that table now...

Wonder if future developer gets confused with the build/note.

  • I redesigned /mynotes as I was running in design problems with long usernames, long categories ->hope you don't mind ;-)
  • fixed view while not logged in
  • added add, edit, delete buttons (delete buttons needs some functionality)
  • should we rename url to notes/ as we have comments/ relations/ etc ?
  • should I remove the grey box on /mynotes? would look like on /myvisitors...
  • notes->updated seems not to work here (shows always long ago)

Off topic: We need to fix the profile action menu for public profiles and ask to login.

comment:21 Changed 6 years ago by crumbking

Btw: There are 3 form views: yform, yform full, yform columnar.

go to members/henri/note/add

Start firbug and go to <form class="yform" name="addnote" method="post"> and switch the class. I like yform full. Currently implemented yform.

Which would you show?

comment:22 Changed 6 years ago by crumbking

  • Description modified (diff)
  • Summary changed from Wrong (old) footer on "Add Note"-Page to Refactor "Add Note" Page
  • Type changed from bug to improve feature

comment:23 follow-up: Changed 6 years ago by shevek

@crumbking: I'm mainly fine with the changesm but as I said I like to see the date when I wrote that note. A long ago or 6 years ago isn't enough for that.

Regarding yform: we should stay consistent with the rest of the profile if possible. That's why I had a ProfileNotesInfo? next to the fields. If that is anyway scrambled yform full looks good to me.

Actually I think we should add a grey box to /myvisitors :-) I stole the layout here: http://localhost/members/sitarane/groups

Mynotes is fine as it is the same as mypreferences and myvisitors and the menu items on the top of the profile side menu all start with /my.

Renaming the database table is a bit difficult as there are already existing notes and we need to switch in an instance. So I guess we need to keep things like they are.

I add the delete functionality.

comment:25 follow-up: Changed 6 years ago by midsch

Deletion via /members/kermit/note/delete works, but:

comment:26 in reply to: ↑ 25 Changed 6 years ago by crumbking

Replying to midsch:

Deletion via /members/kermit/note/delete works, but:

should work now (removed ago style)

  • On /members/kermit/note/delete I'd expect something like "cancel" (backwards with browser or closing the tab works as well).

Added this link (button)

Yeah there are quite a couple. We add them on alpha.

comment:27 Changed 6 years ago by crumbking

@Shevek:

After deleting a note and going back to the members profile (which note I deleted) the menu item stay in NoteEditMyNotesOfMember? status.

See: http://gitorious.org/bewelcome/rox/blobs/0006fb613418c2e72b729a96d689dd1db734e9b9/build/members/pages/member.page.php#line99

Could you check what's wrong?

Second issue:

/members/ieva/note/delete login with henri. While henri didn't wrote a note about ieva this page should simply jump back to /members/ieva.

comment:29 Changed 6 years ago by crumbking

  • Status changed from local_testing to to_alpha

comment:30 Changed 6 years ago by crumbking

@shevek: Could you change the sort order to new->old (date) on /mynotes? thx

comment:31 Changed 6 years ago by shevek

Actually they are sorted by category at the moment. I change that to something timeline sorting for now. Additionally use the same date formatting as on messages.

Commit: https://gitorious.org/bewelcome/rox/commit/b749969e45b9b12b716dd48fc650440fa6dd374b

comment:32 Changed 6 years ago by shevek

@crumbking: I'm not really happy with the fact that you ignore my comment #23. How do you tell the members now that they can either put something in the free field or select an existing category?

Last edited 6 years ago by shevek (previous) (diff)

comment:33 in reply to: ↑ 23 Changed 6 years ago by crumbking

Replying to shevek:

Regarding yform: we should stay consistent with the rest of the profile if possible. That's why I had a ProfileNotesInfo? next to the fields. If that is anyway scrambled yform full looks good to me.

I hope you mean the above? There is no consistence in the forms in the profile. Check add comment form, edit profile form or add relation form. All look totally different and I have seen a couple of problems in IE browsers.

We could go for a 50/50 split. Add yform columnar left and some explanation right. (than it would look like in the add comment section)

But I would say this is not needed as the form is kind of self explanatory if we write for:

ProfileNoteCategory?

Please choose a category or add a new category below.

ProfileNoteCategoryFree?

Add a new category:

Wouldn't that work?

comment:34 Changed 6 years ago by shevek

I had the comments page in mind where we had the left and right columns.

But I agree here it is probably best to use yform full.

Instead of additional explanatory text maybe the first option in the drop down could state that you either select one of the existing categories or enter one below.

comment:35 Changed 6 years ago by shevek

Added the default drop down option and fixed two problems:

https://gitorious.org/bewelcome/rox/commit/211ed9763282922d1fbadeff568a22409b229280

comment:36 Changed 6 years ago by dima42

in members/pages/member.page.php:99 you have a variable note that might not be declared

comment:37 Changed 6 years ago by shevek

Thanks for doing the code review. Fixed (removed spurious debug output):

https://gitorious.org/bewelcome/rox/commit/7e7ce3d8d98b1a88ee4b118b01ee52596fd1ab87

comment:38 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:39 follow-up: Changed 6 years ago by crumbking

Small usability flaw. After hitting the edit note button below the form. A successfull message shows up. Problem: below the form the buutton change from "edit" to "add" and the delete button is gone.

Solution after saving (add or edit) always a "edit" or "delete" button should show up.

comment:40 in reply to: ↑ 39 Changed 6 years ago by crumbking

  • Keywords notes rox refactor added; Footer broken link removed
  • Status changed from testing to needs_work

Replying to crumbking:

Small usability flaw. After hitting the edit note button below the form. A successfull message shows up. Problem: below the form the buutton change from "edit" to "add" and the delete button is gone.

Solution after saving (add or edit) always a "edit" or "delete" button should show up.

fixed with

comment:41 Changed 6 years ago by crumbking

  • Status changed from needs_work to local_testing

comment:42 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

Works. Back to alpha.

Fix to avoid that the buttons break in translation mode added: https://www.gitorious.org/bewelcome/rox/commit/cca9e234d982f0bcf2a3cd8318ba1f9839516e8a

Last edited 6 years ago by shevek (previous) (diff)

comment:43 Changed 6 years ago by midsch

http://alpha.bewelcome.org//members/$username/note/edit (Chromium) Version 25.0.1364.160 Ubuntu 12.10 (25.0.1364.160-0ubuntu0.12.10.1):

I can edit the note and change between existing categories, but if I fill the box for new categories, I get a warning and can't save the note with the new category: ProfileNoteCategoryUnclear?

And Words missing as well?

Everything else: creating, editing, deleting notes worked for me.

(And I don't know how to get back to a "needs work" status now.)

comment:44 Changed 6 years ago by shevek

Did the category dropdown show -Choose a category or enter one below- or did it contain a category you selected beforehand?

If both drop down and edit field contain something meaningful the ProfileNoteCategoryUnclear would be shown.

(If you want to get to rework from state 'to_alpha' you first have to clear for testing on alpha and then fail.)

comment:45 Changed 6 years ago by midsch

Ah, I see. Yes, it's working like you described. For me this feels not very usable, but I failed similar and mentioned this some days before and it is no show-stopper.

The usability flaw reported by crumbking 19 hours is still there - the fix isn't on alpha, right?

comment:46 Changed 6 years ago by shevek

The text in the category drop down could be made clearer like '-Either choose a category here or entere one in the text field below-'.

And of course the error message should tell you why there is an error. So that might help.

Fix will likely be deploy around midnight. So should be there tomorrow.

comment:47 Changed 6 years ago by crumbking

ProfileNoteCategoryUnclear: Could someone propose some wording for this error notice?

comment:48 Changed 6 years ago by shevek

'You have to either select a category from the category list or enter a new one. You did both please decide which one you want."

comment:49 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:50 follow-up: Changed 6 years ago by crumbking

  • added missing translations
  • while creating the error the buttons once again are not right once ;-)
  • also the new category is shown below the free catergory field after the error wich is kind of strange ;-)

Fix that later...

Rest seems to work.

comment:51 Changed 6 years ago by crumbking

Oh and wonder if we should translate the whole headlines:

  • Add / edit your private note about Username ?
  • My private notes

to be clear that it is just a note for yourself....

comment:52 in reply to: ↑ 50 Changed 6 years ago by shevek

  • added missing translations

Thanks.

  • while creating the error the buttons once again are not right once ;-)
  • also the new category is shown below the free catergory field after the error wich is kind of strange ;-)

I guess a spurious debug output. That needs to go. If I figure why the buttons are wrong I fix that as well.

comment:53 Changed 6 years ago by crumbking

  • addnote.column_col3.php#line88 Add in the check also vars (errors) and than it should work.

comment:54 follow-up: Changed 6 years ago by crumbking

  • Buttons in /mynotes break the line with long translations. I check that later

comment:55 Changed 6 years ago by shevek

The strange positioning of the free category was a wrong tag. Fixed the buttons as well.

Commit: https://www.gitorious.org/bewelcome/rox/commit/0635e1af81d114dc3f62edacac36536c12538987

comment:56 in reply to: ↑ 54 Changed 6 years ago by crumbking

  • Status changed from testing to needs_work

Replying to crumbking:

  • Buttons in /mynotes break the line with long translations. I check that later

http://gitorious.org/bewelcome/rox/commit/cefde12e2aa39fa75db35ed744ae117b65993270 fixed the Dutch language problems. Added some space between the button to not accidentally hitting the wrong buttons on touch screens.

comment:57 Changed 6 years ago by crumbking

  • Status changed from needs_work to to_alpha

comment:58 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha.

comment:59 Changed 6 years ago by crumbking

Works now.

Maybe a minor thing. While in editing mode you can hit the delete button. And you are asked if you really want to delete with a BACK button. Hitting this one you end up in /mynotes instead of getting back to the edit form. But this is no sooo important ;-)

What about comment 51? Opinions?

I guess we are done here?

comment:60 Changed 6 years ago by shevek

Never understood what that comment was about :-)

comment:61 Changed 6 years ago by crumbking

Well I mean should we add "private" to the headlines as these notes are private ones...

comment:62 Changed 6 years ago by shevek

That's probably a good idea.

comment:63 Changed 6 years ago by midsch

Viewed, added, edited and deleted comments -> works for me

Played around with the categories -> works for me

+1 for calling the notes "private" (= not to be read by someone else)

comment:64 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

Changed the English version. Done

Note: See TracTickets for help on using tickets.