Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1800 closed task (fixed)

OSM: remove console.log debug output

Reported by: planetcruiser Owned by: planetcruiser
Priority: major Milestone: 1.2
Component: BW Geo Keywords:
Cc: toub

Description

Issue:

  • Various scripts are dumping debug output to the JS console, e.g.:
    Search success: processing the results... searchmembers.js:164
    Parsing results... searchmembers.js:173
    Parsing XML response... BWMapSearchResult.js:25
    Number of results:2 BWMapSearchResult.js:56
    Adding the pager... searchmembers.js:178
    Reading the 2 points... BWMapSearchResult.js:101
    Combine points summaries when coordinates and accomodation is the same... BWMapSearchResult.js:117
    Space markers that have the same geo-coordinates... BWMapSearchResult.js:135
    2 points have been read. BWMapSearchResult.js:109
    Adding the 2 markers... searchmembers.js:204
    Hide layer group 1 (yes) BWGeosearchMapBuilder.js:172
    Hide layer group 3 (no) BWGeosearchMapBuilder.js:180
    Map succesfully loaded
    
  • This should not go into production

Solutions:

  1. Remove debug statements (quickest)
  2. Introduce debug level config switch and set it to "no debug"

Notes:

  • I assume this should be done last, once all other OSM tickets are closed

Change History (5)

comment:1 Changed 6 years ago by planetcruiser

  • Owner set to planetcruiser
  • Status changed from new to accepted

looking into adding a debug switch now

comment:2 Changed 6 years ago by planetcruiser

partly implemented via: #1805

comment:3 Changed 6 years ago by planetcruiser

comment:4 Changed 6 years ago by planetcruiser

  • Resolution set to fixed
  • Status changed from accepted to closed

wrapped remaining debug statements via:

add this to your rox_local.ini to see all js debug output:

[javascript]
debug = 1
info  = 1
warn  = 1
error = 1
log   = 1

deployed and tested on alpha - closing

comment:5 Changed 6 years ago by toub

Great, I love it!

Note: See TracTickets for help on using tickets.