Opened 5 years ago

Closed 5 years ago

#1802 closed bug (fixed)

Writing negative or neutral comment not possible when "We never met in real life" is ticked

Reported by: globetrotter_tt Owned by: crumbking
Priority: major Milestone: 1.7
Component: BW Profile Keywords: comments, references
Cc:

Description (last modified by sitatara)

When someone wants to write a negative or neutral comment and ticks the the box "We never met in real life" a javascript window appears saying: "Please do not write a Positive or Neutral comment to people you have never met in real life.

While it is good that positive comments in such cases are disabled, negative or neutral comments should be possible!

The text of the pop-up should be changed to "Please do not write a positive comment to people you have never met in real life!" too.


Related ticket: #257

Change History (12)

comment:1 Changed 5 years ago by crumbking

  • Milestone changed from unassigned to 1.3
  • Owner set to crumbking
  • Status changed from new to assigned

I think I fixed that locally.

Someone mixed negative and bad ;-)

BTW there is a javascript free version:
wordcode: NoPositiveComment_if_NeverMetInRealLife
... should become" Please do not write a Positive or Neutral comment to people you have never met in real life."

(only be visible if javascript is off)

comment:2 Changed 5 years ago by shevek

I wouldn't fix this as I don't think that negative comments for people that I never met are appropriate. Why would you leave a comment for someone you never met? Because s/he didn't show up or because s/he was rude. For a no show a neutral comment would be enough and for being rude the comments aren't really the right place.

comment:3 Changed 5 years ago by beatnickgr

There is this discussion going on http://www.bewelcome.org/forums/s3679-New_reference_system
Should this ticket be closed until we reach a consensus?

comment:4 Changed 5 years ago by crumbking

The fix is saved in a local branch so nothing will be changed till you guys reach some consensus. So let's leave it open.

But the question is still valid:

  • Should you be able to write negative comments to people you never met in real life?

I my opinion: Yes (spam, rude) A neutral comment would be too neutral for such cases ;-)

  • Should you be able to write positive/neutral comments to people you never met in real life?

Nat sure but we wanna encourage real life meetings. Get of the computer and meet in real ;-)

But you know just my opinion :-)

comment:5 Changed 5 years ago by crumbking

  • Milestone changed from 1.3 to unassigned

As this is still open to discussions I unassigned this ticket.

comment:6 Changed 5 years ago by sitatara

  • Description modified (diff)
  • Summary changed from Writing negative comment not possible when "We never met in real life" is ticked to Writing negative or neutral comment not possible when "We never met in real life" is ticked

We discussed this in the Safety Team. Please allow negative and neutral comments (but not positive ones) if the member ticks the checkbox "We never met in real life".

I changed the ticket description accordingly.

comment:7 Changed 5 years ago by crumbking

  • Milestone changed from unassigned to 1.7
  • positive and "We never met in real life ticked": Error
  • negative or neutral and "We never met in real life": comment should be saved

Fix ready.

comment:8 Changed 5 years ago by crumbking

  • Status changed from assigned to local_testing

comment:9 Changed 5 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:10 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha. Please test.

comment:11 Changed 5 years ago by shevek

Works with JS on and off.

comment:12 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.