Opened 6 years ago

Closed 4 years ago

#1813 closed improve feature (fixed)

Moderated groups: cannot decline prospective members

Reported by: beatnickgr Owned by: Tsjoek
Priority: minor Milestone: 2.6
Component: BW Group Keywords: moderated accept decline
Cc: shevek

Description

When a member requests to join a moderated group, the moderator has the only choices to "accept" him, or leave him pending in the "prospective members" list.

"Decline" and "Ban" options should be added.

Change History (25)

comment:1 Changed 6 years ago by beatnickgr

  • Summary changed from Cannot decline prospective members in moderated groups. to Moderated groups: cannot decline prospective members

comment:2 Changed 6 years ago by jsfan

  • Priority changed from major to minor

Please do only assign "major" to bugs that are likely to impact on a majority of members. If in doubt, default to lower priority and leave the decision to the developers.

comment:3 Changed 5 years ago by sitatara

  • Cc shevek added

I understand that this only affects very few groups but it is problematic in volunteer team groups since the list of prospective members grows longer and longer and no-one can ever be removed even if the application is actually rejected. There are also other problems with the list of prospective members:

  • It does not show when (date) the member requested group membership.
  • The group admin cannot see what the member wrote into the "Motivation to join the group" field before accepting the application. This field usually contains relevant information for the group administrator to decide if to accept the membership application or not. She/he should therefore be able to see this information.

Some of these problems also extend to the list of invited members. In case the invitation is not accepted by the member, they remain in the list forever. These invitations should either become invalid automatically after some time or group admins should be able to remove them manually. A date of the invitation should be visible. Another related problem when a member is invited: When the invitation is accepted, the member is not asked choose a setting for group notifications. Notifications are just set to "no" and very often that means: Invited members never become active in the group even after accepting the invitation.

comment:4 Changed 4 years ago by Tsjoek

  • Milestone changed from unassigned to 2.6
  • Owner set to Tsjoek
  • Status changed from new to assigned

comment:5 Changed 4 years ago by Tsjoek

  • Status changed from assigned to local_testing

https://www.gitorious.org/bewelcome/tsjoek-rox/commit/63c05bc310c41eddc5bb1f974d2c456f2e7d6c80

Fixes the original issue.
#2139 describes the missing motivation field, I added the missing date there
I made #2225 for the issues on invitations

comment:6 Changed 4 years ago by Tsjoek

Above mentioned fix, actually also fixes the banning feature, such that someone is now really banned in stead of just kicked.

comment:7 Changed 4 years ago by crumbking

  • Status changed from local_testing to to_alpha

tested the original problem. "Decline" and "Ban" options are added. Decline worked for me.

comment:8 follow-up: Changed 4 years ago by beatnickgr

i can't see the "decline" and "ban" in Athens Emergency group, there is only "accept"

http://beta.bewelcome.org/groups/837/memberadministration

comment:9 in reply to: ↑ 8 Changed 4 years ago by Tsjoek

Replying to beatnickgr:
This is not on beta yet, stay tuned!

comment:10 Changed 4 years ago by shevek

Deployed to alpha.

comment:11 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

comment:12 Changed 4 years ago by crumbking

There are groups members with more rights. You are not able (forum mods? safety?) to kick them out. Only message as group admin you get is "kick failed". We should better to have a more specific message. (failed because of forum mod)

comment:13 Changed 4 years ago by shevek

It should be possible to kick all members regardless of additional rights. Members with the additional rights won't be affected by the kick in the same way as other members but that doesn't matter.

comment:14 Changed 4 years ago by Tsjoek

If an action cannot be completed that needs to be reported to the one who took the action, ideally the invitation to the action is not even there. So if a groupadmin kicks someone who cannot be kicked out, that should not happen in the dark.

What is the definition of "members with additional rights"?

comment:15 Changed 4 years ago by shevek

More rights is defined by a combination of members_roles, roles, roles_privileges, privileges, privilegescopes (see Rights).

But a member with the role GroupsAdmin? can access the group regardless of being a member of the group or not so it should be possible to kick him/her.

comment:16 Changed 4 years ago by crumbking

see this group and thread: http://www.bewelcome.org/groups/62/forum/s10950-testing_team_volunteers____who_wants_to_stay_in_the_group_

I kicked out a lot members. I wasn't able to kick octobertales, fake51 and amnesiac84.

So they must have special rights, thought.

comment:17 Changed 4 years ago by Tsjoek

Am I right that this protection is mainly there for the cases where a poweruser is actually not really a member of a group but wants to monitor through notifications what's going on?

As noted already, pure functionally it doesn't really matter if (s)he gets kicked.

Normally there shouldn't be links that produce an error by definition, but at second thought, I'm not sure it's necessary to advertise to groupadministrators who are these powerusers, so the error message should stay then. Just as well I don't think the exact role needs to be in, so can we just distinguish between cannot remove poweruser and other reasons?

comment:18 Changed 4 years ago by shevek

Just checked and line 664 in groups.model.php checks for the ForumModerator? right. I think we should remove that. If a forum mod clashes with one group administrator in that way the discussion needs to be taken elsewhere.

comment:19 Changed 4 years ago by Tsjoek

It seems to be quite unclear how we want to proceed and it's not the original issue anyway. I propose to leave this as it is for now, collect opinions and make a separate ticket based on the outcome.

comment:20 Changed 4 years ago by crumbking

The power users are transparent for the public anyway (who does what wiki page). The error leaves the group admin back with the information the software is broken. But agree we should separate into a new ticket.

comment:21 Changed 4 years ago by Tsjoek

See #2233 for the discussion about kicking powerusers

comment:22 Changed 4 years ago by shevek

  • Status changed from testing to alpha

comment:23 Changed 4 years ago by shevek

  • Status changed from alpha to testing

comment:24 Changed 4 years ago by beatnickgr

Testing: I successfully kicked a prospective member (without special rights)

comment:25 Changed 4 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

This is okay

Note: See TracTickets for help on using tickets.