Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1823 closed unknown (fixed)

Switch "Show all forum posts / Only show topics from groups where I am member"

Reported by: mahouni Owned by: mahouni
Priority: major Milestone: 1.4
Component: BW Forum Keywords:
Cc:

Description

There are some discussions to reorganize the forum and groups.

One suggestion is to offer the possibility to show only topics from a group if the user is a member of that group.

This tickets adds a button on top of the forum which switches the setting "all forum topics / only topics from my groups"

There is no decision yet, anyway I created the ticket, to have a ticket number to refer to, when working locally on that patch.

Change History (62)

comment:1 Changed 6 years ago by mahouni

  • Status changed from new to assigned

Checkout this branch to test it: https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commit/282eb13f151c3aad362b70ad311fbaad7bd75453

It requires a new entry in the preferences db table:

INSERT INTO preferences(codeName, codeDescription, Description, DefaultValue, PossibleValues, Status) VALUES ('ShowMyGroupsTopicsOnly', 'ShowMyGroupsTopicsOnlyDes', 'ShowMyGroupsTopicsOnly description', 'No', 'No;Yes', 'Normal')

comment:2 Changed 6 years ago by mahouni

  • Component changed from unknown to BW Forum
  • Milestone changed from unassigned to 1.4

with the text of the button changing depending on the current setting, this patch is now ready for alpha too:
http://gitorious.org/~mahouni/bewelcome/mahouni-rox/commit/f3b6c252ec1f68855870e62f4a25c1e26a3bc0a6

adding to milestone 1.4

NOTE: with this ticket we are trying to solve the problem of the actual forum overhead. A general forum restructuring might be necessary. (that would be welenize...)

comment:3 follow-up: Changed 6 years ago by crumbking

Pretty cool! Could move the button into the sidebar? I mean we collect all actions there... Small issues:

  • forums/mygroupsonly I get the error:
  • Notice: Trying to get property of non-object in /home/crumb/webdev/bw/build/forums/forums.model.php on line 389

Not sure this is related:

Write a post just with "subject" and empty text field:

  • Notice: Undefined index: IdTitle? in /home/crumb/webdev/bw/build/forums/templates/editcreateform.php on line 117

comment:4 Changed 6 years ago by mahouni

Naaa, I would like to keep the button there. I see this as a transitively fix to deal with the forum overload until we have sth better. So people have the chance to reduce the topics to what they are probably more interested. I think in the sidebar it would be overseen ?

I could not reproduce your error messages, and haven't found an obvious bug in the code. Can you test that a bit more, what causes this warnings.

But found another fatal error if you are not logged in and use the url forums/mygroupsonly (shouldn't happen normally, as it isn't linked, but anyway, it should be dealt with that)

comment:5 follow-up: Changed 6 years ago by crumbking

Notice: Trying to get property of non-object in /home/crumb/webdev/bw/build/forums/forums.model.php on line 385
Sorry :(

BeWelcome has just suffered an error of some magnitude (i.e. we cannot show you the page you were looking for and something went wrong as we looked for it), which is why you are looking at this error message. We apologise for the inconvenience many times, and humbly request that you send the address of this page to us through the feedback (and hopefully that is not the page that brings up this error ...).
Last edited 6 years ago by crumbking (previous) (diff)

comment:6 in reply to: ↑ 3 Changed 6 years ago by mahouni

Write a post just with "subject" and empty text field:

  • Notice: Undefined index: IdTitle? in /home/crumb/webdev/bw/build/forums/templates/editcreateform.php on line 117

new ticket for a later milestone: #1890

comment:7 in reply to: ↑ 5 Changed 6 years ago by mahouni

Replying to crumbking:

  • this error shows up:
    Notice: Trying to get property of non-object in pathToROX/build/forums/forums.model.php on line 385> 
    

That seems to work now. If someone else has the same problem let me know.

comment:8 Changed 6 years ago by mahouni

moved button to the right side

works for me locally, ready for alpha

comment:9 Changed 6 years ago by shevek

Button definitely moved locally for me as well.

comment:10 Changed 6 years ago by jsfan

Deployed on alpha.

comment:11 follow-up: Changed 6 years ago by shevek

Button is there. But unfortunately not working correctly.

As soon as you use the paginator the list starts showing wrong results.

Here's what I did: Switching to My groups only (while retaining the preference to show all forum topics).

The paginator shows 32 pages instead of some 240. Click on page 31. The paginator shows 243 again. URL is http://alpha.bewelcome.org/forums/mygroupsonly/page31/

comment:12 follow-up: Changed 6 years ago by shevek

At least once I managed to get the following URL http://alpha.bewelcome.org/forumsmygroupsonly/page1/ which lead to a redirect to the main page.

If you're on page 200 with all forum posts and switch to group only it is unlikely that you will see as many pages. The system doesn't really cope with that.

comment:13 in reply to: ↑ 11 Changed 6 years ago by mahouni

Replying to shevek:

Button is there. But unfortunately not working correctly.

As soon as you use the paginator the list starts showing wrong results.

Here's what I did: Switching to My groups only (while retaining the preference to show all forum topics).

The paginator shows 32 pages instead of some 240. Click on page 31. The paginator shows 243 again. URL is http://alpha.bewelcome.org/forums/mygroupsonly/page31/

That should be fixed with http://gitorious.org/bewelcome/rox/commit/c18db4435ae7f5dab06dc971a4b69f3c515b3148

comment:14 in reply to: ↑ 12 Changed 6 years ago by mahouni

Replying to shevek:

At least once I managed to get the following URL http://alpha.bewelcome.org/forumsmygroupsonly/page1/ which lead to a redirect to the main page.

If you're on page 200 with all forum posts and switch to group only it is unlikely that you will see as many pages. The system doesn't really cope with that.

Will fix this by using the button only on page 1 of the forums.

comment:15 follow-up: Changed 6 years ago by shevek

Button disappears on page 2 but doesn't reappear on page 1.

Last edited 6 years ago by shevek (previous) (diff)

comment:16 follow-up: Changed 6 years ago by planetcruiser

the preferences setting introduced for this has several usability issues. it currently states:

Test - Show only posts to my groups on the forum first page

(*) No - Show all forum posts
( ) Yes - Show only posts to my groups

    If set to Yes you will only see posts to your groups
    when you select 'Forum' from the explore menu.

issues:

  • the setting also affects the "Latest posts" on the "main" page. the wording does not reflect this.
  • the settings name and options are too long, needs to be straight to the point.
  • making this a yes/no question is inconsistent with the button on the forums page, options should be something like groups/all.
  • all settings apart from "Advanced features" list "Yes" first, we should keep it that way (if this stays a yes/no setting).
  • hyphens instead of commas are used after yes/no. use commas or even better: move details to the description.

in summary, my suggested wording:

Latest forum posts filter

(*) All
( ) My groups

    If set to *All*, all forum posts will be shown. If set to
    *My groups*, lists with latest posts will only show posts
    to groups that you are a member of.

it's not ideal that this setting is already visible on www, but because we are currently testing on the live db it's probably not easily avoidable. to make things look a little bit less "developy" on the live site, i removed the "Test -" for EN, NL, IT and added this to the settings description:

"Work in progress: This setting is currently under development and will be activated shortly."

comment:17 in reply to: ↑ 15 ; follow-up: Changed 6 years ago by mahouni

Replying to shevek:

Button disappears on page 2 but doesn't reappear on page 1.

To state more precisely: The button only appears on the forum entry page -> only if the url equals "www.bewelcome.org/forums".

comment:18 in reply to: ↑ 16 ; follow-up: Changed 6 years ago by mahouni

Replying to planetcruiser:

in summary, my suggested wording:

Latest forum posts filter

(*) All
( ) My groups

    If set to *All*, all forum posts will be shown. If set to
    *My groups*, lists with latest posts will only show posts
    to groups that you are a member of.

@planetcruiser: I updated the translation workpage according to your suggestion. http://trac.bewelcome.org/wiki/translation_1.4

comment:19 Changed 6 years ago by mahouni

  • Status changed from assigned to local_testing

ready for alpha

Last edited 6 years ago by mahouni (previous) (diff)

comment:20 in reply to: ↑ 17 ; follow-up: Changed 6 years ago by shevek

Replying to shevek:

Button disappears on page 2 but doesn't reappear on page 1.

To state more precisely: The button only appears on the forum entry page -> only if the url equals "www.bewelcome.org/forums".

But no one will understand that technicality. So forums/page1 should show the button as well.

PS: I already tested locally otherwise I couldn't have written comment 15. :-)

comment:21 in reply to: ↑ 18 Changed 6 years ago by planetcruiser

Replying to mahouni:

@planetcruiser: I updated the translation workpage according to your suggestion. http://trac.bewelcome.org/wiki/translation_1.4

oh, that was easy. :) i updated translations for EN and added DE.

comment:22 in reply to: ↑ 20 Changed 6 years ago by mahouni

  • Status changed from local_testing to testing

Replying to shevek:

But no one will understand that technicality. So forums/page1 should show the button as well.

forums/page1 should redirect to forums IMO

-> new ticket [1912]

comment:24 follow-up: Changed 6 years ago by shevek

  • Status changed from testing to needs_work

What about ticket #1912 then?

comment:25 Changed 6 years ago by shevek

  • Status changed from needs_work to testing

Tested locally can be deployed to alpha.

comment:26 follow-up: Changed 6 years ago by crumbking

Not sure someone mentioned above but while on page 2/3 .. I miss the switch button :-)

I would expect if on on page 2/3 while hitting the switch button to forwarded to page 1.

comment:27 follow-up: Changed 6 years ago by midsch

  • Status changed from testing to needs_work

According to trac status, this is already on alpha, so I've tested it on alpha with Chromium Version 23.0.1271.97 Ubuntu 12.10 (23.0.1271.97-0ubuntu0.12.10.1)

  • From forum to http://alpha.bewelcome.org/forums/mygroupsonly - I've got 3 pages and ">>" button. The last one is without function, klicking on "3" i got page 3 of _ALL_ forum post pages and the according "Show only posts to my groups", but hitting a page button > 3 returns an empty page.

comment:28 Changed 6 years ago by jsfan

  • Status changed from needs_work to to_alpha

comment:29 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:30 follow-up: Changed 6 years ago by sanderr

I can confirm midsch's findings on FF. Works on /forums, but not on /forums/.

comment:31 follow-up: Changed 6 years ago by globetrotter_tt

  • Status changed from testing to needs_work

I can also confirm this. Can't the button be placed in the forum header?

comment:33 in reply to: ↑ 24 Changed 6 years ago by mahouni

Replying to shevek:

What about ticket #1912 then?

won't fix ( at least not in mileston 1.4)

comment:34 in reply to: ↑ 26 Changed 6 years ago by mahouni

Replying to crumbking:

Not sure someone mentioned above but while on page 2/3 .. I miss the switch button :-)

I would expect if on on page 2/3 while hitting the switch button to forwarded to page 1.

Maybe I will add it. Since the forwarding is always to the main forums page after I have reworked on the patch. Low priority though.

comment:35 in reply to: ↑ 27 Changed 6 years ago by mahouni

Replying to midsch:

According to trac status, this is already on alpha, so I've tested it on alpha with Chromium Version 23.0.1271.97 Ubuntu 12.10 (23.0.1271.97-0ubuntu0.12.10.1)

  • From forum to http://alpha.bewelcome.org/forums/mygroupsonly - I've got 3 pages and ">>" button. The last one is without function, klicking on "3" i got page 3 of _ALL_ forum post pages and the according "Show only posts to my groups", but hitting a page button > 3 returns an empty page.

It wasn't deployed on alpha.

comment:36 in reply to: ↑ 30 Changed 6 years ago by mahouni

Replying to sanderr:

I can confirm midsch's findings on FF. Works on /forums, but not on /forums/.

That was fixed locally, but not yet deployed on alpha

comment:37 in reply to: ↑ 32 Changed 6 years ago by mahouni

Replying to crumbking:

At the moment I get a error of magnitude while visiting:

that has nothing to do with this ticket

comment:38 in reply to: ↑ 31 Changed 6 years ago by mahouni

  • Status changed from needs_work to local_testing

Replying to globetrotter_tt:

Can't the button be placed in the forum header?

good question...

done!

http://gitorious.org/bewelcome/rox/commit/951fea00b8f9cd831bba848a731e8f5966dee6b5

comment:39 Changed 6 years ago by shevek

Could we get the <h3> back in that case?

comment:40 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

Thanks.

comment:41 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:42 follow-up: Changed 6 years ago by shevek

I'm wondering if the button is too strict. I want to see posts to my groups and the forum posts. What I get with the button is either only posts to my groups or all.

Last edited 6 years ago by shevek (previous) (diff)

comment:43 in reply to: ↑ 42 Changed 6 years ago by mahouni

Replying to shevek:

I'm wondering if the button is too strict. I want to see posts to my groups and the forum posts. What I get with the button is either only posts to my groups or all.

Feel free to make it a three option button:
"only posts from my groups :: posts from my groups and no group posts :: all posts".
But I definitively won't do that, rather I would make it mandatory to select a group when writing a new topic. Forum topics outside of groups are either from people who

  • are too lazy to look for an appropriate group or
  • want to spam the members

comment:44 follow-up: Changed 6 years ago by crumbking

There is on issue on alpha: Login, go to preferences and save "filter all". Visit forum and switch via button to group only. Logout. Login again. Go to your preferences and the filter will be "group only". This should not happen. A preference is a preference and should't be changed.

Means you have a preference on the one side (see it as default state after login) and a switcher on the other side. (switches could be done several time in a session)

Last edited 6 years ago by crumbking (previous) (diff)

comment:45 in reply to: ↑ 44 Changed 6 years ago by shevek

Means you have a preference on the one side (see it as default state after login) and a switcher on the other side. (switches could be done several time in a session)

I agree on this one. The button should only affect the current display and not the future one. But I'd be happy to let the users decide what they like best.

Regarding the three way option, I ask as soon as the button is live for everyone.

comment:46 follow-ups: Changed 6 years ago by mahouni

  • I disagree. I prefer it as a persistent setting. It actually was not planned to appear in the preferences page. But it was not possible to have an active preferences, but not shown on the preferences page. BTW: the reverse order setting works the same way.
  • Another problem: if "show my group posts only" is set and I browse to a group overview page of a group I am not member of (e.g. Berlin), I can't see any posts and the messages is "There are no posts in this group yet. Maybe you want to start the first?". The message should be changed and inform that there might be posts, but you would need to join the group. And maybe later work on the redesign and for example show the number of members, new members, number of forum posts, new forum posts etc. on the group overview too. Or welenize soon.

comment:47 in reply to: ↑ 46 Changed 6 years ago by shevek

  • I disagree. I prefer it as a persistent setting. It actually was not planned to appear in the preferences page. But it was not possible to have an active preferences, but not shown on the preferences page.

Well, an inactive preference might work. Anyhow as I expect that we rearrange groups and forums soon, I wouldn't fight on this one.

  • Another problem: if "show my group posts only" is set and I browse to a group overview page of a group I am not member of (e.g. Berlin), I can't see any posts and the messages is "There are no posts in this group yet. Maybe you want to start the first?". The message should be changed and inform that there might be posts, but you would need to join the group. And maybe later work on the redesign and for example show the number of members, new members, number of forum posts, new forum posts etc. on the group overview too. Or welenize soon.

A similar problem is that the system tells you to login to see the posts even when you're logged in but you're not allowed to see the group content for some reason. Should be fixed but is unrelated here (couldn't find a ticket though).

comment:48 in reply to: ↑ 46 Changed 6 years ago by crumbking

Replying to mahouni:

  • I disagree. I prefer it as a persistent setting. It actually was not planned to appear in the preferences page. But it was not possible to have an active preferences, but not shown on the preferences page. BTW: the reverse order setting works the same way.

Well okay for now if no one else see this as a usability issue.

  • Another problem: if "show my group posts only" is set and I browse to a group overview page of a group I am not member of (e.g. Berlin), I can't see any posts and the messages is "There are no posts in this group yet. Maybe you want to start the first?". The message should be changed and inform that there might be posts, but you would need to join the group.

We should fix that. We have a group settings to show /don't show the group forum. Later we should discuss if you can write in a group forum only after joining a group (I would say yes) but the viability is clearly a bug and we should not introduce it with 1.4

comment:49 follow-up: Changed 6 years ago by shevek

I'm not a member of the group Berlin either but I can see posts. Something's weird there.

comment:50 in reply to: ↑ 49 Changed 6 years ago by mahouni

  • Status changed from testing to needs_work

Replying to shevek:

I'm not a member of the group Berlin either but I can see posts. Something's weird there.

But if you have the switch to "filter only posts to my group", you probably can't see the posts in on the Berlin group overview and discussion page.

I will fix that.

comment:51 Changed 6 years ago by mahouni

  • Status changed from needs_work to local_testing

local testing please, some chances to break something else :)
https://gitorious.org/bewelcome/rox/commit/a9230efc101fe46668e3aee925996a4c6addc933

comment:52 Changed 6 years ago by mahouni

minor issue: if you leave a group the forum posts still not showed on the redirected page afterwards. But I won't fix that.

comment:53 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

The fix works.

Two more observations that I think we don't need to fix but good to know them:

  • If you switch to groups only and no one ever posted in your groups (highly unlikely I guess) the recent forum posts list shows 'There are no posts in this group yet. Do you want to start a new one?' with a nice 'New topic' button underneath.
  • Poor moderators can never see there only there group posts as the button just doesn't do anything for them...

comment:54 Changed 6 years ago by jsfan

Just as a note on the latter... I reckon Welen would be better off having switchable roles, so that someone like a forum moderator is only moderator when deliberately switching into that mode. Kind of like putting on a uniform.

comment:55 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:56 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

@jsfan: I agree on that.

Code deployed on alpha works the same way as it did locally. Closed as fixed.

comment:57 Changed 6 years ago by shevek

Found something. With MyGroupsOnly active the ModOnly threads are shown in the list as well.

Luckily OctoberTales used one of the groups I'm a member of to test if #1869 ;-)

comment:58 Changed 6 years ago by shevek

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:59 Changed 6 years ago by jsfan

  • Status changed from reopened to to_alpha

I presume this is fixed. Was probably unrelated.

comment:60 Changed 6 years ago by jsfan

  • Status changed from to_alpha to testing

comment:61 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

That presumption was correct. Closed as fixed.

comment:62 Changed 6 years ago by planetcruiser

tested ok. button on /forums and preferences setting change filter setting

Note: See TracTickets for help on using tickets.