Opened 6 years ago

Closed 5 years ago

#1824 closed improve feature (fixed)

texts that should be translatable but aren't

Reported by: sanderr Owned by: sanderr
Priority: trivial Milestone: 1.9
Component: BW Internationalization Keywords:
Cc:

Description

As posted in http://www.bewelcome.org/forums/s3607/reply, the buttons below comments are not translatable, but they should be.

Reopen this bug and comment if there are more issues like this one.

Attachments (1)

hellousername.png (13.6 KB) - added by shevek 6 years ago.

Download all attachments as: .zip

Change History (37)

comment:1 Changed 6 years ago by sanderr

  • Status changed from new to assigned

Ehm.. the link should be http://www.bewelcome.org/forums/s3607 without the reply.

comment:2 Changed 6 years ago by abyssin

This is true as well of the button to send messages. Also, the title of the page that lists user’s messages can’t be translated. It says: "%'s Messages".

comment:3 Changed 6 years ago by sanderr

Found similar bugs in: debug/debug.page.php
gallery/templates/galleryimage.column_col3.php
gallery/templates/image.php
members/templates/mypreferences.column_col3.php

But there are LOADS of untranslated small words. Ideally we do them all, but that's a lot of work.

I'll try to dig and fix most of them.

Last edited 6 years ago by sanderr (previous) (diff)

comment:4 Changed 6 years ago by shevek

Good to see someone cares :-)

Unfortunately there is a lot of source code that isn't used anymore. So if you start digging and fixing you might do some unnecessary work.

comment:5 Changed 6 years ago by sanderr

Ah well... it's not too difficult to fix. Better fix them all now, and deprecate them later than to skip one.

comment:6 Changed 6 years ago by sanderr

Ticket 1826 is also about this. Closed that ticket and added it here.

comment:7 Changed 6 years ago by sanderr

Ok, so far I found (and fixed) issues in:

build/forums/templates/teaser.php
build/forums/templates/userbar.php
build/gallery/templates/image.php
build/groups/templates/groupscreation.column_col3.php
build/members/templates/addcomment.column_col3.php
build/members/templates/editprofile_form.php
build/members/templates/mypreferences.column_col3.php
build/messages/messagesbase.page.php
Last edited 6 years ago by sanderr (previous) (diff)

comment:8 Changed 6 years ago by sanderr

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:9 Changed 6 years ago by sanderr

  • Resolution fixed deleted
  • Status changed from closed to reopened

Added the following wordcodes

RemoveLanguage?
English: Remove language
Description: Remove language from profile

UserMessages?
English: %s's messages
Description: Header for user's messages

comment:10 Changed 6 years ago by abyssin

I think the solution created a new problem. When I send a message, after clicking on “Send message” on a user’s profile, the button that appears under the text field reads “reply” (idword=18029 in the translation manager) instead of “Send”, which means it isn’t only when replying to a message but also when starting a new conversation.

comment:11 Changed 6 years ago by sanderr

True enough. Thus the message should be more generic, like "send message" (ContactMember?). There is no word code for "send" only yet.

comment:12 Changed 6 years ago by mahouni

Hey sanderr,

I know ROX has a lot of magic, but I don't think these changes would have worked on your local installation of ROX, or did they? Please only push to develop if you have tested everything at least ten times. The tickets shouldn't be closed until they are deployed on alpha and tested by someone else than the one who has commited the code.

For testing it is important to have the links and description what should be tested:

On branch https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commit/e2228d0c0b36fb178166c1e67143fc1a2babb318 I fixed the missing $words and did some syntax formatting following http://trac.bewelcome.org/wiki/ProgrammingGuideline . That page needs a review, but replying to the questions in your mail to the mailing list:

  • Use <?php echo $foo->get(bar); ?> instead of <?=$foo->get(bar)?>
  • Sometimes it is better to keep the style of the page you are editing, for example if the echo <<<HTML and curly brackets {} are used.
  • The dot connecting strings is an operator and should therefore have spaces before and after it. Correct: $message = "You have " . $number . " friends";

The branch is not yet merged to develop, because this ticket should not be in milestone 1.2. So I don't know if is better to reverse the last commit and wait for 1.3 or fix it and keep it in the 1.2 release.

comment:13 Changed 6 years ago by planetcruiser

  • Cc jsfan added

reverted via https://gitorious.org/bewelcome/rox/commit/905fdc77c410c94f29d62d494ff2855b7ad556e2 - please recommit once 1.2 was released, if this ticket is accepted in 1.3 by the release coordinator (probably jsfan)

forum on alpha works again.

nice effort however. i didn't know there were so many things that can't be translated.

comment:14 Changed 6 years ago by pablobd

there is a header in http://www.bewelcome.org/verifymembers/verifiersby/username that needs translation

comment:15 Changed 6 years ago by sanderr

There's another: At the home page, You have the "Welcome back", "What's happening" and then the "Find a host option". The text in the search box is not translatable.

comment:16 Changed 6 years ago by jsfan

Deployed on alpha.

comment:17 follow-up: Changed 6 years ago by jsfan

@sanderr: It doesn't look like you have added these but I cannot confirm hat the three you mentioned last are missing. They exist as

HelloUserName
NotifyWhatsHappening
FindAHost
Last edited 6 years ago by jsfan (previous) (diff)

Changed 6 years ago by shevek

comment:19 in reply to: ↑ 17 Changed 6 years ago by shevek

HelloUserName
NotifyWhatsHappening
FindAHost

All three are used on /main but the tags for translation aren't where you'd expect them:

comment:20 Changed 6 years ago by shevek

The following words have been added for 1.3:

'AddLanguage'
'DeleteAlbumSure'
'ForumLastPost'
'NumberOfMembersVerifiedByUser'
'PlacesLoginToSeeMore'
'PlacesLoginToSeeOurMembers'
'RemoveLanguage'
'StartpageSearchMemberText'
'UserMessages'
'UserVerifiedByNumber'
Last edited 6 years ago by shevek (previous) (diff)

comment:21 Changed 6 years ago by jsfan

Deployed on alpha.

comment:22 Changed 6 years ago by crumbking

Could someone post the commits so that we are able to check /test the relevant places on alpha?

comment:24 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from reopened to closed

Okay tested on alpha. Seems to work. Just added some missing translations.

comment:25 Changed 6 years ago by jsfan

sanderr, is there a reason why you changed the word code

verifymembers_verifiedbynb

to

UserVerifiedByNumber

All translations would be lost if the word code was changed, so that should only be done with very good reason.

comment:26 Changed 6 years ago by sanderr

The reason to change this code is that I could not find a translation for

verifymembers_verifiedbynb

in the words table. And it wasn't used anywhere else, so that's the reason I changed the translation word.

comment:28 Changed 6 years ago by sitatara

  • Resolution fixed deleted
  • Status changed from closed to reopened

On the recent donations page: http://www.bewelcome.org/donate/list the headers of the table are not translatable.

comment:29 Changed 5 years ago by sitatara

  • Cc jsfan removed
  • Milestone changed from 1.3 to 1.9
  • Status changed from reopened to local_testing

Made table headers on recent donations page translatable: https://gitorious.org/bewelcome/rox/commit/80b0139d9dcb05d9a7a288d25d4f698080466e14

Please test locally.

comment:30 Changed 5 years ago by sitatara

  • Status changed from local_testing to to_alpha

comment:31 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:32 Changed 5 years ago by crumbking

I'm not sure but I guess this </tr> must be in the for loop:

https://gitorious.org/bewelcome/rox/blobs/80b0139d9dcb05d9a7a288d25d4f698080466e14/build/donate/templates/donate_list.php#line56

Otherwise it looks like huge whitespace on the list.

Tested with IE8/win7 while not logged in.

comment:33 Changed 5 years ago by shevek

The <tr> where fine. But as the table header was smaller now the table didn't fill the space anymore.

Changed width="100%" to style="width:100%".

Fixed on alpha.

comment:34 Changed 5 years ago by crumbking

Looks good. Maybe we align the table header content to the left as in the table body.

comment:35 Changed 5 years ago by shevek

I had to check in IE as Chrome shows them align to the left. The default for IE obviously differs from Chrome and there is no CSS in place. Unfortunately for the donations it is not easy to add one either.

comment:36 Changed 5 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

it's okay, nothing to worry to much about ;-)

Note: See TracTickets for help on using tickets.