Opened 6 years ago

Closed 6 years ago

#1837 closed bug (fixed)

Buttons break when translation string is too long

Reported by: globetrotter_tt Owned by: crumbking
Priority: major Milestone: 1.7
Component: BW Layout Keywords: layout, css,
Cc: crumbking

Description

Some css buttons break in the translated versions

For example check the public startpage and switch to russian.

Change History (21)

comment:1 follow-up: Changed 6 years ago by crumbking

Yeah I know this bug. Also in Dutch and other languages. I'm not sure for a first fast bugfix I suggest to find a shorter translation word. Maybe "Learn more" or something? Also the signup box is broken in a couple of languages. So as a fast fix ask in the translation announcement thread for shorter translation. If not we have to move the button somewhere else.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 6 years ago by globetrotter_tt

Replying to crumbking:

Yeah I know this bug. Also in Dutch and other languages. I'm not sure for a first fast bugfix I suggest to find a shorter translation word. Maybe "Learn more" or something? Also the signup box is broken in a couple of languages. So as a fast fix ask in the translation announcement thread for shorter translation. If not we have to move the button somewhere else.

I'd rather create a css button, that does not break.

comment:3 Changed 6 years ago by shevek

I didn't know 'take the tour' is that long in Russian :-)

Additionally to the fact that the button breaks (that happens if you reduce the size of the window below 800px as well by the way) some languages break the top nav (like Finnish with Volunteer rights).

comment:4 in reply to: ↑ 2 Changed 6 years ago by crumbking

  • Owner set to crumbking
  • Status changed from new to accepted

Replying to globetrotter_tt:

I'd rather create a css button, that does not break.

Yepp I introduced a new button with a (hopefully) crossbrowser button generator ;-)

Last edited 6 years ago by crumbking (previous) (diff)

comment:5 Changed 6 years ago by crumbking

  • Milestone changed from unassigned to 1.7

comment:7 follow-up: Changed 6 years ago by mahouni

  • Status changed from local_testing to to_alpha

tested locally (with firefox and chromium browser).
works for me. nice button!

Code looks fine too.

What was that video doing there? http://vimeo.com/moogaloop.swf?clip_id=3545292 Shake your Shame Off;)

comment:8 follow-up: Changed 6 years ago by shevek

Button looks good till you hover above it then it shows an ugly text-decoration. Could we get rid of that?

comment:9 in reply to: ↑ 8 Changed 6 years ago by crumbking

Replying to shevek:

Button looks good till you hover above it then it shows an ugly text-decoration. Could we get rid of that?

Yes!

comment:10 in reply to: ↑ 7 Changed 6 years ago by crumbking

Replying to mahouni:

What was that video doing there? http://vimeo.com/moogaloop.swf?clip_id=3545292 Shake your Shame Off;)

Don't ask me. Good that it never made to the startpage ;-)

comment:11 Changed 6 years ago by crumbking

Reminder for me: Test if a color fix for IE8 work on other browser, too new:#fb9e25

http://gitorious.org/bewelcome/rox/blobs/develop/htdocs/styles/css/minimal/screen/custom/index.css#line74

comment:12 Changed 6 years ago by shevek

Tested locally. Button also doesn't break anymore if window size is reduced. IE shows right color now. Ready for alpha indeed.

comment:13 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:14 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

tested on IE8, FF, Chrome.

Works on alpha.

comment:15 Changed 6 years ago by shevek

  • Resolution fixed deleted
  • Status changed from closed to reopened

Not sure if I missed that before but the color of the button with Chrome is far too light compared to the top menu. Please have a look.

comment:16 Changed 6 years ago by crumbking

Never aimed to be like the top menu. The top menu is a transition. So which color would you like to see?

comment:17 follow-up: Changed 6 years ago by shevek

Just a bit darker to match better with the top menu.

comment:18 in reply to: ↑ 17 Changed 6 years ago by crumbking

  • Status changed from reopened to local_testing

Replying to shevek:

Just a bit darker to match better with the top menu.

okay, test locally.

comment:19 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

Deployed to alpha. Better now. Closed as fixed.

comment:20 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:21 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.