Opened 6 years ago

Closed 6 years ago

#1847 closed bug (fixed)

word code "from" is used in two different templates

Reported by: globetrotter_tt Owned by: shevek
Priority: major Milestone: 1.3
Component: BW Search Keywords:
Cc: jsfan

Description (last modified by globetrotter_tt)

Issue:

We have a wordcode "from" (idword=25382) which is used in two different templates:

  1. in the results of the search
  2. in the email inbox

Currently it is translated to "Members" in the english version, which looks a bit strange in the search results.

Screenshot from messages


Screenshot from search

Attachments (2)

bw-messages.png (15.6 KB) - added by globetrotter_tt 6 years ago.
bw-searchresults.png (19.0 KB) - added by globetrotter_tt 6 years ago.

Download all attachments as: .zip

Change History (20)

Changed 6 years ago by globetrotter_tt

Changed 6 years ago by globetrotter_tt

comment:1 Changed 6 years ago by globetrotter_tt

  • Description modified (diff)

comment:2 Changed 6 years ago by crumbking

so we need a new wordcode in search or in messages?

comment:3 Changed 6 years ago by crumbking

I checked again what is the problem to translate it in both pages to "from"?

... in messages "from" is fine and in the search, too

comment:4 Changed 6 years ago by shevek

Why add a 'from' in the search results in the first place? It is rather obvious that a location is given there. But as a quick fix that's okay...

comment:5 Changed 6 years ago by globetrotter_tt

Crumbking, you will get in trouble when you translate the word "from". For German in the search it would be "aus" in messages "von".

So, maybe we should remove it from the search templates, but we should x-check if it is used in even more templates.

comment:6 Changed 6 years ago by crumbking

okay, agree I found 5 pages with from and suggest the following:

  • personal startpage (message) (KEEP)
  • profile visitor (delete)
  • mapsearch and text search (mapoff) (delete)
  • messages (KEEP)
Last edited 6 years ago by crumbking (previous) (diff)

comment:7 Changed 6 years ago by beatnickgr

Why do we need a feature to sort senders by username? i think this should be removed...

comment:8 Changed 6 years ago by shevek

@beatnickgr: Where did you find that? I can't see it.

comment:9 Changed 6 years ago by crumbking

  • Owner set to crumbking
  • Status changed from new to accepted

comment:10 Changed 6 years ago by beatnickgr

@shevek http://alpha.bewelcome.org/messages and clic "members"

comment:11 Changed 6 years ago by shevek

@beatnickgr: Thanks. I didn't realize that.

If you want to see all messages that you ever receive from a person that comes in handy. But I would add a filter instead as it might be difficult to get to the right person afterwards.

comment:12 Changed 6 years ago by shevek

  • Component changed from BW Layout to BW Search
  • Milestone changed from unassigned to 1.3
  • Owner changed from crumbking to shevek
  • Status changed from accepted to assigned

Removed the unnecessary 'Member' from the result list.

(Commit: https://gitorious.org/bewelcome/rox/commit/c186fad65ab4e60cea7d2074b613e560a0d01592)

comment:14 follow-up: Changed 6 years ago by shevek

First part is visible on alpha. No spurious member in the search results any more.

Profile visitor feature either works locally.

Last edited 6 years ago by shevek (previous) (diff)

comment:15 in reply to: ↑ 14 Changed 6 years ago by globetrotter_tt

  • Cc jsfan added

Replying to shevek:

First part is visible on alpha. No spurious member in the search results any more.

Profile visitor feature either works locally.

It still shows "member" on the profile visitor page. Not on alpha, yet?

comment:16 Changed 6 years ago by shevek

Right. Not on alpha yet.

jsfan hopefully pushes that soon and updates the tickets accordingly.

comment:17 Changed 6 years ago by jsfan

Deployed on alpha.

comment:18 Changed 6 years ago by globetrotter_tt

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks better now. I guess we can change the wordcode "from" from "member" back to "from" then.

Note: See TracTickets for help on using tickets.