Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1868 closed unknown (fixed)

Can't update empty fields in special relations

Reported by: shevek Owned by: shevek
Priority: major Milestone: 1.4
Component: BW Profile Keywords: easy
Cc: mahouni

Description (last modified by planetcruiser)

So I get a special relations request and because I'm in a hurry I just accept and decide to write something nice later on.

Epic fail. Doesn't work.

Reason is simply that edit profile expects that there is a valid TradId? for a relationship but InsertInTrad? returns directly if the string supplied is empty.

Related ticket:

Change History (15)

comment:1 Changed 6 years ago by shevek

There is a relation to this ticket: #1850 in that regard as InsertInMTrad is involved there as well...

Last edited 6 years ago by shevek (previous) (diff)

comment:2 Changed 6 years ago by planetcruiser

  • Description modified (diff)

added related ticket #1649

comment:3 Changed 6 years ago by planetcruiser

  • Description modified (diff)

comment:4 Changed 6 years ago by shevek

  • Keywords 1.4 added
  • Owner set to shevek
  • Status changed from new to assigned

comment:5 Changed 6 years ago by shevek

  • Keywords 1.4 removed
  • Milestone changed from unassigned to 1.4

comment:7 Changed 6 years ago by mahouni

  • Cc mahouni added

comment:8 Changed 6 years ago by crumbking

  • Component changed from unknown to BW Profile

comment:9 Changed 6 years ago by mahouni

tested locally: empty relationship can now be updated. Code reviewed: looks fine.

comment:10 Changed 6 years ago by shevek

Tested on alpha. Just updated one of my relationships (I still have some empty ones :-)).

comment:11 Changed 6 years ago by shevek

  • Status changed from assigned to testing

comment:12 Changed 6 years ago by crumbking

if someone write me a special relation I might be able to test this ;-)

comment:13 Changed 6 years ago by crumbking

thx, shevek: seems to work on alpha

comment:14 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.