Opened 6 years ago

Closed 6 years ago

#1873 closed improve feature (fixed)

Forum: Add location and country of poster

Reported by: shevek Owned by: shevek
Priority: minor Milestone: 1.6
Component: BW Forum Keywords: easy
Cc:

Description

As discussed here the information might be useful for members.

Info could be shown below the profile picture.

Guess that this is rather easy to accomplish so setting the easy keyword and a tentative 1.4.

Change History (19)

comment:1 Changed 6 years ago by shevek

  • Keywords 1.5 added; 1.4 removed

comment:2 Changed 6 years ago by jsfan

  • Milestone changed from unassigned to 1.5

comment:3 Changed 6 years ago by shevek

  • Owner set to shevek
  • Status changed from new to assigned

comment:4 Changed 6 years ago by shevek

As suggested in the forum thread implemented it in such a way that the country and location is only visible to logged in members.

Commit: https://gitorious.org/~thisismeonmounteverest/bewelcome/thisismeonheiligenberg-rox/commit/3edc6f9380d375bcdaea4ac9cd44881b21c2c67a

comment:5 Changed 6 years ago by shevek

During testing I realized that reply uses singlepost.php but doesn't use the same query. Added a check if city and country are set.

https://gitorious.org/~thisismeonmounteverest/bewelcome/thisismeonheiligenberg-rox/commit/ecee124fa21f90a01833ba98c8bbad748aea86d3

comment:6 Changed 6 years ago by shevek

  • Status changed from assigned to local_testing

comment:7 Changed 6 years ago by jsfan

  • Milestone changed from 1.5 to unassigned

Not yet in develop. Removed from milestone.

comment:8 Changed 6 years ago by shevek

  • Keywords 1.5 removed
  • Milestone changed from unassigned to 1.6-proposed

Adding to 1.6.

comment:9 Changed 6 years ago by crumbking

is this on develop?

Sure this works good for long strings?

comment:10 Changed 6 years ago by shevek

No, it wasn't yet: https://www.gitorious.org/bewelcome/rox/commit/11990d7fe5e5db06c20a046c5e8038c18bb33f49

The code cuts the name after 13 characters and adds a title tag to show the whole thing in a tooltip. During my tests that seemed to be fine.

comment:11 Changed 6 years ago by midsch

It works, but looks sometimes ugly through the 13 character limit. The mouse over works as well, but is it possible to show the complete string "$username, $city, $country" no matter where you do your mouseover? Right now you need to go over the city if the name is to long and get the city, for the next member you need to go over the country to get the country string. The image has another mouseover showing the username.

comment:12 Changed 6 years ago by crumbking

Hi shevek, I tested truncate_words which somehow looks much better ;-) I will commit if you don't mind.

Hi midsch, good idea!

Last edited 6 years ago by crumbking (previous) (diff)

comment:13 Changed 6 years ago by shevek

@crumbking: Go ahead. And while you're at it could you include midsch idea?

comment:14 Changed 6 years ago by crumbking

Okay done:

I grouped location tooltips. Left out the username. I think we can live with that. Also cleaned up a bit.

Test locally.

comment:15 Changed 6 years ago by crumbking

  • Status changed from local_testing to to_alpha

comment:16 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:17 Changed 6 years ago by sitatara

Looks good! Is there a reason why this information is only available in English?

comment:18 Changed 6 years ago by shevek

I can only show English at the moment, as that's the only information I have. With 1.7 that will hopefully change to show the information in the UI language.

comment:19 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

Great work.

Note: See TracTickets for help on using tickets.