Opened 6 years ago

Closed 5 years ago

#1881 closed bug (fixed)

Log in hint on places page can be easily missed

Reported by: planetcruiser Owned by: Tsjoek
Priority: major Milestone: 2.0
Component: unknown Keywords:
Cc: crumbking, shevek

Description

Issue:

  • #1757 introduced a fix that shows a non-existing user, with the name "Log in", age "to see more" and place "friendly members"
  • This link/hint can be very easily overlooked

Reproduce:

  1. Log out
  2. Go to http://www.bewelcome.org/places/FR/Aquitaine
  3. Try to find the link ;)

Suggested fix:

  • Have a bold question mark or three big periods ("...") instead of the teddy bear
  • Link all three lines
  • Give a different link colour, for example orange
  • Optional: Remove the "friendly" - that's a nice assumption, but a claim we can't fulfill, especially if a user with only negative comments is revealed afterwards
  • Optional: Mention how many more users there are, like in search ("Log in to see x more members") - we fetch the number already in the template, don't we?

Change History (14)

comment:1 Changed 5 years ago by Tsjoek

  • Owner set to Tsjoek
  • Status changed from new to assigned

It seems to me, I can pick this up. But the suggested fix still provides zero consistency with the rest of the website. I'm going for the same little sentence that is under the groupmemberlist and search.

comment:2 Changed 5 years ago by Tsjoek

  • Status changed from assigned to local_testing

Pushed the fix to develop. It uses the same (literally) sentences as the groupmemberlists do. Those sentences still lack a few variants, but I leave that for later, as it also involves the groups. In addition to the pure fix, also cleaned up the code a bit, made the layout a bit more consistent and closed a couple of possible xss vulnerabilities. In short: had some fun with it.

comment:3 Changed 5 years ago by Tsjoek

  • Milestone changed from unassigned to 2.0

comment:4 Changed 5 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:5 Changed 5 years ago by shevek

Deployed to alpha. Please test.

comment:6 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:7 follow-up: Changed 5 years ago by crumbking

Sorry, but in my opinion this is a rather ugly solution. (same as in groups) I mentioned my concerns there too.

Why should we mention the numbers here? We wanna show non members that there are more people in in some places. That's all :-) Let's keep it simple.

Thanks for fixing the lists. We should use the full width of the page. (there are some ready css files for fast switching between layouts)

I see: "Log in, um 359 weitere(s) Gruppenmitglied(er) zu sehen." which is kind of wrong ;-) Always introduce new translation words. Otherwise things get mixed up.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 5 years ago by Tsjoek

Replying to crumbking:

Sorry, but in my opinion this is a rather ugly solution.

More ugly than before? :-o

(same as in groups) I mentioned my concerns there too.

If it contains anything relevant to this ticket, please provide a link.

Why should we mention the numbers here? We wanna show non members that there are more people in in some places. That's all :-) Let's keep it simple.

I'm neutral to the numbers, for me the keyword is consistency. So I made the solution likewise.

It is however true that the numbers introduce all kind of interesting grammatical problems in certain languages (see also #1761). Now that I think of it again. It could become even more simple than that: "log in to see more". Which has its use even outside the scope of memberlists. But then groups and search should follow.

I see: "Log in, um 359 weitere(s) Gruppenmitglied(er) zu sehen." which is kind of wrong ;-)

That is a mistake in the German translation: it doesn't represent the English. The other languages (not too many have translated) are ok as far as i can see.

Always introduce new translation words. Otherwise things get mixed up.

I disagree on that one for more than 1 reason:

  • consistent UX : it would be shabby to show the same sentence, possibly with different translations or even in different languages. That can easily happen with a new code
  • volunteer efficiency : there are already 3000 wordcodes, translating all the time the same is not a very inspiring job for the Translation Team.
  • code efficiency : whatever job is done more than once, should be coded only once. The memberlist for a group and for places should ideally share the same view. Only the selection (model) is different. Even if that grail can't be reached (at once), code should always head towards that.

comment:9 in reply to: ↑ 8 ; follow-up: Changed 5 years ago by crumbking

Replying to Tsjoek:

Replying to crumbking:

Sorry, but in my opinion this is a rather ugly solution.

More ugly than before? :-o

No because I fixed the view before and introduced these great shiny login box :-) I'm a little bit biased ;-)

Always introduce new translation words. Otherwise things get mixed up.

I disagree on that one for more than 1 reason:

  • consistent UX : it would be shabby to show the same sentence, possibly with different translations or even in different languages. That can easily happen with a new code

I agree with your view. But a groups member list and people living in a place are two seperate things which should not have the same UX (and currently don't have)

  • volunteer efficiency : there are already 3000 wordcodes, translating all the time the same is not a very inspiring job for the Translation Team.

Half of them are not in use because of old code in /bw. Delete those in the DB will be much more vol efficient than introducing new ones.

  • code efficiency : whatever job is done more than once, should be coded only once. The memberlist for a group and for places should ideally share the same view. Only the selection (model) is different. Even if that grail can't be reached (at once), code should always head towards that.

So in the past this happen with your approach: http://trac.bewelcome.org/ticket/1847. This bug was open more than 7 month. The problem is there is no indicator for a translator like "Be careful with translating this wordcode as it's used in several templates." So introducing a new wordcode seems for me the more efficient idea as it's avoids bugs, coding and new testing in the long run. If it would not be Rox I would share your reasons ;-)

comment:10 in reply to: ↑ 9 ; follow-up: Changed 5 years ago by Tsjoek

I agree with your view. But a groups member list and people living in a place are two seperate things which should not have the same UX (and currently don't have)

What do you mean, currently don't have? A user of the website sees exactly the same thing: a non-detailed memberlist. The expectation is going to be exactly the same: if the first one has a sentence under it saying there's more members, you'd expect a similar list to have the same sentence (if applicable). Not out of a sudden a separate box.

  • volunteer efficiency : there are already 3000 wordcodes

Half of them are not in use because of old code in /bw. Delete those in the DB will be much more vol efficient than introducing new ones.

Oh for sure, that one is on my wishlist to be solved too, but it can't be an excuse to let things limitless grow at the other end.

  • code efficiency : whatever job is done more than once, should be coded only once.

So in the past this happen with your approach: http://trac.bewelcome.org/ticket/1847.

Sorry, but that doesn't even get close to 'my approach'. One-word wordcodes are a pain in the ass anyway, for the translators and obviously also for devs ;-) I'll add to my statement: whatever job is done, use your brain.

This bug was open more than 7 month.

16 days, but nevermind.

The problem is there is no indicator for a translator like "Be careful with translating this wordcode as it's used in several templates."

There is: Description, but probably the description for #1847 was as inspiring as: 'from' ;-)

If it would not be Rox I would share your reasons ;-)

Bad argument. I've been reading similar statements on many places. It seems to have become cool to state how bad Rox is, and a reason not to improve anything, because 'it is so bad'. Look, I also can't find anything in there which is not superficial, mostly because documentation seems to be inexistent. Rewriting 400k lines with Welen somewhere on the horizon this decade isn't worth it, but that doesn't mean there's totally nothing we can do about it. Things that become a habit now, will be easily implemented in Welen as well, good or bad.

Ok, before we end up in a long philosophical discussion about programming. Let's get back to the very ticket. I found a small issue in the layout of the lists, that I have fixed with: https://www.gitorious.org/bewelcome/rox/commit/af2b26f9d3cf27559a752291dc1a980ffcfc4d3c

I propose that if there is nothing else, we close this ticket and, if you wish, have the discussion about the there-is-more-hint in a more general context somewhere else, for example in the #1761, or any other suitable place.

comment:11 in reply to: ↑ 10 ; follow-up: Changed 5 years ago by crumbking

Replying to Tsjoek:

I propose that if there is nothing else, we close this ticket and, if you wish, have the discussion about the there-is-more-hint in a more general context somewhere else, for example in the #1761, or any other suitable place.

Anyway still don't agree with some of your views but as you mentioned let's move on :-)

comment:12 in reply to: ↑ 11 Changed 5 years ago by Tsjoek

Replying to crumbking:

  • As already mentioned there is still a small issue with the German translation: "Log in, um 359 weitere(s) Gruppenmitglied(er) zu sehen." Example page (switch to German): http://alpha.bewelcome.org/places/BD

I was about to make a post about it, when I noticed that you seem to have those rights yourself. Would you be so kind to remove 'Gruppen' from it? (or am I now pushing my luck? ;-) )

  • off topic: Could we go full width while adding this css file to the pages?

I've done my best to fix that with: http://gitorious.org/bewelcome/rox/commit/1fd1f842030d37572ed9835fe9823ce0c150c0d3/diffs/c98489dc193fd5730a45d8eb0cb5d23b0e7f9ea4

Not sure if the outcome is fully what was expected though.

Anyway still don't agree with some of your views

I've taken note of that. I might come back to it later.

comment:13 Changed 5 years ago by shevek

I introduced new words code 'PlaceMoreMembers?' and 'PlaceMoreLogin?' to be able to translate the 'login' part of the text as well.

comment:14 Changed 5 years ago by sitatara

  • Resolution set to fixed
  • Status changed from testing to closed

"Login to see more members" message is now much more visible than before.

Note: See TracTickets for help on using tickets.