Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1882 closed improve feature (fixed)

Add visibility marker to the first post of a thread

Reported by: shevek Owned by: shevek
Priority: major Milestone: 1.4
Component: BW Forum Keywords: 1.5
Cc:

Description

Currently a visibility marker is only added when a later post was edited. With the current setup it is not possible to see the visibility of a thread.

Change History (18)

comment:1 Changed 6 years ago by shevek

  • Keywords 1.5 added
  • Owner set to shevek
  • Status changed from new to assigned
  • Type changed from unknown to improve feature

comment:2 Changed 6 years ago by shevek

While I realized today that the absence of a marker means that the post has 'World' visibility I prepared a fix to add it nevertheless.

comment:3 Changed 6 years ago by mahouni

  • Milestone changed from unassigned to 1.4
  • Status changed from assigned to local_testing

comment:4 Changed 6 years ago by shevek

Checked the commit. 'Visibility: World' is visible. But as I changed the stuff myself that's probably not enough reason to push it to alpha ;-)

comment:5 Changed 6 years ago by crumbking

There is one issue. I started a thread within one of my groups. I set thread to world and submit. Afterwards I wanna edit the thread to set it to group only but the form shows just members/world as options.

comment:6 Changed 6 years ago by crumbking

This is the right way to go but I feel we need to introduce some info for the user what to do to see all posts.

Example: I start a thread "world" next one reply with "members" and third one with "group" Than I reply with world again. Logout and see that I discuss with myself ;-)

So some info like join group x to see this post/ login to see this post needs to be done.

comment:7 Changed 6 years ago by shevek

I hope our users aren't as fickle as you assume :-)

The issue described in comment 5 is the one that I described in #1849. When editing the system doesn't tell you it is a group post anymore (at least not in the URL) and therefore the ctrl doesn't set the group Id.

comment:8 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

I don't think we need to tell the users that they have to join the group to see all posts. The visibility tags tell them that they only see world and members post.

Code is deployed on alpha. So please test.

comment:9 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:10 Changed 6 years ago by jsfan

The functionality as described works. However, I can't see how we clearly display the thread visibility. While the first post should have the same visibility as the thread, I'm not 100% sure that they can never diverge.

As far as the placeholders go, I agree with crumbking but would claim that this is clearly a new ticket.

comment:11 Changed 6 years ago by shevek

@jsfan: The code change made sure that the first post always has the same visibility than the thread. If a thread starts with world and people post to it and then the topic starter is asked to change the visibility all people replying to the thread will be limited to the new visibility. Is that problematic?

An additional question is: What happens if a moderator changes the visibility of the first post? Does that affect the thread visibility or not?

@crumbking, jsfan: Regarding comment 6: That's what happens already now if someone takes the hassle to edit the visibility. Can't see a problem with that.

That the content of a group only post isn't shown if you're not a member of that group is intentional but there needs to be a note why it isn't shown (as Leo's mail to the dev list have shown).

comment:12 Changed 6 years ago by shevek

  • Status changed from testing to needs_work

Added the note and removed the workaround for group replys (see #1849):

https://gitorious.org/bewelcome/rox/commit/7ae1be962485bc328af96e5bd8f0d2e0ef209ce1

comment:13 Changed 6 years ago by shevek

  • Status changed from needs_work to local_testing

comment:14 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:15 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

Made it to alpha with the latest pull.

comment:16 Changed 6 years ago by mahouni

  • Resolution set to fixed
  • Status changed from testing to closed

Seems to work!

I'd close that ticket, but keep testing on alpha.

comment:17 Changed 6 years ago by shevek

  • Component changed from unknown to BW Forum

comment:18 Changed 6 years ago by planetcruiser

tested ok, i see "Visibility: World" on posts

Note: See TracTickets for help on using tickets.