Opened 4 years ago

Last modified 3 years ago

#1902 needs_work bug

privacy issue: upcoming trips and next visitors of your place shows protected and private subtrip/blog entries

Reported by: crumbking Owned by:
Priority: major Milestone: In Discussion
Component: BW Trips Keywords:
Cc:

Description

Issue

While creating trip destinations (subtrips) you are able to set a visibility option. If protected is selected the destination is hidden and only visible for the creator. Other members will see the trip destination on the internal startpage and on the upcoming trip section of the profile. They should not show up there.

Change History (10)

comment:1 Changed 4 years ago by shevek

I always understood that protected means members only. As opposed to private where the trip is only visible for the creator (note the small c) itself.

comment:2 Changed 4 years ago by sitatara

  • Priority changed from minor to major

See description of #1977 (duplicate) too.

comment:3 Changed 3 years ago by shevek

  • Milestone changed from unassigned to 2.3
  • Status changed from new to to_alpha

As no code at all exists in neither the trip controller nor the model to handle these settings I removed the fieldset so that the issue itself is gone as it is now clear that all trips are members only (see changes for #2142).

Commit: https://gitorious.org/bewelcome/rox/commit/0082d872cfe75eb9e810f9b0d0ae71440786be1e

comment:4 Changed 3 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha.

comment:5 Changed 3 years ago by sitatara

Trips are no longer publicly visible (so that issue in #1977 is resolved), only for members. Should we keep this ticket open to actually introduce privacy settings (to make a trip completely private?). I don't really see the need for that (why would someone use BeWelcome to create a trip and then let nobody see it?).

comment:6 Changed 3 years ago by crumbking

The setting code is in the blog model and controller. Removing the settings is not the meaning of the ticket.

The problem of the ticket is: "Other members will see the trip destination on the internal startpage and on the upcoming trip section of the profile. They should not show up there.

Protected means that you write your destinations but do not "publish" them to members or the public.

Anyway I have no problem to remove trips from the public. But then we should remove the menu item while not logged in, too. Wonder what the trip thing then will be used, too.

comment:7 Changed 3 years ago by shevek

@crumbking: I didn't see any code that would support your point of view could you provide pointers to the code please? Might as well be that I didn't find them.

comment:8 Changed 3 years ago by crumbking

Blogs and trips are mixed up in a terrible way ;-)

Do a repro search for:

$vars['vis']
  • blog.model.php:line 295 ongoing
  • blog.ctrl.php: 343 ongoing, 495 ongoing, 624 ongoing

The ticket is about to introduce the visibility checks in trips.lib.php so that if a user choose the setting protected it will no show up on the personal startpage and in the upcoming trip section in the profile

comment:9 Changed 3 years ago by crumbking

  • Milestone changed from 2.3 to In Discussion
  • Status changed from testing to needs_work

comment:10 Changed 3 years ago by crumbking

still in discussion

Note: See TracTickets for help on using tickets.