Opened 6 years ago

Closed 6 years ago

#1924 closed improve feature (fixed)

Upgrade Leaflet 0.45 -> 0.5

Reported by: mikael Owned by: toub
Priority: minor Milestone: 1.7
Component: BW Geo Keywords: leaflet
Cc:

Description

Leaflet 0.45 has some bugs when pannin/zooming with some new versions of Firefox/Chrome?/IE. They just published v0.5 that fixes most of the issues and brings in a whole lot other improvements.

I'd suggest to upgrade, or we'll hit those bugs when these browsers's edge versions mature and become more popular. It shouldn't be too complicated since 0.5 doesn't change the API much. It's more under the hood performance/stability kind of stuff.

Change History (13)

comment:1 Changed 6 years ago by shevek

  • Milestone changed from unassigned to 1.5
  • Owner set to shevek
  • Status changed from new to assigned

I'd like to see this in 1.5 as I already reported one of the problems with Firefox 18.

Additionally they introduced an API function that I need for the refined search.

comment:2 Changed 6 years ago by jsfan

  • Milestone changed from 1.5 to unassigned

I am removing this from 1.5 for now. If there is enough time to squeeze it in and test it sufficiently when everything else is completed, we can take it back in. Otherwise, we could have this in 1.6.

comment:3 Changed 6 years ago by toub

  • Milestone changed from unassigned to 1.7
  • Owner changed from shevek to toub

comment:4 Changed 6 years ago by toub

Pushed to develop.

comment:5 Changed 6 years ago by crumbking

  • Status changed from assigned to local_testing

comment:6 Changed 6 years ago by crumbking

  • Status changed from local_testing to to_alpha

not sure actually what to test here: clicked around to pages with maps, did some map searches so better let's check that a bit deeper on alpha, once again

comment:7 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha. Please test.

comment:8 Changed 6 years ago by crumbking

FF20: Zoom buttons do not work anymore. Also the map is zoomed out totally.

Just the map search seems to work.

comment:9 Changed 6 years ago by toub

Very annoying bug, thanks for the test.

Was due to a setMaxZoom to null.

I just pushed the fix, please test again locally, then in alpha when redeployed.

comment:10 Changed 6 years ago by crumbking

  • Status changed from testing to needs_work

work locally

comment:11 Changed 6 years ago by crumbking

  • Status changed from needs_work to to_alpha

comment:12 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha.

comment:13 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

All maps behave as before now. Closed as fixed.

Note: See TracTickets for help on using tickets.